[INFO] updating cached repository euwbah/rusty-brain [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/euwbah/rusty-brain [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/euwbah/rusty-brain" "work/ex/clippy-test-run/sources/stable/gh/euwbah/rusty-brain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/euwbah/rusty-brain'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/euwbah/rusty-brain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/euwbah/rusty-brain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/euwbah/rusty-brain'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3db43b895d089f74ae4c5640a8c2d7d2b1f38afd [INFO] sha for GitHub repo euwbah/rusty-brain: 3db43b895d089f74ae4c5640a8c2d7d2b1f38afd [INFO] validating manifest of euwbah/rusty-brain on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of euwbah/rusty-brain on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing euwbah/rusty-brain [INFO] finished frobbing euwbah/rusty-brain [INFO] frobbed toml for euwbah/rusty-brain written to work/ex/clippy-test-run/sources/stable/gh/euwbah/rusty-brain/Cargo.toml [INFO] started frobbing euwbah/rusty-brain [INFO] finished frobbing euwbah/rusty-brain [INFO] frobbed toml for euwbah/rusty-brain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/euwbah/rusty-brain/Cargo.toml [INFO] crate euwbah/rusty-brain has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting euwbah/rusty-brain against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/euwbah/rusty-brain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c4380d8f48cea56a3c2d120ec657c01195432a1af1e04e088a71944bef3aed1 [INFO] running `"docker" "start" "-a" "4c4380d8f48cea56a3c2d120ec657c01195432a1af1e04e088a71944bef3aed1"` [INFO] [stderr] Compiling ndarray v0.12.0 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking neural-network v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `ndarray::Axis` [INFO] [stderr] --> src/layers.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use ndarray::Axis; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ndarray::ArrayBase` [INFO] [stderr] --> src/layers.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use ndarray::ArrayBase; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/layers.rs:54:47 [INFO] [stderr] | [INFO] [stderr] 54 | let vals = self.training_inputs.slice(s![idx, ..]); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/layers.rs:128:54 [INFO] [stderr] | [INFO] [stderr] 128 | let vals = self.training_ground_truths.slice(s![idx, ..]); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/layers.rs:154:51 [INFO] [stderr] | [INFO] [stderr] 154 | let a = self.training_ground_truths.slice(s![iter, ..]); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused import: `ndarray::Axis` [INFO] [stderr] --> src/layers.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use ndarray::Axis; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ndarray::ArrayBase` [INFO] [stderr] --> src/layers.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use ndarray::ArrayBase; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/layers.rs:54:47 [INFO] [stderr] | [INFO] [stderr] 54 | let vals = self.training_inputs.slice(s![idx, ..]); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/layers.rs:128:54 [INFO] [stderr] | [INFO] [stderr] 128 | let vals = self.training_ground_truths.slice(s![idx, ..]); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/layers.rs:154:51 [INFO] [stderr] | [INFO] [stderr] 154 | let a = self.training_ground_truths.slice(s![iter, ..]); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | fn get_training_state(&self) -> &TrainingState; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | fn get_training_state_mut(&mut self) -> &mut TrainingState; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | / fn get_training_state(&self) -> &TrainingState { [INFO] [stderr] 269 | | &self.training_state [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:272:5 [INFO] [stderr] | [INFO] [stderr] 272 | / fn get_training_state_mut(&mut self) -> &mut TrainingState { [INFO] [stderr] 273 | | &mut self.training_state [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:347:5 [INFO] [stderr] | [INFO] [stderr] 347 | / fn get_training_state(&self) -> &TrainingState { [INFO] [stderr] 348 | | &self.training_state [INFO] [stderr] 349 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | / fn get_training_state_mut(&mut self) -> &mut TrainingState { [INFO] [stderr] 352 | | &mut self.training_state [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:453:5 [INFO] [stderr] | [INFO] [stderr] 453 | / fn get_training_state(&self) -> &TrainingState { [INFO] [stderr] 454 | | &self.training_state [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:457:5 [INFO] [stderr] | [INFO] [stderr] 457 | / fn get_training_state_mut(&mut self) -> &mut TrainingState { [INFO] [stderr] 458 | | &mut self.training_state [INFO] [stderr] 459 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:577:5 [INFO] [stderr] | [INFO] [stderr] 577 | / fn get_training_state(&self) -> &TrainingState { [INFO] [stderr] 578 | | &self.training_state [INFO] [stderr] 579 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:581:5 [INFO] [stderr] | [INFO] [stderr] 581 | / fn get_training_state_mut(&mut self) -> &mut TrainingState { [INFO] [stderr] 582 | | &mut self.training_state [INFO] [stderr] 583 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: unused variable: `step_size` [INFO] [stderr] --> src/node.rs:164:34 [INFO] [stderr] | [INFO] [stderr] 164 | fn update_weights(&mut self, step_size: f64) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_step_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node_name` [INFO] [stderr] --> src/node.rs:276:39 [INFO] [stderr] | [INFO] [stderr] 276 | fn calc_derivative_against(&self, input_node_name: &str) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_input_node_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node` [INFO] [stderr] --> src/node.rs:292:34 [INFO] [stderr] | [INFO] [stderr] 292 | fn add_input_node(&mut self, input_node: AM) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_input_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node` [INFO] [stderr] --> src/node.rs:296:39 [INFO] [stderr] | [INFO] [stderr] 296 | fn add_input_node_init(&mut self, input_node: AM, weight: f64) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_input_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `weight` [INFO] [stderr] --> src/node.rs:296:68 [INFO] [stderr] | [INFO] [stderr] 296 | fn add_input_node_init(&mut self, input_node: AM, weight: f64) { [INFO] [stderr] | ^^^^^^ help: consider using `_weight` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node_name` [INFO] [stderr] --> src/node.rs:355:39 [INFO] [stderr] | [INFO] [stderr] 355 | fn calc_derivative_against(&self, input_node_name: &str) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_input_node_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node` [INFO] [stderr] --> src/node.rs:371:34 [INFO] [stderr] | [INFO] [stderr] 371 | fn add_input_node(&mut self, input_node: AM) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_input_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node` [INFO] [stderr] --> src/node.rs:375:39 [INFO] [stderr] | [INFO] [stderr] 375 | fn add_input_node_init(&mut self, input_node: AM, weight: f64) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_input_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `weight` [INFO] [stderr] --> src/node.rs:375:68 [INFO] [stderr] | [INFO] [stderr] 375 | fn add_input_node_init(&mut self, input_node: AM, weight: f64) { [INFO] [stderr] | ^^^^^^ help: consider using `_weight` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/node.rs:440:20 [INFO] [stderr] | [INFO] [stderr] 440 | |acc, (name, node_weight)| { [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `step_size` [INFO] [stderr] --> src/node.rs:603:34 [INFO] [stderr] | [INFO] [stderr] 603 | fn update_weights(&mut self, step_size: f64) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_step_size` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let mut i1 = InputNode::new("i1", 0.6); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | let mut i2 = InputNode::new("i2", 1.0); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let mut input_layer = [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | let mut s1 = SumNode::new("s1"); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | let mut output_layer = [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/layers.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | let mut expected_ground_truths: Vec = vals.to_vec(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_network_configs` [INFO] [stderr] --> src/network.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn set_network_configs(&mut self, network_configs: NetworkConfigs) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `calc_avg_training_loss` [INFO] [stderr] --> src/network.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn calc_avg_training_loss(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update_weights` [INFO] [stderr] --> src/network.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn update_weights(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `train_one_epoch` [INFO] [stderr] --> src/network.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn train_one_epoch(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `connect` [INFO] [stderr] --> src/node.rs:197:1 [INFO] [stderr] | [INFO] [stderr] 197 | pub fn connect(a: AM, b: AM) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ConstantNode` [INFO] [stderr] --> src/node.rs:308:1 [INFO] [stderr] | [INFO] [stderr] 308 | pub struct ConstantNode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/node.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | pub fn new(name: &str, const_value: f64) -> AM { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SigmoidNode` [INFO] [stderr] --> src/node.rs:543:1 [INFO] [stderr] | [INFO] [stderr] 543 | pub struct SigmoidNode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_ground_truth` [INFO] [stderr] --> src/layers.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn get_ground_truth(&self, iter: usize, node_name: &str) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/node.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if let Some(_) = NODES.lock().unwrap().insert(name.to_string(), node) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 20 | | panic!("Cannot create two nodes with same name! [{}]", name); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____- help: try this: `if NODES.lock().unwrap().insert(name.to_string(), node).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/node.rs:466:14 [INFO] [stderr] | [INFO] [stderr] 466 | .expect(format!("[{}] is not an input of [{}]", input_node_name, self.name).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("[{}] is not an input of [{}]", input_node_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/node.rs:512:5 [INFO] [stderr] | [INFO] [stderr] 512 | / fn input_nodes<'a>(&'a self) -> Vec> { [INFO] [stderr] 513 | | self.inputs.lock().unwrap().iter().map(|(_, x)| x.node.clone()).collect() [INFO] [stderr] 514 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/node.rs:595:18 [INFO] [stderr] | [INFO] [stderr] 595 | .expect(format!("[{}] is not an input of [{}]", input_node_name, self.name).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("[{}] is not an input of [{}]", input_node_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/layers.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(nodes: &Vec>, training_vals: &[f64]) -> InputLayer { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AM]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/layers.rs:85:23 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn new(nodes: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[AM]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/layers.rs:148:45 [INFO] [stderr] | [INFO] [stderr] 148 | self.training_ground_truths[[iter, *self.node_name_to_index_map.get(node_name).unwrap()]] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.node_name_to_index_map[node_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:92:54 [INFO] [stderr] | [INFO] [stderr] 92 | 2.0 * (node.get_last_calc_activation() - gt.get(node_name).unwrap()) / output_node_count [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `>[node_name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | fn get_training_state(&self) -> &TrainingState; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | fn get_training_state_mut(&mut self) -> &mut TrainingState; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | / fn get_training_state(&self) -> &TrainingState { [INFO] [stderr] 269 | | &self.training_state [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:272:5 [INFO] [stderr] | [INFO] [stderr] 272 | / fn get_training_state_mut(&mut self) -> &mut TrainingState { [INFO] [stderr] 273 | | &mut self.training_state [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:347:5 [INFO] [stderr] | [INFO] [stderr] 347 | / fn get_training_state(&self) -> &TrainingState { [INFO] [stderr] 348 | | &self.training_state [INFO] [stderr] 349 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | / fn get_training_state_mut(&mut self) -> &mut TrainingState { [INFO] [stderr] 352 | | &mut self.training_state [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:453:5 [INFO] [stderr] | [INFO] [stderr] 453 | / fn get_training_state(&self) -> &TrainingState { [INFO] [stderr] 454 | | &self.training_state [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:457:5 [INFO] [stderr] | [INFO] [stderr] 457 | / fn get_training_state_mut(&mut self) -> &mut TrainingState { [INFO] [stderr] 458 | | &mut self.training_state [INFO] [stderr] 459 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:577:5 [INFO] [stderr] | [INFO] [stderr] 577 | / fn get_training_state(&self) -> &TrainingState { [INFO] [stderr] 578 | | &self.training_state [INFO] [stderr] 579 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `node::TrainingState` in public interface (error E0446) [INFO] [stderr] --> src/node.rs:581:5 [INFO] [stderr] | [INFO] [stderr] 581 | / fn get_training_state_mut(&mut self) -> &mut TrainingState { [INFO] [stderr] 582 | | &mut self.training_state [INFO] [stderr] 583 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: unused variable: `step_size` [INFO] [stderr] --> src/node.rs:164:34 [INFO] [stderr] | [INFO] [stderr] 164 | fn update_weights(&mut self, step_size: f64) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_step_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node_name` [INFO] [stderr] --> src/node.rs:276:39 [INFO] [stderr] | [INFO] [stderr] 276 | fn calc_derivative_against(&self, input_node_name: &str) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_input_node_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node` [INFO] [stderr] --> src/node.rs:292:34 [INFO] [stderr] | [INFO] [stderr] 292 | fn add_input_node(&mut self, input_node: AM) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_input_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node` [INFO] [stderr] --> src/node.rs:296:39 [INFO] [stderr] | [INFO] [stderr] 296 | fn add_input_node_init(&mut self, input_node: AM, weight: f64) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_input_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `weight` [INFO] [stderr] --> src/node.rs:296:68 [INFO] [stderr] | [INFO] [stderr] 296 | fn add_input_node_init(&mut self, input_node: AM, weight: f64) { [INFO] [stderr] | ^^^^^^ help: consider using `_weight` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node_name` [INFO] [stderr] --> src/node.rs:355:39 [INFO] [stderr] | [INFO] [stderr] 355 | fn calc_derivative_against(&self, input_node_name: &str) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_input_node_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node` [INFO] [stderr] --> src/node.rs:371:34 [INFO] [stderr] | [INFO] [stderr] 371 | fn add_input_node(&mut self, input_node: AM) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_input_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input_node` [INFO] [stderr] --> src/node.rs:375:39 [INFO] [stderr] | [INFO] [stderr] 375 | fn add_input_node_init(&mut self, input_node: AM, weight: f64) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_input_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `weight` [INFO] [stderr] --> src/node.rs:375:68 [INFO] [stderr] | [INFO] [stderr] 375 | fn add_input_node_init(&mut self, input_node: AM, weight: f64) { [INFO] [stderr] | ^^^^^^ help: consider using `_weight` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/node.rs:440:20 [INFO] [stderr] | [INFO] [stderr] 440 | |acc, (name, node_weight)| { [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `step_size` [INFO] [stderr] --> src/node.rs:603:34 [INFO] [stderr] | [INFO] [stderr] 603 | fn update_weights(&mut self, step_size: f64) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_step_size` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let mut i1 = InputNode::new("i1", 0.6); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | let mut i2 = InputNode::new("i2", 1.0); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let mut input_layer = [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | let mut s1 = SumNode::new("s1"); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | let mut output_layer = [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/layers.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | let mut expected_ground_truths: Vec = vals.to_vec(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_network_configs` [INFO] [stderr] --> src/network.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn set_network_configs(&mut self, network_configs: NetworkConfigs) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `calc_avg_training_loss` [INFO] [stderr] --> src/network.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn calc_avg_training_loss(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update_weights` [INFO] [stderr] --> src/network.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn update_weights(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `train_one_epoch` [INFO] [stderr] --> src/network.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn train_one_epoch(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `connect` [INFO] [stderr] --> src/node.rs:197:1 [INFO] [stderr] | [INFO] [stderr] 197 | pub fn connect(a: AM, b: AM) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ConstantNode` [INFO] [stderr] --> src/node.rs:308:1 [INFO] [stderr] | [INFO] [stderr] 308 | pub struct ConstantNode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/node.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | pub fn new(name: &str, const_value: f64) -> AM { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SigmoidNode` [INFO] [stderr] --> src/node.rs:543:1 [INFO] [stderr] | [INFO] [stderr] 543 | pub struct SigmoidNode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_ground_truth` [INFO] [stderr] --> src/layers.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn get_ground_truth(&self, iter: usize, node_name: &str) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/node.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if let Some(_) = NODES.lock().unwrap().insert(name.to_string(), node) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 20 | | panic!("Cannot create two nodes with same name! [{}]", name); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____- help: try this: `if NODES.lock().unwrap().insert(name.to_string(), node).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/node.rs:466:14 [INFO] [stderr] | [INFO] [stderr] 466 | .expect(format!("[{}] is not an input of [{}]", input_node_name, self.name).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("[{}] is not an input of [{}]", input_node_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/node.rs:512:5 [INFO] [stderr] | [INFO] [stderr] 512 | / fn input_nodes<'a>(&'a self) -> Vec> { [INFO] [stderr] 513 | | self.inputs.lock().unwrap().iter().map(|(_, x)| x.node.clone()).collect() [INFO] [stderr] 514 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/node.rs:595:18 [INFO] [stderr] | [INFO] [stderr] 595 | .expect(format!("[{}] is not an input of [{}]", input_node_name, self.name).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("[{}] is not an input of [{}]", input_node_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/layers.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(nodes: &Vec>, training_vals: &[f64]) -> InputLayer { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AM]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/layers.rs:85:23 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn new(nodes: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[AM]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/layers.rs:148:45 [INFO] [stderr] | [INFO] [stderr] 148 | self.training_ground_truths[[iter, *self.node_name_to_index_map.get(node_name).unwrap()]] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.node_name_to_index_map[node_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:92:54 [INFO] [stderr] | [INFO] [stderr] 92 | 2.0 * (node.get_last_calc_activation() - gt.get(node_name).unwrap()) / output_node_count [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `>[node_name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.11s [INFO] running `"docker" "inspect" "4c4380d8f48cea56a3c2d120ec657c01195432a1af1e04e088a71944bef3aed1"` [INFO] running `"docker" "rm" "-f" "4c4380d8f48cea56a3c2d120ec657c01195432a1af1e04e088a71944bef3aed1"` [INFO] [stdout] 4c4380d8f48cea56a3c2d120ec657c01195432a1af1e04e088a71944bef3aed1