[INFO] updating cached repository eugeneyche/gl_is_fun_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eugeneyche/gl_is_fun_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eugeneyche/gl_is_fun_rs" "work/ex/clippy-test-run/sources/stable/gh/eugeneyche/gl_is_fun_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eugeneyche/gl_is_fun_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eugeneyche/gl_is_fun_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eugeneyche/gl_is_fun_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eugeneyche/gl_is_fun_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a7283526afec4ccda65e70903fedf7794ad4e936 [INFO] sha for GitHub repo eugeneyche/gl_is_fun_rs: a7283526afec4ccda65e70903fedf7794ad4e936 [INFO] validating manifest of eugeneyche/gl_is_fun_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eugeneyche/gl_is_fun_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eugeneyche/gl_is_fun_rs [INFO] finished frobbing eugeneyche/gl_is_fun_rs [INFO] frobbed toml for eugeneyche/gl_is_fun_rs written to work/ex/clippy-test-run/sources/stable/gh/eugeneyche/gl_is_fun_rs/Cargo.toml [INFO] started frobbing eugeneyche/gl_is_fun_rs [INFO] finished frobbing eugeneyche/gl_is_fun_rs [INFO] frobbed toml for eugeneyche/gl_is_fun_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eugeneyche/gl_is_fun_rs/Cargo.toml [INFO] crate eugeneyche/gl_is_fun_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eugeneyche/gl_is_fun_rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eugeneyche/gl_is_fun_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c342f2a5e8c4eccc67fc3c48d5b016e0c51477c67e6eeec541ddae2a8cea960 [INFO] running `"docker" "start" "-a" "7c342f2a5e8c4eccc67fc3c48d5b016e0c51477c67e6eeec541ddae2a8cea960"` [INFO] [stderr] Compiling x11-dl v2.17.1 [INFO] [stderr] Compiling wayland-scanner v0.12.4 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking wayland-sys v0.12.4 [INFO] [stderr] Compiling wayland-client v0.12.4 [INFO] [stderr] Compiling wayland-protocols v0.12.4 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking wayland-kbd v0.13.0 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking winit v0.9.0 [INFO] [stderr] Checking glutin v0.11.0 [INFO] [stderr] Checking gl_fun v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | gl_id: gl_id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gl_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | pixels: pixels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | gl_id: gl_id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gl_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader_program.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | gl_id: gl_id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gl_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader_program.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:60:37 [INFO] [stderr] | [INFO] [stderr] 60 | let mut texture = Texture { gl_id: gl_id }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gl_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | unit_index: unit_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex_array.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | gl_id: gl_id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gl_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex_array.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | vertex_array: vertex_array, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex_array.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | vertex_buffer: vertex_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | gl_id: gl_id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gl_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | pixels: pixels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | gl_id: gl_id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gl_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader_program.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | gl_id: gl_id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gl_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader_program.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:60:37 [INFO] [stderr] | [INFO] [stderr] 60 | let mut texture = Texture { gl_id: gl_id }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gl_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | unit_index: unit_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex_array.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | gl_id: gl_id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gl_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex_array.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | vertex_array: vertex_array, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex_array.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | vertex_buffer: vertex_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `index_buffer` [INFO] [stderr] --> src/vertex_array.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | index_buffer: BoundIndexBuffer<'b>, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_index_buffer` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `IndexBufferTy` [INFO] [stderr] --> src/buffer.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct IndexBufferTy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DynamicRead` [INFO] [stderr] --> src/buffer.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | DynamicRead, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StaticRead` [INFO] [stderr] --> src/buffer.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | StaticRead, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StaticDraw` [INFO] [stderr] --> src/buffer.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | StaticDraw, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StreamRead` [INFO] [stderr] --> src/buffer.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | StreamRead, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StreamDraw` [INFO] [stderr] --> src/buffer.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | StreamDraw, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `buffer` [INFO] [stderr] --> src/buffer.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | buffer: &'a mut Buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `IndexBuffer` [INFO] [stderr] --> src/buffer.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | pub type IndexBuffer = Buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `BoundIndexBuffer` [INFO] [stderr] --> src/buffer.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | pub type BoundIndexBuffer<'a> = BoundBuffer<'a, IndexBufferTy>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Geometry` [INFO] [stderr] --> src/shader.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Geometry, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `program` [INFO] [stderr] --> src/shader_program.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | program: &'a mut ShaderProgram, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float` [INFO] [stderr] --> src/shader_program.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn uniform_float(&mut self, location: UniformLocation, value: f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec2` [INFO] [stderr] --> src/shader_program.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn uniform_float_vec2(&mut self, location: UniformLocation, value: &[f32; 2]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec3` [INFO] [stderr] --> src/shader_program.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn uniform_float_vec3(&mut self, location: UniformLocation, value: &[f32; 3]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec4` [INFO] [stderr] --> src/shader_program.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn uniform_float_vec4(&mut self, location: UniformLocation, value: &[f32; 4]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_array` [INFO] [stderr] --> src/shader_program.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn uniform_float_array(&mut self, location: UniformLocation, value: &[f32]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec2_array` [INFO] [stderr] --> src/shader_program.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn uniform_float_vec2_array(&mut self, location: UniformLocation, value: &[[f32; 2]]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec3_array` [INFO] [stderr] --> src/shader_program.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn uniform_float_vec3_array(&mut self, location: UniformLocation, value: &[[f32; 3]]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec4_array` [INFO] [stderr] --> src/shader_program.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn uniform_float_vec4_array(&mut self, location: UniformLocation, value: &[[f32; 4]]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_mat2` [INFO] [stderr] --> src/shader_program.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn uniform_float_mat2(&mut self, location: UniformLocation, value: &[f32; 4]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_mat3` [INFO] [stderr] --> src/shader_program.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn uniform_float_mat3(&mut self, location: UniformLocation, value: &[f32; 9]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Linear` [INFO] [stderr] --> src/texture.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Linear, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `texture` [INFO] [stderr] --> src/texture.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | texture: &'a mut Texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Float` [INFO] [stderr] --> src/vertex_array.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | Float, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FloatVec4` [INFO] [stderr] --> src/vertex_array.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | FloatVec4, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Points` [INFO] [stderr] --> src/vertex_array.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | Points, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lines` [INFO] [stderr] --> src/vertex_array.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Lines, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Triangles` [INFO] [stderr] --> src/vertex_array.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | Triangles, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `vertex_array` [INFO] [stderr] --> src/vertex_array.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | vertex_array: &'a mut VertexArray, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `vertex_buffer` [INFO] [stderr] --> src/vertex_array.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | vertex_buffer: BoundVertexBuffer<'a>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_elements` [INFO] [stderr] --> src/vertex_array.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / pub fn draw_elements<'b>( [INFO] [stderr] 118 | | &mut self, [INFO] [stderr] 119 | | draw_ty: DrawTy, [INFO] [stderr] 120 | | index_buffer: BoundIndexBuffer<'b>, [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buffer.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn bind<'a>(&'a mut self) -> BoundBuffer<'a, Ty> { [INFO] [stderr] 81 | | BoundBuffer::new(self) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/shader_program.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn activate<'a>(&'a mut self) -> ActivatedShaderProgram<'a> { [INFO] [stderr] 81 | | ActivatedShaderProgram::new(self) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/shader_program.rs:116:76 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn uniform_float_vec2(&mut self, location: UniformLocation, value: &[f32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/texture.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn bind<'a>(&'a mut self, unit_index: u32) -> BoundTexture<'a> { [INFO] [stderr] 66 | | BoundTexture::new(unit_index, self) [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/vertex_array.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | 0 as *const _, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | / match event { [INFO] [stderr] 100 | | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] 101 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 102 | | _ => () [INFO] [stderr] 103 | | }, [INFO] [stderr] 104 | | _ => () [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 99 | if let glutin::Event::WindowEvent{ event, .. } = event { match event { [INFO] [stderr] 100 | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 101 | _ => () [INFO] [stderr] 102 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:100:60 [INFO] [stderr] | [INFO] [stderr] 100 | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 101 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 102 | | _ => () [INFO] [stderr] 103 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let glutin::WindowEvent::Closed = event { running = false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | gl_window.swap_buffers(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `index_buffer` [INFO] [stderr] --> src/vertex_array.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | index_buffer: BoundIndexBuffer<'b>, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_index_buffer` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `IndexBufferTy` [INFO] [stderr] --> src/buffer.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct IndexBufferTy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DynamicRead` [INFO] [stderr] --> src/buffer.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | DynamicRead, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StaticRead` [INFO] [stderr] --> src/buffer.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | StaticRead, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StaticDraw` [INFO] [stderr] --> src/buffer.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | StaticDraw, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StreamRead` [INFO] [stderr] --> src/buffer.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | StreamRead, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StreamDraw` [INFO] [stderr] --> src/buffer.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | StreamDraw, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `buffer` [INFO] [stderr] --> src/buffer.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | buffer: &'a mut Buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `IndexBuffer` [INFO] [stderr] --> src/buffer.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | pub type IndexBuffer = Buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `BoundIndexBuffer` [INFO] [stderr] --> src/buffer.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | pub type BoundIndexBuffer<'a> = BoundBuffer<'a, IndexBufferTy>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Geometry` [INFO] [stderr] --> src/shader.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Geometry, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `program` [INFO] [stderr] --> src/shader_program.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | program: &'a mut ShaderProgram, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float` [INFO] [stderr] --> src/shader_program.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn uniform_float(&mut self, location: UniformLocation, value: f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec2` [INFO] [stderr] --> src/shader_program.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn uniform_float_vec2(&mut self, location: UniformLocation, value: &[f32; 2]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec3` [INFO] [stderr] --> src/shader_program.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn uniform_float_vec3(&mut self, location: UniformLocation, value: &[f32; 3]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec4` [INFO] [stderr] --> src/shader_program.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn uniform_float_vec4(&mut self, location: UniformLocation, value: &[f32; 4]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_array` [INFO] [stderr] --> src/shader_program.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn uniform_float_array(&mut self, location: UniformLocation, value: &[f32]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec2_array` [INFO] [stderr] --> src/shader_program.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn uniform_float_vec2_array(&mut self, location: UniformLocation, value: &[[f32; 2]]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec3_array` [INFO] [stderr] --> src/shader_program.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn uniform_float_vec3_array(&mut self, location: UniformLocation, value: &[[f32; 3]]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_vec4_array` [INFO] [stderr] --> src/shader_program.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn uniform_float_vec4_array(&mut self, location: UniformLocation, value: &[[f32; 4]]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_mat2` [INFO] [stderr] --> src/shader_program.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn uniform_float_mat2(&mut self, location: UniformLocation, value: &[f32; 4]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uniform_float_mat3` [INFO] [stderr] --> src/shader_program.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn uniform_float_mat3(&mut self, location: UniformLocation, value: &[f32; 9]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Linear` [INFO] [stderr] --> src/texture.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Linear, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `texture` [INFO] [stderr] --> src/texture.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | texture: &'a mut Texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Float` [INFO] [stderr] --> src/vertex_array.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | Float, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FloatVec4` [INFO] [stderr] --> src/vertex_array.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | FloatVec4, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Points` [INFO] [stderr] --> src/vertex_array.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | Points, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lines` [INFO] [stderr] --> src/vertex_array.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Lines, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Triangles` [INFO] [stderr] --> src/vertex_array.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | Triangles, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `vertex_array` [INFO] [stderr] --> src/vertex_array.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | vertex_array: &'a mut VertexArray, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `vertex_buffer` [INFO] [stderr] --> src/vertex_array.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | vertex_buffer: BoundVertexBuffer<'a>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_elements` [INFO] [stderr] --> src/vertex_array.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / pub fn draw_elements<'b>( [INFO] [stderr] 118 | | &mut self, [INFO] [stderr] 119 | | draw_ty: DrawTy, [INFO] [stderr] 120 | | index_buffer: BoundIndexBuffer<'b>, [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buffer.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn bind<'a>(&'a mut self) -> BoundBuffer<'a, Ty> { [INFO] [stderr] 81 | | BoundBuffer::new(self) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/shader_program.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn activate<'a>(&'a mut self) -> ActivatedShaderProgram<'a> { [INFO] [stderr] 81 | | ActivatedShaderProgram::new(self) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/shader_program.rs:116:76 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn uniform_float_vec2(&mut self, location: UniformLocation, value: &[f32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/texture.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn bind<'a>(&'a mut self, unit_index: u32) -> BoundTexture<'a> { [INFO] [stderr] 66 | | BoundTexture::new(unit_index, self) [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/vertex_array.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | 0 as *const _, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | / match event { [INFO] [stderr] 100 | | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] 101 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 102 | | _ => () [INFO] [stderr] 103 | | }, [INFO] [stderr] 104 | | _ => () [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 99 | if let glutin::Event::WindowEvent{ event, .. } = event { match event { [INFO] [stderr] 100 | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 101 | _ => () [INFO] [stderr] 102 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:100:60 [INFO] [stderr] | [INFO] [stderr] 100 | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 101 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 102 | | _ => () [INFO] [stderr] 103 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let glutin::WindowEvent::Closed = event { running = false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | gl_window.swap_buffers(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.63s [INFO] running `"docker" "inspect" "7c342f2a5e8c4eccc67fc3c48d5b016e0c51477c67e6eeec541ddae2a8cea960"` [INFO] running `"docker" "rm" "-f" "7c342f2a5e8c4eccc67fc3c48d5b016e0c51477c67e6eeec541ddae2a8cea960"` [INFO] [stdout] 7c342f2a5e8c4eccc67fc3c48d5b016e0c51477c67e6eeec541ddae2a8cea960