[INFO] updating cached repository eugeneyche/breakout [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eugeneyche/breakout [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eugeneyche/breakout" "work/ex/clippy-test-run/sources/stable/gh/eugeneyche/breakout"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eugeneyche/breakout'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eugeneyche/breakout" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eugeneyche/breakout"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eugeneyche/breakout'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f751b68db1a77ea0a6dddb5d309e90b7190c0dcb [INFO] sha for GitHub repo eugeneyche/breakout: f751b68db1a77ea0a6dddb5d309e90b7190c0dcb [INFO] validating manifest of eugeneyche/breakout on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eugeneyche/breakout on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eugeneyche/breakout [INFO] finished frobbing eugeneyche/breakout [INFO] frobbed toml for eugeneyche/breakout written to work/ex/clippy-test-run/sources/stable/gh/eugeneyche/breakout/Cargo.toml [INFO] started frobbing eugeneyche/breakout [INFO] finished frobbing eugeneyche/breakout [INFO] frobbed toml for eugeneyche/breakout written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eugeneyche/breakout/Cargo.toml [INFO] crate eugeneyche/breakout has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eugeneyche/breakout against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eugeneyche/breakout:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 566d31e9ff512e45af06ecbaedb26b5a7221b158e57f9d3a8f3cbb5ee8b1490c [INFO] running `"docker" "start" "-a" "566d31e9ff512e45af06ecbaedb26b5a7221b158e57f9d3a8f3cbb5ee8b1490c"` [INFO] [stderr] Checking breakout v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/collision.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let t = a.cross(s) / d; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/collision.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let u = a.cross(r) / d; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/collision.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | let d = b * b - 4. * a * c; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fonts.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | line_height: line_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/collision.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let t = a.cross(s) / d; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/collision.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let u = a.cross(r) / d; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/collision.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | let d = b * b - 4. * a * c; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fonts.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | line_height: line_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/breakout.rs:243:20 [INFO] [stderr] | [INFO] [stderr] 243 | if (key_state == ElementState::Pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/breakout.rs:266:20 [INFO] [stderr] | [INFO] [stderr] 266 | if (key_state == ElementState::Pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graphics.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | return Err(CreateShaderError::Compile(path.into(), info_log.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(CreateShaderError::Compile(path.into(), info_log.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ElementState`, `MouseButton`, `VirtualKeyCode` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | ElementState, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 22 | MouseButton, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] 23 | VirtualKeyCode, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/breakout.rs:243:20 [INFO] [stderr] | [INFO] [stderr] 243 | if (key_state == ElementState::Pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/breakout.rs:266:20 [INFO] [stderr] | [INFO] [stderr] 266 | if (key_state == ElementState::Pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graphics.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | return Err(CreateShaderError::Compile(path.into(), info_log.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(CreateShaderError::Compile(path.into(), info_log.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ElementState`, `MouseButton`, `VirtualKeyCode` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | ElementState, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 22 | MouseButton, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] 23 | VirtualKeyCode, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tr` [INFO] [stderr] --> src/collision.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | if let Some((tl, side, tr)) = solve_line_rect(seg, Rectangle::new( [INFO] [stderr] | ^^ help: consider using `_tr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `button` [INFO] [stderr] --> src/breakout.rs:230:39 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn on_mouse_button(&mut self, button: MouseButton, state: ElementState) { } [INFO] [stderr] | ^^^^^^ help: consider using `_button` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/breakout.rs:230:60 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn on_mouse_button(&mut self, button: MouseButton, state: ElementState) { } [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/breakout.rs:232:39 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn on_mouse_motion(&mut self, x: f32, y: f32) { } [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/breakout.rs:232:47 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn on_mouse_motion(&mut self, x: f32, y: f32) { } [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `w` [INFO] [stderr] --> src/breakout.rs:273:42 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn on_viewport_change(&mut self, w: u32, h: u32) { [INFO] [stderr] | ^ help: consider using `_w` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `h` [INFO] [stderr] --> src/breakout.rs:273:50 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn on_viewport_change(&mut self, w: u32, h: u32) { [INFO] [stderr] | ^ help: consider using `_h` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tr` [INFO] [stderr] --> src/collision.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | if let Some((tl, side, tr)) = solve_line_rect(seg, Rectangle::new( [INFO] [stderr] | ^^ help: consider using `_tr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `button` [INFO] [stderr] --> src/breakout.rs:230:39 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn on_mouse_button(&mut self, button: MouseButton, state: ElementState) { } [INFO] [stderr] | ^^^^^^ help: consider using `_button` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/breakout.rs:230:60 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn on_mouse_button(&mut self, button: MouseButton, state: ElementState) { } [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/breakout.rs:232:39 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn on_mouse_motion(&mut self, x: f32, y: f32) { } [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/breakout.rs:232:47 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn on_mouse_motion(&mut self, x: f32, y: f32) { } [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `w` [INFO] [stderr] --> src/breakout.rs:273:42 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn on_viewport_change(&mut self, w: u32, h: u32) { [INFO] [stderr] | ^ help: consider using `_w` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `h` [INFO] [stderr] --> src/breakout.rs:273:50 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn on_viewport_change(&mut self, w: u32, h: u32) { [INFO] [stderr] | ^ help: consider using `_h` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `check_circle_contains` [INFO] [stderr] --> src/collision.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn check_circle_contains(circle: Circle, p: Vec2) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_line_circle` [INFO] [stderr] --> src/collision.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn solve_line_circle(line: LineSegment, circle: Circle) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `FontMeasure` [INFO] [stderr] --> src/fonts.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | pub struct FontMeasure { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `measure` [INFO] [stderr] --> src/fonts.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn measure(&self, text: &str) -> FontMeasure { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/renderer.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn new(p: Vec2, w: f32, h: f32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw` [INFO] [stderr] --> src/renderer.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | pub fn draw(&mut self, from_x: f32, from_y: f32, to_x: f32, to_y: f32, color: &[f32; 4]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_line` [INFO] [stderr] --> src/renderer.rs:423:5 [INFO] [stderr] | [INFO] [stderr] 423 | pub fn draw_line(&mut self, from: Vec2, to: Vec2, color: Color) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/breakout.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / pub fn step(&mut self, dt: f32) { [INFO] [stderr] 284 | | let mut next_scene = None; [INFO] [stderr] 285 | | if let Scene::Level(ref mut level) = self.state.scene { [INFO] [stderr] 286 | | if level.invalid_block_start == 0 { [INFO] [stderr] ... | [INFO] [stderr] 419 | | } [INFO] [stderr] 420 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: function is never used: `check_circle_contains` [INFO] [stderr] --> src/collision.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn check_circle_contains(circle: Circle, p: Vec2) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/breakout.rs:369:46 [INFO] [stderr] | [INFO] [stderr] 369 | let original_v = ball.v.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `ball.v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_line_circle` [INFO] [stderr] --> src/collision.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn solve_line_circle(line: LineSegment, circle: Circle) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/breakout.rs:388:42 [INFO] [stderr] | [INFO] [stderr] 388 | let original_v = ball.v.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `ball.v` [INFO] [stderr] warning: struct is never constructed: `FontMeasure` [INFO] [stderr] --> src/fonts.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | pub struct FontMeasure { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `measure` [INFO] [stderr] --> src/fonts.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn measure(&self, text: &str) -> FontMeasure { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/renderer.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn new(p: Vec2, w: f32, h: f32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw` [INFO] [stderr] --> src/renderer.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | pub fn draw(&mut self, from_x: f32, from_y: f32, to_x: f32, to_y: f32, color: &[f32; 4]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_line` [INFO] [stderr] --> src/renderer.rs:423:5 [INFO] [stderr] | [INFO] [stderr] 423 | pub fn draw_line(&mut self, from: Vec2, to: Vec2, color: Color) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/breakout.rs:412:16 [INFO] [stderr] | [INFO] [stderr] 412 | if level.active_balls.len() == 0 && !level.is_launching_ball { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `level.active_balls.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/breakout.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / pub fn step(&mut self, dt: f32) { [INFO] [stderr] 284 | | let mut next_scene = None; [INFO] [stderr] 285 | | if let Scene::Level(ref mut level) = self.state.scene { [INFO] [stderr] 286 | | if level.invalid_block_start == 0 { [INFO] [stderr] ... | [INFO] [stderr] 419 | | } [INFO] [stderr] 420 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/breakout.rs:369:46 [INFO] [stderr] | [INFO] [stderr] 369 | let original_v = ball.v.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `ball.v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/breakout.rs:388:42 [INFO] [stderr] | [INFO] [stderr] 388 | let original_v = ball.v.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `ball.v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/breakout.rs:412:16 [INFO] [stderr] | [INFO] [stderr] 412 | if level.active_balls.len() == 0 && !level.is_launching_ball { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `level.active_balls.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/fonts.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | let ref glyph_info = self.glyph_infos[ci as usize]; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------------------------- help: try: `let glyph_info = &self.glyph_infos[ci as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/fonts.rs:94:16 [INFO] [stderr] | [INFO] [stderr] 94 | if !face.load_char(i, ft::face::LoadFlag::RENDER).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `face.load_char(i, ft::face::LoadFlag::RENDER).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/fonts.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | let line_height = face.height() as f32 / 64.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(face.height())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/fonts.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / pub fn get<'a>(&'a self, handle: FontHandle) -> &'a Font { [INFO] [stderr] 174 | | let FontHandle(index) = handle; [INFO] [stderr] 175 | | &self.font_store[index as usize] [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn get_uniform_location(&self, name: &str) -> GLint { unsafe { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/fonts.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | let ref glyph_info = self.glyph_infos[ci as usize]; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------------------------- help: try: `let glyph_info = &self.glyph_infos[ci as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/fonts.rs:94:16 [INFO] [stderr] | [INFO] [stderr] 94 | if !face.load_char(i, ft::face::LoadFlag::RENDER).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `face.load_char(i, ft::face::LoadFlag::RENDER).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/graphics.rs:81:41 [INFO] [stderr] | [INFO] [stderr] 81 | gl::GetUniformLocation(self.id, CString::new(name).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/graphics.rs:81:41 [INFO] [stderr] | [INFO] [stderr] 81 | gl::GetUniformLocation(self.id, CString::new(name).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/fonts.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | let line_height = face.height() as f32 / 64.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(face.height())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/fonts.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / pub fn get<'a>(&'a self, handle: FontHandle) -> &'a Font { [INFO] [stderr] 174 | | let FontHandle(index) = handle; [INFO] [stderr] 175 | | &self.font_store[index as usize] [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn get_uniform_location(&self, name: &str) -> GLint { unsafe { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/graphics.rs:81:41 [INFO] [stderr] | [INFO] [stderr] 81 | gl::GetUniformLocation(self.id, CString::new(name).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/graphics.rs:81:41 [INFO] [stderr] | [INFO] [stderr] 81 | gl::GetUniformLocation(self.id, CString::new(name).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/renderer.rs:159:69 [INFO] [stderr] | [INFO] [stderr] 159 | self.vertices.push(RectVertex { bound: [x, y, w, h], color: color.clone() }); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/renderer.rs:226:74 [INFO] [stderr] | [INFO] [stderr] 226 | self.vertices.push(CircleVertex { center: [x, y], radius, color: color.clone() }); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/renderer.rs:283:76 [INFO] [stderr] | [INFO] [stderr] 283 | self.vertices.push(LineVertex { position: [from_x, from_y], color: color.clone() }); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/renderer.rs:159:69 [INFO] [stderr] | [INFO] [stderr] 159 | self.vertices.push(RectVertex { bound: [x, y, w, h], color: color.clone() }); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/renderer.rs:284:72 [INFO] [stderr] | [INFO] [stderr] 284 | self.vertices.push(LineVertex { position: [to_x, to_y], color: color.clone() }); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/renderer.rs:226:74 [INFO] [stderr] | [INFO] [stderr] 226 | self.vertices.push(CircleVertex { center: [x, y], radius, color: color.clone() }); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/renderer.rs:283:76 [INFO] [stderr] | [INFO] [stderr] 283 | self.vertices.push(LineVertex { position: [from_x, from_y], color: color.clone() }); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/renderer.rs:284:72 [INFO] [stderr] | [INFO] [stderr] 284 | self.vertices.push(LineVertex { position: [to_x, to_y], color: color.clone() }); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/renderer.rs:357:17 [INFO] [stderr] | [INFO] [stderr] 357 | let ref glyph_info = font.glyph_infos[ci as usize]; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------------------------- help: try: `let glyph_info = &font.glyph_infos[ci as usize];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/renderer.rs:357:17 [INFO] [stderr] | [INFO] [stderr] 357 | let ref glyph_info = font.glyph_infos[ci as usize]; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------------------------- help: try: `let glyph_info = &font.glyph_infos[ci as usize];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / match event { [INFO] [stderr] 55 | | Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 56 | | WindowEvent::CloseRequested => is_running = false, [INFO] [stderr] 57 | | WindowEvent::CursorMoved { position, .. } => { [INFO] [stderr] ... | [INFO] [stderr] 72 | | _ => (), [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 55 | WindowEvent::CloseRequested => is_running = false, [INFO] [stderr] 56 | WindowEvent::CursorMoved { position, .. } => { [INFO] [stderr] 57 | let (x, y) = position; [INFO] [stderr] 58 | game.on_mouse_motion(x as _, y as _); [INFO] [stderr] 59 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / match event { [INFO] [stderr] 55 | | Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 56 | | WindowEvent::CloseRequested => is_running = false, [INFO] [stderr] 57 | | WindowEvent::CursorMoved { position, .. } => { [INFO] [stderr] ... | [INFO] [stderr] 72 | | _ => (), [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 55 | WindowEvent::CloseRequested => is_running = false, [INFO] [stderr] 56 | WindowEvent::CursorMoved { position, .. } => { [INFO] [stderr] 57 | let (x, y) = position; [INFO] [stderr] 58 | game.on_mouse_motion(x as _, y as _); [INFO] [stderr] 59 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] error: Could not compile `breakout`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] [INFO] [stderr] error: Could not compile `breakout`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "566d31e9ff512e45af06ecbaedb26b5a7221b158e57f9d3a8f3cbb5ee8b1490c"` [INFO] running `"docker" "rm" "-f" "566d31e9ff512e45af06ecbaedb26b5a7221b158e57f9d3a8f3cbb5ee8b1490c"` [INFO] [stdout] 566d31e9ff512e45af06ecbaedb26b5a7221b158e57f9d3a8f3cbb5ee8b1490c