[INFO] updating cached repository euclio/vim-markdown-composer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/euclio/vim-markdown-composer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/euclio/vim-markdown-composer" "work/ex/clippy-test-run/sources/stable/gh/euclio/vim-markdown-composer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/euclio/vim-markdown-composer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/euclio/vim-markdown-composer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/euclio/vim-markdown-composer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/euclio/vim-markdown-composer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 00c561589aa8116e15b5adbda3c82f9e165e635d [INFO] sha for GitHub repo euclio/vim-markdown-composer: 00c561589aa8116e15b5adbda3c82f9e165e635d [INFO] validating manifest of euclio/vim-markdown-composer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of euclio/vim-markdown-composer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing euclio/vim-markdown-composer [INFO] finished frobbing euclio/vim-markdown-composer [INFO] frobbed toml for euclio/vim-markdown-composer written to work/ex/clippy-test-run/sources/stable/gh/euclio/vim-markdown-composer/Cargo.toml [INFO] started frobbing euclio/vim-markdown-composer [INFO] finished frobbing euclio/vim-markdown-composer [INFO] frobbed toml for euclio/vim-markdown-composer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/euclio/vim-markdown-composer/Cargo.toml [INFO] crate euclio/vim-markdown-composer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting euclio/vim-markdown-composer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/euclio/vim-markdown-composer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d2e99fdd0b4bab23be3bf73ef188300893200f50b427614a12c08f71cc017de [INFO] running `"docker" "start" "-a" "1d2e99fdd0b4bab23be3bf73ef188300893200f50b427614a12c08f71cc017de"` [INFO] [stderr] Checking sequence_trie v0.3.6 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking pulldown-cmark v0.1.2 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking serde_yaml v0.8.7 [INFO] [stderr] Checking chan v0.1.23 [INFO] [stderr] Checking rmp v0.8.7 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking serde-value v0.5.2 [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking log-panics v2.0.0 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking mime_guess v1.8.6 [INFO] [stderr] Checking hyper v0.10.15 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking iron v0.6.0 [INFO] [stderr] Checking websocket v0.20.4 [INFO] [stderr] Checking mount v0.4.0 [INFO] [stderr] Checking handlebars-iron v0.26.2 [INFO] [stderr] Checking staticfile v0.5.0 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking aurelius v0.6.1 [INFO] [stderr] Checking markdown-composer v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / if let &Some(ref browser) = browser { [INFO] [stderr] 96 | | let split_cmd = browser.split_whitespace().collect::>(); [INFO] [stderr] 97 | | let (cmd, args) = split_cmd.split_first().unwrap(); [INFO] [stderr] 98 | | let mut command = Command::new(cmd); [INFO] [stderr] ... | [INFO] [stderr] 102 | | browser::open(&url).unwrap(); [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 95 | if let Some(ref browser) = *browser { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / if let &Some(ref browser) = browser { [INFO] [stderr] 96 | | let split_cmd = browser.split_whitespace().collect::>(); [INFO] [stderr] 97 | | let (cmd, args) = split_cmd.split_first().unwrap(); [INFO] [stderr] 98 | | let mut command = Command::new(cmd); [INFO] [stderr] ... | [INFO] [stderr] 102 | | browser::open(&url).unwrap(); [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 95 | if let Some(ref browser) = *browser { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 52.18s [INFO] running `"docker" "inspect" "1d2e99fdd0b4bab23be3bf73ef188300893200f50b427614a12c08f71cc017de"` [INFO] running `"docker" "rm" "-f" "1d2e99fdd0b4bab23be3bf73ef188300893200f50b427614a12c08f71cc017de"` [INFO] [stdout] 1d2e99fdd0b4bab23be3bf73ef188300893200f50b427614a12c08f71cc017de