[INFO] updating cached repository euclio/nourishbot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/euclio/nourishbot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/euclio/nourishbot" "work/ex/clippy-test-run/sources/stable/gh/euclio/nourishbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/euclio/nourishbot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/euclio/nourishbot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/euclio/nourishbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/euclio/nourishbot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5e305b60109eddab9d4b895a77bb41dd2efec43c [INFO] sha for GitHub repo euclio/nourishbot: 5e305b60109eddab9d4b895a77bb41dd2efec43c [INFO] validating manifest of euclio/nourishbot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of euclio/nourishbot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing euclio/nourishbot [INFO] finished frobbing euclio/nourishbot [INFO] frobbed toml for euclio/nourishbot written to work/ex/clippy-test-run/sources/stable/gh/euclio/nourishbot/Cargo.toml [INFO] started frobbing euclio/nourishbot [INFO] finished frobbing euclio/nourishbot [INFO] frobbed toml for euclio/nourishbot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/euclio/nourishbot/Cargo.toml [INFO] crate euclio/nourishbot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting euclio/nourishbot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/euclio/nourishbot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 619333f13426a08bdc5aeb81652321c2b6cdc2d02e9b31bf16f02eae0920d7dd [INFO] running `"docker" "start" "-a" "619333f13426a08bdc5aeb81652321c2b6cdc2d02e9b31bf16f02eae0920d7dd"` [INFO] [stderr] Checking precomputed-hash v0.1.0 [INFO] [stderr] Checking serde v1.0.12 [INFO] [stderr] Compiling libz-sys v1.0.16 [INFO] [stderr] Compiling curl-sys v0.3.14 [INFO] [stderr] Checking socket2 v0.2.2 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking openssl-sys v0.9.17 [INFO] [stderr] Compiling serde_derive_internals v0.15.1 [INFO] [stderr] Compiling derive-error-chain v0.10.1 [INFO] [stderr] Checking Inflector v0.10.1 [INFO] [stderr] Compiling string_cache_codegen v0.4.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking openssl v0.9.17 [INFO] [stderr] Compiling serde_derive v1.0.12 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking dotenv v0.10.1 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking serde_json v1.0.3 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking html5ever v0.18.0 [INFO] [stderr] Checking select v0.4.2 [INFO] [stderr] Checking curl v0.4.8 [INFO] [stderr] Checking slack-hook v0.5.0 [INFO] [stderr] Checking nourish-bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 156 | | if let Some(ref heading) = current_heading { [INFO] [stderr] 157 | | // Skip breakfast [INFO] [stderr] 158 | | if heading == "Breakfast Special" { [INFO] [stderr] ... | [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 155 | } else if let Some(ref heading) = current_heading { [INFO] [stderr] 156 | // Skip breakfast [INFO] [stderr] 157 | if heading == "Breakfast Special" { [INFO] [stderr] 158 | continue; [INFO] [stderr] 159 | } [INFO] [stderr] 160 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 156 | | if let Some(ref heading) = current_heading { [INFO] [stderr] 157 | | // Skip breakfast [INFO] [stderr] 158 | | if heading == "Breakfast Special" { [INFO] [stderr] ... | [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 155 | } else if let Some(ref heading) = current_heading { [INFO] [stderr] 156 | // Skip breakfast [INFO] [stderr] 157 | if heading == "Breakfast Special" { [INFO] [stderr] 158 | continue; [INFO] [stderr] 159 | } [INFO] [stderr] 160 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn retrieve_menu(date: &NaiveDate) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:130:27 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn url_for_date(date: &NaiveDate) -> Url { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:41 [INFO] [stderr] | [INFO] [stderr] 132 | let monday = *date - Duration::days(date.weekday().num_days_from_monday() as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date.weekday().num_days_from_monday())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:281:49 [INFO] [stderr] | [INFO] [stderr] 281 | assert!(PRICE_RE.is_match(pattern), pattern.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 281 | assert!(PRICE_RE.is_match(pattern), &(*pattern).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 281 | assert!(PRICE_RE.is_match(pattern), &str::clone(pattern)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `nourish-bot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn retrieve_menu(date: &NaiveDate) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:130:27 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn url_for_date(date: &NaiveDate) -> Url { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:41 [INFO] [stderr] | [INFO] [stderr] 132 | let monday = *date - Duration::days(date.weekday().num_days_from_monday() as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date.weekday().num_days_from_monday())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "619333f13426a08bdc5aeb81652321c2b6cdc2d02e9b31bf16f02eae0920d7dd"` [INFO] running `"docker" "rm" "-f" "619333f13426a08bdc5aeb81652321c2b6cdc2d02e9b31bf16f02eae0920d7dd"` [INFO] [stdout] 619333f13426a08bdc5aeb81652321c2b6cdc2d02e9b31bf16f02eae0920d7dd