[INFO] updating cached repository etrexel/advent_of_code_2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/etrexel/advent_of_code_2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/etrexel/advent_of_code_2018" "work/ex/clippy-test-run/sources/stable/gh/etrexel/advent_of_code_2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/etrexel/advent_of_code_2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/etrexel/advent_of_code_2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/etrexel/advent_of_code_2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/etrexel/advent_of_code_2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 4180844648c9194af3d61f4967a54e8aaa721eda
[INFO] sha for GitHub repo etrexel/advent_of_code_2018: 4180844648c9194af3d61f4967a54e8aaa721eda
[INFO] validating manifest of etrexel/advent_of_code_2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of etrexel/advent_of_code_2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing etrexel/advent_of_code_2018
[INFO] finished frobbing etrexel/advent_of_code_2018
[INFO] frobbed toml for etrexel/advent_of_code_2018 written to work/ex/clippy-test-run/sources/stable/gh/etrexel/advent_of_code_2018/Cargo.toml
[INFO] started frobbing etrexel/advent_of_code_2018
[INFO] finished frobbing etrexel/advent_of_code_2018
[INFO] frobbed toml for etrexel/advent_of_code_2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/etrexel/advent_of_code_2018/Cargo.toml
[INFO] crate etrexel/advent_of_code_2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting etrexel/advent_of_code_2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/etrexel/advent_of_code_2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 97e45851a7a19db3f32e40c401548f661750dcd61d12f7e00016d393e0f44e78
[INFO] running `"docker" "start" "-a" "97e45851a7a19db3f32e40c401548f661750dcd61d12f7e00016d393e0f44e78"`
[INFO] [stderr]     Checking advent_of_code_2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: field is never used: `id`
[INFO] [stderr]  --> src/day_three.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     id: i32,
[INFO] [stderr]   |     ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `id`
[INFO] [stderr]  --> src/day_three.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     id: i32,
[INFO] [stderr]   |     ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/day_two.rs:20:66
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let split_strings: Vec<String> = split_input.into_iter().map(|word| String::from(word)).collect();
[INFO] [stderr]    |                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day_two.rs:60:20
[INFO] [stderr]    |
[INFO] [stderr] 60 | fn distance(first: &String, second: &String) -> i32 {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day_two.rs:60:37
[INFO] [stderr]    |
[INFO] [stderr] 60 | fn distance(first: &String, second: &String) -> i32 {
[INFO] [stderr]    |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day_two.rs:73:26
[INFO] [stderr]    |
[INFO] [stderr] 73 | fn common_letters(first: &String, second: &String) -> String {
[INFO] [stderr]    |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day_two.rs:73:43
[INFO] [stderr]    |
[INFO] [stderr] 73 | fn common_letters(first: &String, second: &String) -> String {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `quilt`.
[INFO] [stderr]   --> src/day_three.rs:58:14
[INFO] [stderr]    |
[INFO] [stderr] 58 |     for i in x_start..x_end {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 58 |     for <item> in quilt.iter_mut().take(x_end).skip(x_start) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/day_two.rs:20:66
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let split_strings: Vec<String> = split_input.into_iter().map(|word| String::from(word)).collect();
[INFO] [stderr]    |                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day_two.rs:60:20
[INFO] [stderr]    |
[INFO] [stderr] 60 | fn distance(first: &String, second: &String) -> i32 {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day_two.rs:60:37
[INFO] [stderr]    |
[INFO] [stderr] 60 | fn distance(first: &String, second: &String) -> i32 {
[INFO] [stderr]    |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day_two.rs:73:26
[INFO] [stderr]    |
[INFO] [stderr] 73 | fn common_letters(first: &String, second: &String) -> String {
[INFO] [stderr]    |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day_two.rs:73:43
[INFO] [stderr]    |
[INFO] [stderr] 73 | fn common_letters(first: &String, second: &String) -> String {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `quilt`.
[INFO] [stderr]   --> src/day_three.rs:58:14
[INFO] [stderr]    |
[INFO] [stderr] 58 |     for i in x_start..x_end {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 58 |     for <item> in quilt.iter_mut().take(x_end).skip(x_start) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.99s
[INFO] running `"docker" "inspect" "97e45851a7a19db3f32e40c401548f661750dcd61d12f7e00016d393e0f44e78"`
[INFO] running `"docker" "rm" "-f" "97e45851a7a19db3f32e40c401548f661750dcd61d12f7e00016d393e0f44e78"`
[INFO] [stdout] 97e45851a7a19db3f32e40c401548f661750dcd61d12f7e00016d393e0f44e78