[INFO] updating cached repository ethanhs/cce [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ethanhs/cce [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ethanhs/cce" "work/ex/clippy-test-run/sources/stable/gh/ethanhs/cce"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ethanhs/cce'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ethanhs/cce" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ethanhs/cce"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ethanhs/cce'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dd8a7045586fd08d2866a8855a51d0c7c85c6c77 [INFO] sha for GitHub repo ethanhs/cce: dd8a7045586fd08d2866a8855a51d0c7c85c6c77 [INFO] validating manifest of ethanhs/cce on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ethanhs/cce on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ethanhs/cce [INFO] finished frobbing ethanhs/cce [INFO] frobbed toml for ethanhs/cce written to work/ex/clippy-test-run/sources/stable/gh/ethanhs/cce/Cargo.toml [INFO] started frobbing ethanhs/cce [INFO] finished frobbing ethanhs/cce [INFO] frobbed toml for ethanhs/cce written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ethanhs/cce/Cargo.toml [INFO] crate ethanhs/cce has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ethanhs/cce against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ethanhs/cce:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1a20295c88c2a18427a768072f63c4c690d0fa6b55c30f610763677d98100e9d [INFO] running `"docker" "start" "-a" "1a20295c88c2a18427a768072f63c4c690d0fa6b55c30f610763677d98100e9d"` [INFO] [stderr] Checking urlparse v0.7.3 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking cce v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/requests.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/requests.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tempedit.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tempedit.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return src; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tempedit.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tempedit.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return src; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/tempedit.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | let home = env::home_dir().expect("Fatal: unable to find home directory"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/tempedit.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | let home = env::home_dir().expect("Fatal: unable to find home directory"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tempedit.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | File::create(&godboltc).expect(&format!( [INFO] [stderr] | _________________________________^ [INFO] [stderr] 26 | | "Could not create file {}", [INFO] [stderr] 27 | | godboltc.to_str().unwrap() [INFO] [stderr] 28 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Could not create file {}", godboltc.to_str().unwrap()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tempedit.rs:50:34 [INFO] [stderr] | [INFO] [stderr] 50 | let mut f = File::open(path).expect(format!("could not find file {}", path).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not find file {}", path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/url.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn get_url(src: &String, host: &str, compiler: &str, args: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/url.rs:3:64 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn get_url(src: &String, host: &str, compiler: &str, args: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tempedit.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | File::create(&godboltc).expect(&format!( [INFO] [stderr] | _________________________________^ [INFO] [stderr] 26 | | "Could not create file {}", [INFO] [stderr] 27 | | godboltc.to_str().unwrap() [INFO] [stderr] 28 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Could not create file {}", godboltc.to_str().unwrap()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tempedit.rs:50:34 [INFO] [stderr] | [INFO] [stderr] 50 | let mut f = File::open(path).expect(format!("could not find file {}", path).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not find file {}", path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/url.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn get_url(src: &String, host: &str, compiler: &str, args: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/url.rs:3:64 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn get_url(src: &String, host: &str, compiler: &str, args: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.50s [INFO] running `"docker" "inspect" "1a20295c88c2a18427a768072f63c4c690d0fa6b55c30f610763677d98100e9d"` [INFO] running `"docker" "rm" "-f" "1a20295c88c2a18427a768072f63c4c690d0fa6b55c30f610763677d98100e9d"` [INFO] [stdout] 1a20295c88c2a18427a768072f63c4c690d0fa6b55c30f610763677d98100e9d