[INFO] updating cached repository estelendur/pascal [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/estelendur/pascal [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/estelendur/pascal" "work/ex/clippy-test-run/sources/stable/gh/estelendur/pascal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/estelendur/pascal'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/estelendur/pascal" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/estelendur/pascal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/estelendur/pascal'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7a3dca433ef3167f775b66fb0ce43cc4c6545237 [INFO] sha for GitHub repo estelendur/pascal: 7a3dca433ef3167f775b66fb0ce43cc4c6545237 [INFO] validating manifest of estelendur/pascal on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of estelendur/pascal on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing estelendur/pascal [INFO] finished frobbing estelendur/pascal [INFO] frobbed toml for estelendur/pascal written to work/ex/clippy-test-run/sources/stable/gh/estelendur/pascal/Cargo.toml [INFO] started frobbing estelendur/pascal [INFO] finished frobbing estelendur/pascal [INFO] frobbed toml for estelendur/pascal written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/estelendur/pascal/Cargo.toml [INFO] crate estelendur/pascal has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting estelendur/pascal against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/estelendur/pascal:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] db1887f0ea542618ea61209da7c874aed567045034032d46c281d51ea729a2bd [INFO] running `"docker" "start" "-a" "db1887f0ea542618ea61209da7c874aed567045034032d46c281d51ea729a2bd"` [INFO] [stderr] Checking pascal v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:40:38 [INFO] [stderr] | [INFO] [stderr] 40 | fn boring_print(vec: &Vec>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:47:38 [INFO] [stderr] | [INFO] [stderr] 47 | fn pretty_print(vec: &Vec>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:27:26 [INFO] [stderr] | [INFO] [stderr] 27 | fn pascal_expansion(vec: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | while let Some(next) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for next in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | fn boring_print(vec: &Vec>) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | while let Some(next) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for next in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | fn pretty_print(vec: &Vec>) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | while let Some(next) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for next in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:40:38 [INFO] [stderr] | [INFO] [stderr] 40 | fn boring_print(vec: &Vec>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:47:38 [INFO] [stderr] | [INFO] [stderr] 47 | fn pretty_print(vec: &Vec>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:27:26 [INFO] [stderr] | [INFO] [stderr] 27 | fn pascal_expansion(vec: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | while let Some(next) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for next in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | fn boring_print(vec: &Vec>) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | while let Some(next) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for next in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | fn pretty_print(vec: &Vec>) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | while let Some(next) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for next in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "db1887f0ea542618ea61209da7c874aed567045034032d46c281d51ea729a2bd"` [INFO] running `"docker" "rm" "-f" "db1887f0ea542618ea61209da7c874aed567045034032d46c281d51ea729a2bd"` [INFO] [stdout] db1887f0ea542618ea61209da7c874aed567045034032d46c281d51ea729a2bd