[INFO] updating cached repository esrlabs/centralgithook [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/esrlabs/centralgithook [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/esrlabs/centralgithook" "work/ex/clippy-test-run/sources/stable/gh/esrlabs/centralgithook"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/esrlabs/centralgithook'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/esrlabs/centralgithook" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esrlabs/centralgithook"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esrlabs/centralgithook'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7e53ca5fdb31f7507e3e2f377bbd82c8dc31e059 [INFO] sha for GitHub repo esrlabs/centralgithook: 7e53ca5fdb31f7507e3e2f377bbd82c8dc31e059 [INFO] validating manifest of esrlabs/centralgithook on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of esrlabs/centralgithook on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing esrlabs/centralgithook [INFO] finished frobbing esrlabs/centralgithook [INFO] frobbed toml for esrlabs/centralgithook written to work/ex/clippy-test-run/sources/stable/gh/esrlabs/centralgithook/Cargo.toml [INFO] started frobbing esrlabs/centralgithook [INFO] finished frobbing esrlabs/centralgithook [INFO] frobbed toml for esrlabs/centralgithook written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esrlabs/centralgithook/Cargo.toml [INFO] crate esrlabs/centralgithook has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting esrlabs/centralgithook against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/esrlabs/centralgithook:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 92a6b6b68b23998c0ea6933f9142f8c1313134e5dbd3584aaf10441218a22e8e [INFO] running `"docker" "start" "-a" "92a6b6b68b23998c0ea6933f9142f8c1313134e5dbd3584aaf10441218a22e8e"` [INFO] [stderr] Compiling libc v0.2.37 [INFO] [stderr] Compiling cmake v0.1.29 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Compiling brotli-sys v0.2.1 [INFO] [stderr] Checking base64 v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.3.0 [INFO] [stderr] Checking fern v0.5.4 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking buf_redux v0.6.3 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.7.0 [INFO] [stderr] Checking uuid v0.1.18 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Compiling num_cpus v1.8.0 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Checking tempdir v0.3.6 [INFO] [stderr] Checking url v0.2.38 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking gzip-header v0.1.2 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Compiling mime_guess v1.8.4 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking tiny_http v0.5.9 [INFO] [stderr] Checking brotli2 v0.2.2 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking rouille v2.1.0 [INFO] [stderr] Checking git2 v0.7.0 [INFO] [stderr] Checking grib v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scratch.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | const TMP_NAME: &'static str = "refs/centralgit/tmp_fd2db5f8_bac2_4a1e_9487_4ac3414788aa"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | return UnapplyView::Done(current); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UnapplyView::Done(current)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | return obj; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `obj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | return apply_view_cached(&repo, view, newrev, &mut ViewCache::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `apply_view_cached(&repo, view, newrev, &mut ViewCache::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | return view_cache.get(&newrev).map(|&id| id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `view_cache.get(&newrev).map(|&id| id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch.rs:332:5 [INFO] [stderr] | [INFO] [stderr] 332 | return join_commit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `join_commit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/shell.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return (stdout, stderr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(stdout, stderr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/base_repo.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/treeops.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return sd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `sd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/treeops.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return full_tree_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `full_tree_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/treeops.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | builder.insert(child, subtree, 0o0040000) // GIT_FILEMODE_TREE [INFO] [stderr] | ^^^^^^^^^ help: consider: `0o0_040_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/treeops.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / return repo.find_tree(replace_child(&repo, path, subtree.id(), full_tree)) [INFO] [stderr] 43 | | .expect("replace_child: can't find new tree") [INFO] [stderr] 44 | | .id(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | repo.find_tree(replace_child(&repo, path, subtree.id(), full_tree)) [INFO] [stderr] 43 | .expect("replace_child: can't find new tree") [INFO] [stderr] 44 | .id() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/treeops.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return replace_subtree(&repo, path, &tree, full_tree); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `replace_subtree(&repo, path, &tree, full_tree)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/virtual_repo.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/virtual_repo.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/virtual_repo.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/run_proxy.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scratch.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | const TMP_NAME: &'static str = "refs/centralgit/tmp_fd2db5f8_bac2_4a1e_9487_4ac3414788aa"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | return UnapplyView::Done(current); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UnapplyView::Done(current)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | return obj; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `obj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | return apply_view_cached(&repo, view, newrev, &mut ViewCache::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `apply_view_cached(&repo, view, newrev, &mut ViewCache::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | return view_cache.get(&newrev).map(|&id| id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `view_cache.get(&newrev).map(|&id| id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch.rs:332:5 [INFO] [stderr] | [INFO] [stderr] 332 | return join_commit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `join_commit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/shell.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return (stdout, stderr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(stdout, stderr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/base_repo.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/treeops.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return sd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `sd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/treeops.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return full_tree_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `full_tree_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/treeops.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | builder.insert(child, subtree, 0o0040000) // GIT_FILEMODE_TREE [INFO] [stderr] | ^^^^^^^^^ help: consider: `0o0_040_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/treeops.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / return repo.find_tree(replace_child(&repo, path, subtree.id(), full_tree)) [INFO] [stderr] 43 | | .expect("replace_child: can't find new tree") [INFO] [stderr] 44 | | .id(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | repo.find_tree(replace_child(&repo, path, subtree.id(), full_tree)) [INFO] [stderr] 43 | .expect("replace_child: can't find new tree") [INFO] [stderr] 44 | .id() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/treeops.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return replace_subtree(&repo, path, &tree, full_tree); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `replace_subtree(&repo, path, &tree, full_tree)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/virtual_repo.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/virtual_repo.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/virtual_repo.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/run_proxy.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path_without_prefix` [INFO] [stderr] --> src/run_proxy.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | let path_without_prefix = if prefix != "" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_path_without_prefix` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path_without_prefix` [INFO] [stderr] --> src/run_proxy.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | let path_without_prefix = if prefix != "" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_path_without_prefix` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scratch.rs:43:8 [INFO] [stderr] | [INFO] [stderr] 43 | if parents.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/scratch.rs:81:14 [INFO] [stderr] | [INFO] [stderr] 81 | .expect(&format!("walk: invalid range: {}", range));; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("walk: invalid range: {}", range))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/scratch.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | &vec![&parent], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[&parent]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scratch.rs:43:8 [INFO] [stderr] | [INFO] [stderr] 43 | if parents.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/scratch.rs:155:10 [INFO] [stderr] | [INFO] [stderr] 155 | .or_insert(ViewCache::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(ViewCache::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/scratch.rs:81:14 [INFO] [stderr] | [INFO] [stderr] 81 | .expect(&format!("walk: invalid range: {}", range));; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("walk: invalid range: {}", range))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scratch.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | return Some(id.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/scratch.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | &vec![&parent], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[&parent]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/scratch.rs:256:12 [INFO] [stderr] | [INFO] [stderr] 256 | return view_cache.get(&newrev).map(|&id| id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `view_cache.get(&newrev).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/scratch.rs:155:10 [INFO] [stderr] | [INFO] [stderr] 155 | .or_insert(ViewCache::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(ViewCache::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scratch.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | return Some(id.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/scratch.rs:304:31 [INFO] [stderr] | [INFO] [stderr] 304 | let parent = *map.get(&parent).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&parent]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/scratch.rs:256:12 [INFO] [stderr] | [INFO] [stderr] 256 | return view_cache.get(&newrev).map(|&id| id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `view_cache.get(&newrev).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/scratch.rs:304:31 [INFO] [stderr] | [INFO] [stderr] 304 | let parent = *map.get(&parent).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&parent]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/base_repo.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | fs::create_dir_all(path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/base_repo.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / match git2::Repository::open(path) { [INFO] [stderr] 73 | | Ok(_) => { [INFO] [stderr] 74 | | println!("repo exists"); [INFO] [stderr] 75 | | return; [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | Err(_) => {} [INFO] [stderr] 78 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 72 | if let Ok(_) = git2::Repository::open(path) { [INFO] [stderr] 73 | println!("repo exists"); [INFO] [stderr] 74 | return; [INFO] [stderr] 75 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/base_repo.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / match git2::Repository::init_bare(path) { [INFO] [stderr] 81 | | Ok(_) => { [INFO] [stderr] 82 | | println!("repo initialized"); [INFO] [stderr] 83 | | return; [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | Err(_) => {} [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | if let Ok(_) = git2::Repository::init_bare(path) { [INFO] [stderr] 81 | println!("repo initialized"); [INFO] [stderr] 82 | return; [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/treeops.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | if !name.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/base_repo.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | fs::create_dir_all(path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/base_repo.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / match git2::Repository::open(path) { [INFO] [stderr] 73 | | Ok(_) => { [INFO] [stderr] 74 | | println!("repo exists"); [INFO] [stderr] 75 | | return; [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | Err(_) => {} [INFO] [stderr] 78 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 72 | if let Ok(_) = git2::Repository::open(path) { [INFO] [stderr] 73 | println!("repo exists"); [INFO] [stderr] 74 | return; [INFO] [stderr] 75 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/base_repo.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / match git2::Repository::init_bare(path) { [INFO] [stderr] 81 | | Ok(_) => { [INFO] [stderr] 82 | | println!("repo initialized"); [INFO] [stderr] 83 | | return; [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | Err(_) => {} [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | if let Ok(_) = git2::Repository::init_bare(path) { [INFO] [stderr] 81 | println!("repo initialized"); [INFO] [stderr] 82 | return; [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/treeops.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | if !name.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/virtual_repo.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | .expect(&format!("could not read {} name", name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not read {} name", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/virtual_repo.rs:60:10 [INFO] [stderr] | [INFO] [stderr] 60 | .expect(&format!("could not open {} name file", name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not open {} name file", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/virtual_repo.rs:79:29 [INFO] [stderr] | [INFO] [stderr] 79 | if viewname.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/virtual_repo.rs:98:14 [INFO] [stderr] | [INFO] [stderr] 98 | .expect(&format!("no ref: {} ({}) in {:?}", &refname, &without_refs_for, scratch.path())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("no ref: {} ({}) in {:?}", &refname))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/virtual_repo.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | .expect(&format!("could not read {} name", name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not read {} name", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/virtual_repo.rs:60:10 [INFO] [stderr] | [INFO] [stderr] 60 | .expect(&format!("could not open {} name file", name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not open {} name file", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/virtual_repo.rs:79:29 [INFO] [stderr] | [INFO] [stderr] 79 | if viewname.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/virtual_repo.rs:98:14 [INFO] [stderr] | [INFO] [stderr] 98 | .expect(&format!("no ref: {} ({}) in {:?}", &refname, &without_refs_for, scratch.path())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("no ref: {} ({}) in {:?}", &refname))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cgi.rs:79:58 [INFO] [stderr] | [INFO] [stderr] 79 | u16::from_str(l[1].split(" ").next().unwrap()).unwrap(), [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/run_proxy.rs:58:68 [INFO] [stderr] | [INFO] [stderr] 58 | let br_path = self.base_path.join(prefix.trim_left_matches("/")); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cgi.rs:79:58 [INFO] [stderr] | [INFO] [stderr] 79 | u16::from_str(l[1].split(" ").next().unwrap()).unwrap(), [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/run_proxy.rs:125:62 [INFO] [stderr] | [INFO] [stderr] 125 | })) => (username.to_owned(), password.to_owned().unwrap_or("".to_owned()).to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/run_proxy.rs:58:68 [INFO] [stderr] | [INFO] [stderr] 58 | let br_path = self.base_path.join(prefix.trim_left_matches("/")); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/run_proxy.rs:125:62 [INFO] [stderr] | [INFO] [stderr] 125 | })) => (username.to_owned(), password.to_owned().unwrap_or("".to_owned()).to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/helpers.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | repo: repo, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/helpers.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | td: td, [INFO] [stderr] | ^^^^^^ help: replace it with: `td` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/helpers.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | repo: repo, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/helpers.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | td: td, [INFO] [stderr] | ^^^^^^ help: replace it with: `td` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/helpers.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return tr; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `tr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `TestRepo` [INFO] [stderr] --> tests/helpers.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Self [INFO] [stderr] 36 | | { [INFO] [stderr] 37 | | let td = TempDir::new("cgh_test").expect("folder cgh_test should be created"); [INFO] [stderr] 38 | | let repo = git2::Repository::init(td.path()).expect("init should succeed"); [INFO] [stderr] ... | [INFO] [stderr] 48 | | return tr; [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | impl Default for TestRepo { [INFO] [stderr] 34 | fn default() -> Self { [INFO] [stderr] 35 | Self::new() [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> tests/helpers.rs:113:62 [INFO] [stderr] | [INFO] [stderr] 113 | })) => (username.to_owned(), password.to_owned().unwrap_or("".to_owned()).to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/helpers.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return tr; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `tr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/scratch.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / return Some( [INFO] [stderr] 78 | | repo.repo [INFO] [stderr] 79 | | .revparse_single("HEAD") [INFO] [stderr] 80 | | .expect("can't find rewritten branch") [INFO] [stderr] 81 | | .id(), [INFO] [stderr] 82 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 77 | Some( [INFO] [stderr] 78 | repo.repo [INFO] [stderr] 79 | .revparse_single("HEAD") [INFO] [stderr] 80 | .expect("can't find rewritten branch") [INFO] [stderr] 81 | .id(), [INFO] [stderr] 82 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/scratch.rs:332:5 [INFO] [stderr] | [INFO] [stderr] 332 | return o; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `o` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> tests/scratch.rs:583:5 [INFO] [stderr] | [INFO] [stderr] 583 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ServeTestGit` [INFO] [stderr] --> tests/helpers.rs:87:1 [INFO] [stderr] | [INFO] [stderr] 87 | pub struct ServeTestGit [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run_test_server` [INFO] [stderr] --> tests/helpers.rs:152:1 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn run_test_server(repo_path: &Path, port: u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> tests/scratch.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> tests/helpers.rs:113:62 [INFO] [stderr] | [INFO] [stderr] 113 | })) => (username.to_owned(), password.to_owned().unwrap_or("".to_owned()).to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(vec![format!("bla")], sorted(subdirs)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"bla".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | format!("a"), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"a".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | format!("a/b"), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"a/b".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | format!("a/b/c"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"a/b/c".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | format!("a/b/c/d"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"a/b/c/d".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | format!("bla"), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"bla".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | format!("a"), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"a".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | format!("a/b"), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"a/b".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | format!("a/b/c"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"a/b/c".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | format!("a/b/c/d"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"a/b/c/d".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | format!("bla"), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"bla".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/scratch.rs:316:27 [INFO] [stderr] | [INFO] [stderr] 316 | let spl = l.split("@"); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:570:21 [INFO] [stderr] | [INFO] [stderr] 570 | assert_eq!(vec![format!("foo"), format!("x")], sorted(subdirs)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"foo".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:570:37 [INFO] [stderr] | [INFO] [stderr] 570 | assert_eq!(vec![format!("foo"), format!("x")], sorted(subdirs)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"x".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:577:21 [INFO] [stderr] | [INFO] [stderr] 577 | assert_eq!(vec![format!("foo"), format!("foo/bla"), format!("x")], sorted(subdirs)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"foo".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:577:37 [INFO] [stderr] | [INFO] [stderr] 577 | assert_eq!(vec![format!("foo"), format!("foo/bla"), format!("x")], sorted(subdirs)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"foo/bla".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/scratch.rs:577:57 [INFO] [stderr] | [INFO] [stderr] 577 | assert_eq!(vec![format!("foo"), format!("foo/bla"), format!("x")], sorted(subdirs)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"x".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `grib`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "92a6b6b68b23998c0ea6933f9142f8c1313134e5dbd3584aaf10441218a22e8e"` [INFO] running `"docker" "rm" "-f" "92a6b6b68b23998c0ea6933f9142f8c1313134e5dbd3584aaf10441218a22e8e"` [INFO] [stdout] 92a6b6b68b23998c0ea6933f9142f8c1313134e5dbd3584aaf10441218a22e8e