[INFO] updating cached repository esmevane/notectl
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/esmevane/notectl
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/esmevane/notectl" "work/ex/clippy-test-run/sources/stable/gh/esmevane/notectl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/esmevane/notectl'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/esmevane/notectl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esmevane/notectl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esmevane/notectl'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3ee4e43a32d8dc1ed8957c351265df5fccbbdab0
[INFO] sha for GitHub repo esmevane/notectl: 3ee4e43a32d8dc1ed8957c351265df5fccbbdab0
[INFO] validating manifest of esmevane/notectl on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of esmevane/notectl on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing esmevane/notectl
[INFO] finished frobbing esmevane/notectl
[INFO] frobbed toml for esmevane/notectl written to work/ex/clippy-test-run/sources/stable/gh/esmevane/notectl/Cargo.toml
[INFO] started frobbing esmevane/notectl
[INFO] finished frobbing esmevane/notectl
[INFO] frobbed toml for esmevane/notectl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esmevane/notectl/Cargo.toml
[INFO] crate esmevane/notectl has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting esmevane/notectl against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/esmevane/notectl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5075df7fe945a247fe7beadd35ef010333834eb066a50086ab1fbb67eb664067
[INFO] running `"docker" "start" "-a" "5075df7fe945a247fe7beadd35ef010333834eb066a50086ab1fbb67eb664067"`
[INFO] [stderr]    Compiling brotli-sys v0.3.2
[INFO] [stderr]    Compiling num_cpus v1.8.0
[INFO] [stderr]     Checking hostname v0.1.4
[INFO] [stderr]     Checking daemonize v0.2.3
[INFO] [stderr]    Compiling crossbeam-epoch v0.3.0
[INFO] [stderr]     Checking parking_lot_core v0.2.13
[INFO] [stderr]     Checking miniz-sys v0.1.10
[INFO] [stderr]    Compiling actix_derive v0.2.0
[INFO] [stderr]     Checking http v0.1.5
[INFO] [stderr]     Checking uuid v0.5.1
[INFO] [stderr]    Compiling backtrace v0.3.5
[INFO] [stderr]     Checking backtrace v0.2.3
[INFO] [stderr]     Checking flate2 v1.0.1
[INFO] [stderr]     Checking resolv-conf v0.6.0
[INFO] [stderr]     Checking parking_lot v0.4.8
[INFO] [stderr]    Compiling crossbeam-deque v0.2.0
[INFO] [stderr]     Checking mio-uds v0.6.4
[INFO] [stderr]    Compiling phf_generator v0.7.21
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]     Checking error-chain v0.1.12
[INFO] [stderr]    Compiling error-chain v0.11.0
[INFO] [stderr]    Compiling phf_codegen v0.7.21
[INFO] [stderr]     Checking tokio-signal v0.1.4
[INFO] [stderr]    Compiling rayon-core v1.4.0
[INFO] [stderr]     Checking crossbeam-channel v0.1.2
[INFO] [stderr]     Checking trust-dns-proto v0.3.1
[INFO] [stderr]    Compiling mime_guess v1.8.4
[INFO] [stderr]    Compiling cargo_metadata v0.3.3
[INFO] [stderr]    Compiling rayon v0.8.2
[INFO] [stderr]     Checking h2 v0.1.0
[INFO] [stderr]    Compiling skeptic v0.13.2
[INFO] [stderr]    Compiling ring v0.12.1
[INFO] [stderr]     Checking trust-dns-resolver v0.8.1
[INFO] [stderr]     Checking brotli2 v0.3.2
[INFO] [stderr]    Compiling actix v0.5.0
[INFO] [stderr]    Compiling actix-web v0.4.1
[INFO] [stderr]     Checking cookie v0.10.1
[INFO] [stderr]     Checking notectl v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/operation/mod.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/operation/mod.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             about: about,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `about`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/operation/mod.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             execute: execute,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `execute`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/service/mod.rs:24:19
[INFO] [stderr]    |
[INFO] [stderr] 24 |         Service { pidfile: pidfile }
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^ help: replace it with: `pidfile`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/operation/mod.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/operation/mod.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             about: about,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `about`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/operation/mod.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             execute: execute,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `execute`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/service/mod.rs:24:19
[INFO] [stderr]    |
[INFO] [stderr] 24 |         Service { pidfile: pidfile }
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^ help: replace it with: `pidfile`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/api/content_types.rs:1:18
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const JSON: &'static str = "application/json";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/service/mod.rs:18:29
[INFO] [stderr]    |
[INFO] [stderr] 18 |         let dir = given_dir.unwrap_or(PathBuf::from("/tmp"));
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("/tmp"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/service/mod.rs:19:31
[INFO] [stderr]    |
[INFO] [stderr] 19 |         let name = given_name.unwrap_or("notectl".to_string());
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "notectl".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/api/content_types.rs:1:18
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const JSON: &'static str = "application/json";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/service/mod.rs:18:29
[INFO] [stderr]    |
[INFO] [stderr] 18 |         let dir = given_dir.unwrap_or(PathBuf::from("/tmp"));
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("/tmp"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/service/mod.rs:19:31
[INFO] [stderr]    |
[INFO] [stderr] 19 |         let name = given_name.unwrap_or("notectl".to_string());
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "notectl".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 13s
[INFO] running `"docker" "inspect" "5075df7fe945a247fe7beadd35ef010333834eb066a50086ab1fbb67eb664067"`
[INFO] running `"docker" "rm" "-f" "5075df7fe945a247fe7beadd35ef010333834eb066a50086ab1fbb67eb664067"`
[INFO] [stdout] 5075df7fe945a247fe7beadd35ef010333834eb066a50086ab1fbb67eb664067