[INFO] updating cached repository esell/doddns-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/esell/doddns-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/esell/doddns-rust" "work/ex/clippy-test-run/sources/stable/gh/esell/doddns-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/esell/doddns-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/esell/doddns-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esell/doddns-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esell/doddns-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b881f9332159f4ebf6d14079d99272d4bd0ac683 [INFO] sha for GitHub repo esell/doddns-rust: b881f9332159f4ebf6d14079d99272d4bd0ac683 [INFO] validating manifest of esell/doddns-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of esell/doddns-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing esell/doddns-rust [INFO] finished frobbing esell/doddns-rust [INFO] frobbed toml for esell/doddns-rust written to work/ex/clippy-test-run/sources/stable/gh/esell/doddns-rust/Cargo.toml [INFO] started frobbing esell/doddns-rust [INFO] finished frobbing esell/doddns-rust [INFO] frobbed toml for esell/doddns-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esell/doddns-rust/Cargo.toml [INFO] crate esell/doddns-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting esell/doddns-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/esell/doddns-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 453504aff476918d789c0aa726aa91488bba9767451dbc602b327601cfe86671 [INFO] running `"docker" "start" "-a" "453504aff476918d789c0aa726aa91488bba9767451dbc602b327601cfe86671"` [INFO] [stderr] Checking iovec v0.1.1 [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Compiling openssl-sys v0.9.23 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] Checking mio v0.6.12 [INFO] [stderr] Compiling openssl v0.9.23 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.12 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking doddns-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | / return records [INFO] [stderr] 199 | | .iter() [INFO] [stderr] 200 | | .find(|element| element.name == subdomain) [INFO] [stderr] 201 | | .is_some(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 198 | records [INFO] [stderr] 199 | .iter() [INFO] [stderr] 200 | .find(|element| element.name == subdomain) [INFO] [stderr] 201 | .is_some() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | return String::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | / return records [INFO] [stderr] 199 | | .iter() [INFO] [stderr] 200 | | .find(|element| element.name == subdomain) [INFO] [stderr] 201 | | .is_some(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 198 | records [INFO] [stderr] 199 | .iter() [INFO] [stderr] 200 | .find(|element| element.name == subdomain) [INFO] [stderr] 201 | .is_some() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | return String::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:197:24 [INFO] [stderr] | [INFO] [stderr] 197 | fn sub_exists(records: &Vec, subdomain: String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DomainRecord]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | return records [INFO] [stderr] | ____________^ [INFO] [stderr] 199 | | .iter() [INFO] [stderr] 200 | | .find(|element| element.name == subdomain) [INFO] [stderr] 201 | | .is_some(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|element| element.name == subdomain).is_some()` with `any(|element| element.name == subdomain)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:204:24 [INFO] [stderr] | [INFO] [stderr] 204 | fn get_sub_id(records: &Vec, subdomain: String) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DomainRecord]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:197:24 [INFO] [stderr] | [INFO] [stderr] 197 | fn sub_exists(records: &Vec, subdomain: String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DomainRecord]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | return records [INFO] [stderr] | ____________^ [INFO] [stderr] 199 | | .iter() [INFO] [stderr] 200 | | .find(|element| element.name == subdomain) [INFO] [stderr] 201 | | .is_some(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|element| element.name == subdomain).is_some()` with `any(|element| element.name == subdomain)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:204:24 [INFO] [stderr] | [INFO] [stderr] 204 | fn get_sub_id(records: &Vec, subdomain: String) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DomainRecord]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.01s [INFO] running `"docker" "inspect" "453504aff476918d789c0aa726aa91488bba9767451dbc602b327601cfe86671"` [INFO] running `"docker" "rm" "-f" "453504aff476918d789c0aa726aa91488bba9767451dbc602b327601cfe86671"` [INFO] [stdout] 453504aff476918d789c0aa726aa91488bba9767451dbc602b327601cfe86671