[INFO] updating cached repository esanum/excel_column_diff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/esanum/excel_column_diff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/esanum/excel_column_diff" "work/ex/clippy-test-run/sources/stable/gh/esanum/excel_column_diff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/esanum/excel_column_diff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/esanum/excel_column_diff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esanum/excel_column_diff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esanum/excel_column_diff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cd455e0eeec306840b187d562d82e1712b9eb456 [INFO] sha for GitHub repo esanum/excel_column_diff: cd455e0eeec306840b187d562d82e1712b9eb456 [INFO] validating manifest of esanum/excel_column_diff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of esanum/excel_column_diff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing esanum/excel_column_diff [INFO] finished frobbing esanum/excel_column_diff [INFO] frobbed toml for esanum/excel_column_diff written to work/ex/clippy-test-run/sources/stable/gh/esanum/excel_column_diff/Cargo.toml [INFO] started frobbing esanum/excel_column_diff [INFO] finished frobbing esanum/excel_column_diff [INFO] frobbed toml for esanum/excel_column_diff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/esanum/excel_column_diff/Cargo.toml [INFO] crate esanum/excel_column_diff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting esanum/excel_column_diff against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/esanum/excel_column_diff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 750e87d662befc4cf08087a8255722774da3d848bb705c410b0dc1acee173491 [INFO] running `"docker" "start" "-a" "750e87d662befc4cf08087a8255722774da3d848bb705c410b0dc1acee173491"` [INFO] [stderr] Checking zip v0.5.0 [INFO] [stderr] Checking quick-xml v0.13.1 [INFO] [stderr] Checking calamine v0.14.10 [INFO] [stderr] Checking excel_column_diff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | .expect(&format!("The workbook '{}' could not be loaded", path_left)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("The workbook '{}' could not be loaded", path_left))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | .expect(&format!("The workbook '{}' could not be loaded", path_right)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("The workbook '{}' could not be loaded", path_right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:84:10 [INFO] [stderr] | [INFO] [stderr] 84 | .expect(&format!("The test workbook could not be loaded")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("The test workbook could not be loaded"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | .expect(&format!("The test workbook could not be loaded")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The test workbook could not be loaded".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | .expect(&format!("The workbook '{}' could not be loaded", path_left)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("The workbook '{}' could not be loaded", path_left))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | .expect(&format!("The workbook '{}' could not be loaded", path_right)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("The workbook '{}' could not be loaded", path_right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.27s [INFO] running `"docker" "inspect" "750e87d662befc4cf08087a8255722774da3d848bb705c410b0dc1acee173491"` [INFO] running `"docker" "rm" "-f" "750e87d662befc4cf08087a8255722774da3d848bb705c410b0dc1acee173491"` [INFO] [stdout] 750e87d662befc4cf08087a8255722774da3d848bb705c410b0dc1acee173491