[INFO] updating cached repository errorport/rustbeat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/errorport/rustbeat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/errorport/rustbeat" "work/ex/clippy-test-run/sources/stable/gh/errorport/rustbeat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/errorport/rustbeat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/errorport/rustbeat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/errorport/rustbeat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/errorport/rustbeat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] df6a90a0a152ae7a5a66c994f15794631328a7a6 [INFO] sha for GitHub repo errorport/rustbeat: df6a90a0a152ae7a5a66c994f15794631328a7a6 [INFO] validating manifest of errorport/rustbeat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of errorport/rustbeat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing errorport/rustbeat [INFO] finished frobbing errorport/rustbeat [INFO] frobbed toml for errorport/rustbeat written to work/ex/clippy-test-run/sources/stable/gh/errorport/rustbeat/Cargo.toml [INFO] started frobbing errorport/rustbeat [INFO] finished frobbing errorport/rustbeat [INFO] frobbed toml for errorport/rustbeat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/errorport/rustbeat/Cargo.toml [INFO] crate errorport/rustbeat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting errorport/rustbeat against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/errorport/rustbeat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3bdd16a4312f2840ae685de9dd56a1f95e0405c2e1cc6c8213f25caa40247a5 [INFO] running `"docker" "start" "-a" "f3bdd16a4312f2840ae685de9dd56a1f95e0405c2e1cc6c8213f25caa40247a5"` [INFO] [stderr] Checking deep_unknown v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:18:6 [INFO] [stderr] | [INFO] [stderr] 18 | t+=(increment[increment_index] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:34:2 [INFO] [stderr] | [INFO] [stderr] 34 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | s = (t-(t>>4&t>>8)&t>>12)-2+(t>>4&t>>6); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(t-(t>>4&t>>8)) & t>>12` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:40:2 [INFO] [stderr] | [INFO] [stderr] 40 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | s = (t-(t>>4&t>>8)&t>>12)+(t>>4&t>>6); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(t-(t>>4&t>>8)) & t>>12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | s = t%(14312^t*3>>3^t>>10); [INFO] [stderr] | ^^^^^^ help: consider parenthesizing your expression: `(t*3) >> 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/main.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | let mut rng = thread_rng(); [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `s` is never read [INFO] [stderr] --> src/main.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | let mut s: i64 = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `s` is never read [INFO] [stderr] --> src/main.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | let mut s: i64 = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `s` is never read [INFO] [stderr] --> src/main.rs:44:10 [INFO] [stderr] | [INFO] [stderr] 44 | let mut s: i64 = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:6:6 [INFO] [stderr] | [INFO] [stderr] 6 | let mut rng = thread_rng(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:18:6 [INFO] [stderr] | [INFO] [stderr] 18 | t+=(increment[increment_index] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(increment[increment_index])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `increment`. [INFO] [stderr] --> src/main.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | for index in 0..increment.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 50 | for in &mut increment { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:18:6 [INFO] [stderr] | [INFO] [stderr] 18 | t+=(increment[increment_index] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:34:2 [INFO] [stderr] | [INFO] [stderr] 34 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | s = (t-(t>>4&t>>8)&t>>12)-2+(t>>4&t>>6); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(t-(t>>4&t>>8)) & t>>12` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:40:2 [INFO] [stderr] | [INFO] [stderr] 40 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | s = (t-(t>>4&t>>8)&t>>12)+(t>>4&t>>6); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(t-(t>>4&t>>8)) & t>>12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | s = t%(14312^t*3>>3^t>>10); [INFO] [stderr] | ^^^^^^ help: consider parenthesizing your expression: `(t*3) >> 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/main.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | let mut rng = thread_rng(); [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `s` is never read [INFO] [stderr] --> src/main.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | let mut s: i64 = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `s` is never read [INFO] [stderr] --> src/main.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | let mut s: i64 = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `s` is never read [INFO] [stderr] --> src/main.rs:44:10 [INFO] [stderr] | [INFO] [stderr] 44 | let mut s: i64 = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:6:6 [INFO] [stderr] | [INFO] [stderr] 6 | let mut rng = thread_rng(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:18:6 [INFO] [stderr] | [INFO] [stderr] 18 | t+=(increment[increment_index] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(increment[increment_index])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `increment`. [INFO] [stderr] --> src/main.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | for index in 0..increment.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 50 | for in &mut increment { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.03s [INFO] running `"docker" "inspect" "f3bdd16a4312f2840ae685de9dd56a1f95e0405c2e1cc6c8213f25caa40247a5"` [INFO] running `"docker" "rm" "-f" "f3bdd16a4312f2840ae685de9dd56a1f95e0405c2e1cc6c8213f25caa40247a5"` [INFO] [stdout] f3bdd16a4312f2840ae685de9dd56a1f95e0405c2e1cc6c8213f25caa40247a5