[INFO] updating cached repository erochest/todo-actix [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/erochest/todo-actix [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/erochest/todo-actix" "work/ex/clippy-test-run/sources/stable/gh/erochest/todo-actix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/erochest/todo-actix'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/erochest/todo-actix" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erochest/todo-actix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erochest/todo-actix'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 21db3e164c443cf7c133d776eb048a46ea28717c [INFO] sha for GitHub repo erochest/todo-actix: 21db3e164c443cf7c133d776eb048a46ea28717c [INFO] validating manifest of erochest/todo-actix on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of erochest/todo-actix on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing erochest/todo-actix [INFO] finished frobbing erochest/todo-actix [INFO] frobbed toml for erochest/todo-actix written to work/ex/clippy-test-run/sources/stable/gh/erochest/todo-actix/Cargo.toml [INFO] started frobbing erochest/todo-actix [INFO] finished frobbing erochest/todo-actix [INFO] frobbed toml for erochest/todo-actix written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erochest/todo-actix/Cargo.toml [INFO] crate erochest/todo-actix has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting erochest/todo-actix against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/erochest/todo-actix:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8751da4418986ea15f627c8adee10b2dd7bde04f3af6ad0bcba3250823fac59d [INFO] running `"docker" "start" "-a" "8751da4418986ea15f627c8adee10b2dd7bde04f3af6ad0bcba3250823fac59d"` [INFO] [stderr] Compiling actix-web v0.6.13 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Checking http v0.1.6 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling serde_json v1.0.20 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Compiling backtrace v0.3.8 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Compiling cargo_metadata v0.5.6 [INFO] [stderr] Checking h2 v0.1.9 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Compiling actix v0.5.8 [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Checking todo-actix v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:28:27 [INFO] [stderr] | [INFO] [stderr] 28 | self.send_message(|tx| CollectionMessages::GetList(tx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CollectionMessages::GetList` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | self.send_message(|tx| CollectionMessages::DeleteList(tx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CollectionMessages::DeleteList` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/collection.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / let _ = match message { [INFO] [stderr] 30 | | CollectionMessages::GetList(tx) => tx.send(self.get_list()).unwrap(), [INFO] [stderr] 31 | | CollectionMessages::PostList(todo_input, url_template, tx) => { [INFO] [stderr] 32 | | tx.send(self.post_list(todo_input, url_template)).unwrap() [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/collection.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / self.todos [INFO] [stderr] 85 | | .iter_mut() [INFO] [stderr] 86 | | .filter(|todo| todo.id == id) [INFO] [stderr] 87 | | .nth(0) [INFO] [stderr] ... | [INFO] [stderr] 99 | | }) [INFO] [stderr] 100 | | .map(|todo| todo.clone()) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 84 | self.todos [INFO] [stderr] 85 | .iter_mut() [INFO] [stderr] 86 | .filter(|todo| todo.id == id) [INFO] [stderr] 87 | .nth(0) [INFO] [stderr] 88 | .map(move |todo| { [INFO] [stderr] 89 | todo_edit [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:45:10 [INFO] [stderr] | [INFO] [stderr] 45 | .expect(&format!("Cannot bind to {}", &address)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot bind to {}", &address))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:28:27 [INFO] [stderr] | [INFO] [stderr] 28 | self.send_message(|tx| CollectionMessages::GetList(tx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CollectionMessages::GetList` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | self.send_message(|tx| CollectionMessages::DeleteList(tx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CollectionMessages::DeleteList` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/collection.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / let _ = match message { [INFO] [stderr] 30 | | CollectionMessages::GetList(tx) => tx.send(self.get_list()).unwrap(), [INFO] [stderr] 31 | | CollectionMessages::PostList(todo_input, url_template, tx) => { [INFO] [stderr] 32 | | tx.send(self.post_list(todo_input, url_template)).unwrap() [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/collection.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / self.todos [INFO] [stderr] 85 | | .iter_mut() [INFO] [stderr] 86 | | .filter(|todo| todo.id == id) [INFO] [stderr] 87 | | .nth(0) [INFO] [stderr] ... | [INFO] [stderr] 99 | | }) [INFO] [stderr] 100 | | .map(|todo| todo.clone()) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 84 | self.todos [INFO] [stderr] 85 | .iter_mut() [INFO] [stderr] 86 | .filter(|todo| todo.id == id) [INFO] [stderr] 87 | .nth(0) [INFO] [stderr] 88 | .map(move |todo| { [INFO] [stderr] 89 | todo_edit [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:45:10 [INFO] [stderr] | [INFO] [stderr] 45 | .expect(&format!("Cannot bind to {}", &address)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot bind to {}", &address))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 24s [INFO] running `"docker" "inspect" "8751da4418986ea15f627c8adee10b2dd7bde04f3af6ad0bcba3250823fac59d"` [INFO] running `"docker" "rm" "-f" "8751da4418986ea15f627c8adee10b2dd7bde04f3af6ad0bcba3250823fac59d"` [INFO] [stdout] 8751da4418986ea15f627c8adee10b2dd7bde04f3af6ad0bcba3250823fac59d