[INFO] updating cached repository ernstp/rustfun
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ernstp/rustfun
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ernstp/rustfun" "work/ex/clippy-test-run/sources/stable/gh/ernstp/rustfun"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ernstp/rustfun'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ernstp/rustfun" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ernstp/rustfun"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ernstp/rustfun'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9ba035f58c8c0f6931ec62fbeecf596930e3d313
[INFO] sha for GitHub repo ernstp/rustfun: 9ba035f58c8c0f6931ec62fbeecf596930e3d313
[INFO] validating manifest of ernstp/rustfun on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ernstp/rustfun on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ernstp/rustfun
[INFO] finished frobbing ernstp/rustfun
[INFO] frobbed toml for ernstp/rustfun written to work/ex/clippy-test-run/sources/stable/gh/ernstp/rustfun/Cargo.toml
[INFO] started frobbing ernstp/rustfun
[INFO] finished frobbing ernstp/rustfun
[INFO] frobbed toml for ernstp/rustfun written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ernstp/rustfun/Cargo.toml
[INFO] crate ernstp/rustfun has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ernstp/rustfun against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ernstp/rustfun:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4c4172313b54b53b8adfbfeaa93f6d8a22c269c48e0b90838e66d2e204fe0b82
[INFO] running `"docker" "start" "-a" "4c4172313b54b53b8adfbfeaa93f6d8a22c269c48e0b90838e66d2e204fe0b82"`
[INFO] [stderr]     Checking rustastar v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:124:17
[INFO] [stderr]     |
[INFO] [stderr] 124 |                 println!(""); // New line
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:134:16
[INFO] [stderr]     |
[INFO] [stderr] 134 |         Point {x: x,
[INFO] [stderr]     |                ^^^^ help: replace it with: `x`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:135:16
[INFO] [stderr]     |
[INFO] [stderr] 135 |                y: y,
[INFO] [stderr]     |                ^^^^ help: replace it with: `y`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:136:16
[INFO] [stderr]     |
[INFO] [stderr] 136 |                path: path,
[INFO] [stderr]     |                ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:138:16
[INFO] [stderr]     |
[INFO] [stderr] 138 |                remain: remain,
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: replace it with: `remain`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:144:16
[INFO] [stderr]     |
[INFO] [stderr] 144 |         Point {x: x,
[INFO] [stderr]     |                ^^^^ help: replace it with: `x`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:145:16
[INFO] [stderr]     |
[INFO] [stderr] 145 |                y: y,
[INFO] [stderr]     |                ^^^^ help: replace it with: `y`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:174:23
[INFO] [stderr]     |
[INFO] [stderr] 174 |         Map {data: d, sizex: sizex, sizey: sizey }
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: replace it with: `sizex`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:174:37
[INFO] [stderr]     |
[INFO] [stderr] 174 |         Map {data: d, sizex: sizex, sizey: sizey }
[INFO] [stderr]     |                                     ^^^^^^^^^^^^ help: replace it with: `sizey`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:124:17
[INFO] [stderr]     |
[INFO] [stderr] 124 |                 println!(""); // New line
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:134:16
[INFO] [stderr]     |
[INFO] [stderr] 134 |         Point {x: x,
[INFO] [stderr]     |                ^^^^ help: replace it with: `x`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:135:16
[INFO] [stderr]     |
[INFO] [stderr] 135 |                y: y,
[INFO] [stderr]     |                ^^^^ help: replace it with: `y`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:136:16
[INFO] [stderr]     |
[INFO] [stderr] 136 |                path: path,
[INFO] [stderr]     |                ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:138:16
[INFO] [stderr]     |
[INFO] [stderr] 138 |                remain: remain,
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: replace it with: `remain`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:144:16
[INFO] [stderr]     |
[INFO] [stderr] 144 |         Point {x: x,
[INFO] [stderr]     |                ^^^^ help: replace it with: `x`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:145:16
[INFO] [stderr]     |
[INFO] [stderr] 145 |                y: y,
[INFO] [stderr]     |                ^^^^ help: replace it with: `y`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:174:23
[INFO] [stderr]     |
[INFO] [stderr] 174 |         Map {data: d, sizex: sizex, sizey: sizey }
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: replace it with: `sizex`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:174:37
[INFO] [stderr]     |
[INFO] [stderr] 174 |         Map {data: d, sizex: sizex, sizey: sizey }
[INFO] [stderr]     |                                     ^^^^^^^^^^^^ help: replace it with: `sizey`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return path;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:249:9
[INFO] [stderr]     |
[INFO] [stderr] 249 |         return current.get_path(&closed);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current.get_path(&closed)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:251:9
[INFO] [stderr]     |
[INFO] [stderr] 251 |         return best.get_path(&closed)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best.get_path(&closed)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return path;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:249:9
[INFO] [stderr]     |
[INFO] [stderr] 249 |         return current.get_path(&closed);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current.get_path(&closed)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:251:9
[INFO] [stderr]     |
[INFO] [stderr] 251 |         return best.get_path(&closed)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best.get_path(&closed)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:153:28
[INFO] [stderr]     |
[INFO] [stderr] 153 |     fn avail(&self, index: &u32) -> bool {
[INFO] [stderr]     |                            ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:157:25
[INFO] [stderr]     |
[INFO] [stderr] 157 |     fn in_map(&self, x: &i32, y: &i32) -> bool {
[INFO] [stderr]     |                         ^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:157:34
[INFO] [stderr]     |
[INFO] [stderr] 157 |     fn in_map(&self, x: &i32, y: &i32) -> bool {
[INFO] [stderr]     |                                  ^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:264:22
[INFO] [stderr]     |
[INFO] [stderr] 264 |       let iterations = match visual {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 265 | |         true => 1,
[INFO] [stderr] 266 | |         false => 10000,
[INFO] [stderr] 267 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if visual { 1 } else { 10000 }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:281:49
[INFO] [stderr]     |
[INFO] [stderr] 281 |     println!("{}", (dur.as_secs() * 1_000_000 + dur.subsec_nanos() as u64 / 1000) / iterations);
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dur.subsec_nanos())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:153:28
[INFO] [stderr]     |
[INFO] [stderr] 153 |     fn avail(&self, index: &u32) -> bool {
[INFO] [stderr]     |                            ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:157:25
[INFO] [stderr]     |
[INFO] [stderr] 157 |     fn in_map(&self, x: &i32, y: &i32) -> bool {
[INFO] [stderr]     |                         ^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:157:34
[INFO] [stderr]     |
[INFO] [stderr] 157 |     fn in_map(&self, x: &i32, y: &i32) -> bool {
[INFO] [stderr]     |                                  ^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:264:22
[INFO] [stderr]     |
[INFO] [stderr] 264 |       let iterations = match visual {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 265 | |         true => 1,
[INFO] [stderr] 266 | |         false => 10000,
[INFO] [stderr] 267 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if visual { 1 } else { 10000 }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:281:49
[INFO] [stderr]     |
[INFO] [stderr] 281 |     println!("{}", (dur.as_secs() * 1_000_000 + dur.subsec_nanos() as u64 / 1000) / iterations);
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dur.subsec_nanos())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.20s
[INFO] running `"docker" "inspect" "4c4172313b54b53b8adfbfeaa93f6d8a22c269c48e0b90838e66d2e204fe0b82"`
[INFO] running `"docker" "rm" "-f" "4c4172313b54b53b8adfbfeaa93f6d8a22c269c48e0b90838e66d2e204fe0b82"`
[INFO] [stdout] 4c4172313b54b53b8adfbfeaa93f6d8a22c269c48e0b90838e66d2e204fe0b82