[INFO] updating cached repository ernestrc/sonic-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ernestrc/sonic-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ernestrc/sonic-rs" "work/ex/clippy-test-run/sources/stable/gh/ernestrc/sonic-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ernestrc/sonic-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ernestrc/sonic-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ernestrc/sonic-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ernestrc/sonic-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8bdab4b70d85101356f71d57f4120fecfdd23004 [INFO] sha for GitHub repo ernestrc/sonic-rs: 8bdab4b70d85101356f71d57f4120fecfdd23004 [INFO] validating manifest of ernestrc/sonic-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ernestrc/sonic-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ernestrc/sonic-rs [INFO] finished frobbing ernestrc/sonic-rs [INFO] frobbed toml for ernestrc/sonic-rs written to work/ex/clippy-test-run/sources/stable/gh/ernestrc/sonic-rs/Cargo.toml [INFO] started frobbing ernestrc/sonic-rs [INFO] finished frobbing ernestrc/sonic-rs [INFO] frobbed toml for ernestrc/sonic-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ernestrc/sonic-rs/Cargo.toml [INFO] crate ernestrc/sonic-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ernestrc/sonic-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ernestrc/sonic-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 57d38cfb768a971f665d625f3f5dad1fe6b75dd9d61176baa4d18100468aa2fb [INFO] running `"docker" "start" "-a" "57d38cfb768a971f665d625f3f5dad1fe6b75dd9d61176baa4d18100468aa2fb"` [INFO] [stderr] Compiling term v0.4.5 [INFO] [stderr] Compiling syntex_pos v0.44.0 [INFO] [stderr] Compiling syntex_pos v0.41.0 [INFO] [stderr] Compiling backtrace-sys v0.1.10 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Compiling nix v0.6.0 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking pbr v1.0.0 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking rpassword v0.2.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Compiling syntex_errors v0.44.0 [INFO] [stderr] Compiling syntex_errors v0.41.0 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Compiling syntex_syntax v0.41.0 [INFO] [stderr] Compiling syntex_syntax v0.44.1 [INFO] [stderr] Checking docopt v0.6.86 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking error-chain v0.5.0 [INFO] [stderr] Compiling aster v0.27.0 [INFO] [stderr] Compiling syntex v0.44.0 [INFO] [stderr] Compiling quasi v0.20.1 [INFO] [stderr] Compiling serde_codegen_internals v0.8.9 [INFO] [stderr] Compiling syntex v0.41.0 [INFO] [stderr] Compiling quasi_codegen v0.20.0 [INFO] [stderr] Compiling serde_codegen v0.8.9 [INFO] [stderr] Compiling sonic v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | query: query, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | trace_id: trace_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `trace_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | auth: auth, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | user: user, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `user` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | trace_id: trace_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `trace_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | query: query, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | trace_id: trace_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `trace_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | auth: auth, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | user: user, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `user` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | trace_id: trace_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `trace_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:141:34 [INFO] [stderr] | [INFO] [stderr] 141 | const VARIANTS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:141:44 [INFO] [stderr] | [INFO] [stderr] 141 | const VARIANTS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:380:32 [INFO] [stderr] | [INFO] [stderr] 380 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:380:42 [INFO] [stderr] | [INFO] [stderr] 380 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:141:34 [INFO] [stderr] | [INFO] [stderr] 141 | const VARIANTS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:141:44 [INFO] [stderr] | [INFO] [stderr] 141 | const VARIANTS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:380:32 [INFO] [stderr] | [INFO] [stderr] 380 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:380:42 [INFO] [stderr] | [INFO] [stderr] 380 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | / error_chain! { [INFO] [stderr] 3 | | types { [INFO] [stderr] 4 | | Error, ErrorKind, ChainErr, Result; [INFO] [stderr] 5 | | } [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/api.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | try!(stream.write(&fbytes.as_slice())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/model/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn get_raw<'a>(&'a self) -> &'a str { [INFO] [stderr] 40 | | &(self.query) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/model/mod.rs:44:46 [INFO] [stderr] | [INFO] [stderr] 44 | let v = try!(self.config.search(key).ok_or(format!("missing key {} in query config", key))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("missing key {} in query config", key))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/model/mod.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | SonicMessage::StreamCompleted(variation, trace_id).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `SonicMessage::StreamCompleted(variation, trace_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:398:48 [INFO] [stderr] | [INFO] [stderr] 398 | "ProtoSonicMessage" , 0 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:426:41 [INFO] [stderr] | [INFO] [stderr] 426 | auth.map(|s| [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 427 | | Value::String(s)).unwrap_or_else(|| [INFO] [stderr] | |____________________________________________________________^ help: remove closure as shown: `Value::String` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:430:45 [INFO] [stderr] | [INFO] [stderr] 430 | trace_id.map(|s| [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 431 | | Value::String(s)).unwrap_or_else(|| [INFO] [stderr] | |________________________________________________________________^ help: remove closure as shown: `Value::String` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:450:45 [INFO] [stderr] | [INFO] [stderr] 450 | trace_id.map(|s| [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 451 | | Value::String(s)).unwrap_or_else(|| [INFO] [stderr] | |________________________________________________________________^ help: remove closure as shown: `Value::String` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sonic`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | / error_chain! { [INFO] [stderr] 3 | | types { [INFO] [stderr] 4 | | Error, ErrorKind, ChainErr, Result; [INFO] [stderr] 5 | | } [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/api.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | try!(stream.write(&fbytes.as_slice())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/model/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn get_raw<'a>(&'a self) -> &'a str { [INFO] [stderr] 40 | | &(self.query) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/model/mod.rs:44:46 [INFO] [stderr] | [INFO] [stderr] 44 | let v = try!(self.config.search(key).ok_or(format!("missing key {} in query config", key))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("missing key {} in query config", key))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/model/mod.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | SonicMessage::StreamCompleted(variation, trace_id).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `SonicMessage::StreamCompleted(variation, trace_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:398:48 [INFO] [stderr] | [INFO] [stderr] 398 | "ProtoSonicMessage" , 0 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:426:41 [INFO] [stderr] | [INFO] [stderr] 426 | auth.map(|s| [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 427 | | Value::String(s)).unwrap_or_else(|| [INFO] [stderr] | |____________________________________________________________^ help: remove closure as shown: `Value::String` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:430:45 [INFO] [stderr] | [INFO] [stderr] 430 | trace_id.map(|s| [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 431 | | Value::String(s)).unwrap_or_else(|| [INFO] [stderr] | |________________________________________________________________^ help: remove closure as shown: `Value::String` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> /opt/crater/target/debug/build/sonic-5311632f5ed8abc3/out/protocol.rs:450:45 [INFO] [stderr] | [INFO] [stderr] 450 | trace_id.map(|s| [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 451 | | Value::String(s)).unwrap_or_else(|| [INFO] [stderr] | |________________________________________________________________^ help: remove closure as shown: `Value::String` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sonic`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "57d38cfb768a971f665d625f3f5dad1fe6b75dd9d61176baa4d18100468aa2fb"` [INFO] running `"docker" "rm" "-f" "57d38cfb768a971f665d625f3f5dad1fe6b75dd9d61176baa4d18100468aa2fb"` [INFO] [stdout] 57d38cfb768a971f665d625f3f5dad1fe6b75dd9d61176baa4d18100468aa2fb