[INFO] updating cached repository eriksvedang/UnifierInRust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/eriksvedang/UnifierInRust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/eriksvedang/UnifierInRust" "work/ex/clippy-test-run/sources/stable/gh/eriksvedang/UnifierInRust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eriksvedang/UnifierInRust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/eriksvedang/UnifierInRust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eriksvedang/UnifierInRust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eriksvedang/UnifierInRust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1046fadca4a7452538b4437bc5d796e657d338f9
[INFO] sha for GitHub repo eriksvedang/UnifierInRust: 1046fadca4a7452538b4437bc5d796e657d338f9
[INFO] validating manifest of eriksvedang/UnifierInRust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of eriksvedang/UnifierInRust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing eriksvedang/UnifierInRust
[INFO] finished frobbing eriksvedang/UnifierInRust
[INFO] frobbed toml for eriksvedang/UnifierInRust written to work/ex/clippy-test-run/sources/stable/gh/eriksvedang/UnifierInRust/Cargo.toml
[INFO] started frobbing eriksvedang/UnifierInRust
[INFO] finished frobbing eriksvedang/UnifierInRust
[INFO] frobbed toml for eriksvedang/UnifierInRust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eriksvedang/UnifierInRust/Cargo.toml
[INFO] crate eriksvedang/UnifierInRust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting eriksvedang/UnifierInRust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eriksvedang/UnifierInRust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5f16d0e4e2a791353158d88979808fb919fcfb8f62c8ea4322e6d63a561935aa
[INFO] running `"docker" "start" "-a" "5f16d0e4e2a791353158d88979808fb919fcfb8f62c8ea4322e6d63a561935aa"`
[INFO] [stderr]     Checking unifier_in_rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:99:9
[INFO] [stderr]    |
[INFO] [stderr] 99 |         return Ok(current_bindings);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(current_bindings)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 |     return new_bindings;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_bindings`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:113:5
[INFO] [stderr]     |
[INFO] [stderr] 113 |     return result;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:99:9
[INFO] [stderr]    |
[INFO] [stderr] 99 |         return Ok(current_bindings);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(current_bindings)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 |     return new_bindings;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_bindings`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:113:5
[INFO] [stderr]     |
[INFO] [stderr] 113 |     return result;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join
[INFO] [stderr]   --> src/main.rs:59:55
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 write!(f, "[{}]", expressions_strings.connect(", "))
[INFO] [stderr]    |                                                       ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join
[INFO] [stderr]   --> src/main.rs:59:55
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 write!(f, "[{}]", expressions_strings.connect(", "))
[INFO] [stderr]    |                                                       ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join
[INFO] [stderr]    --> src/main.rs:111:41
[INFO] [stderr]     |
[INFO] [stderr] 111 |     let all_bindings = bindings_strings.connect(", ");
[INFO] [stderr]     |                                         ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join
[INFO] [stderr]    --> src/main.rs:111:41
[INFO] [stderr]     |
[INFO] [stderr] 111 |     let all_bindings = bindings_strings.connect(", ");
[INFO] [stderr]     |                                         ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 | /         match self {
[INFO] [stderr] 55 | |             &Expr::LVar(ref name) => write!(f, "{}", name),
[INFO] [stderr] 56 | |             &Expr::Value(ref value) => write!(f, "{}", value),
[INFO] [stderr] 57 | |             &Expr::List(ref expressions) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 60 | |             }
[INFO] [stderr] 61 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 54 |         match *self {
[INFO] [stderr] 55 |             Expr::LVar(ref name) => write!(f, "{}", name),
[INFO] [stderr] 56 |             Expr::Value(ref value) => write!(f, "{}", value),
[INFO] [stderr] 57 |             Expr::List(ref expressions) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 | /         match self {
[INFO] [stderr] 55 | |             &Expr::LVar(ref name) => write!(f, "{}", name),
[INFO] [stderr] 56 | |             &Expr::Value(ref value) => write!(f, "{}", value),
[INFO] [stderr] 57 | |             &Expr::List(ref expressions) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 60 | |             }
[INFO] [stderr] 61 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 54 |         match *self {
[INFO] [stderr] 55 |             Expr::LVar(ref name) => write!(f, "{}", name),
[INFO] [stderr] 56 |             Expr::Value(ref value) => write!(f, "{}", value),
[INFO] [stderr] 57 |             Expr::List(ref expressions) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:87:58
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn unify_lists<T : Clone + Eq + Debug + Display>(list_a: &Vec<Expr<T>>, list_b: &Vec<Expr<T>>, bindings: Bindings<T>) -> Unification<T> {
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn unify_lists<T : Clone + Eq + Debug + Display>(list_a: &[Expr<T>], list_b: &Vec<Expr<T>>, bindings: Bindings<T>) -> Unification<T> {
[INFO] [stderr]    |                                                          ^^^^^^^^^^
[INFO] [stderr] help: change `list_a.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 89 |         Err(format!("Can't unify {} with {} (different length)", Expr::List(list_a.to_owned()), Expr::List(list_b.clone())))
[INFO] [stderr]    |                                                                             ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:87:81
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn unify_lists<T : Clone + Eq + Debug + Display>(list_a: &Vec<Expr<T>>, list_b: &Vec<Expr<T>>, bindings: Bindings<T>) -> Unification<T> {
[INFO] [stderr]    |                                                                                 ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn unify_lists<T : Clone + Eq + Debug + Display>(list_a: &Vec<Expr<T>>, list_b: &[Expr<T>], bindings: Bindings<T>) -> Unification<T> {
[INFO] [stderr]    |                                                                                 ^^^^^^^^^^
[INFO] [stderr] help: change `list_b.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 89 |         Err(format!("Can't unify {} with {} (different length)", Expr::List(list_a.clone()), Expr::List(list_b.to_owned())))
[INFO] [stderr]    |                                                                                                         ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:87:58
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn unify_lists<T : Clone + Eq + Debug + Display>(list_a: &Vec<Expr<T>>, list_b: &Vec<Expr<T>>, bindings: Bindings<T>) -> Unification<T> {
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn unify_lists<T : Clone + Eq + Debug + Display>(list_a: &[Expr<T>], list_b: &Vec<Expr<T>>, bindings: Bindings<T>) -> Unification<T> {
[INFO] [stderr]    |                                                          ^^^^^^^^^^
[INFO] [stderr] help: change `list_a.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 89 |         Err(format!("Can't unify {} with {} (different length)", Expr::List(list_a.to_owned()), Expr::List(list_b.clone())))
[INFO] [stderr]    |                                                                             ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:87:81
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn unify_lists<T : Clone + Eq + Debug + Display>(list_a: &Vec<Expr<T>>, list_b: &Vec<Expr<T>>, bindings: Bindings<T>) -> Unification<T> {
[INFO] [stderr]    |                                                                                 ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn unify_lists<T : Clone + Eq + Debug + Display>(list_a: &Vec<Expr<T>>, list_b: &[Expr<T>], bindings: Bindings<T>) -> Unification<T> {
[INFO] [stderr]    |                                                                                 ^^^^^^^^^^
[INFO] [stderr] help: change `list_b.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 89 |         Err(format!("Can't unify {} with {} (different length)", Expr::List(list_a.clone()), Expr::List(list_b.to_owned())))
[INFO] [stderr]    |                                                                                                         ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.03s
[INFO] running `"docker" "inspect" "5f16d0e4e2a791353158d88979808fb919fcfb8f62c8ea4322e6d63a561935aa"`
[INFO] running `"docker" "rm" "-f" "5f16d0e4e2a791353158d88979808fb919fcfb8f62c8ea4322e6d63a561935aa"`
[INFO] [stdout] 5f16d0e4e2a791353158d88979808fb919fcfb8f62c8ea4322e6d63a561935aa