[INFO] updating cached repository erikbrinkman/cdasim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/erikbrinkman/cdasim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/erikbrinkman/cdasim" "work/ex/clippy-test-run/sources/stable/gh/erikbrinkman/cdasim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/erikbrinkman/cdasim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/erikbrinkman/cdasim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erikbrinkman/cdasim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erikbrinkman/cdasim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 70e620ae85a44b9dd3b5ae43a76963b13f745701 [INFO] sha for GitHub repo erikbrinkman/cdasim: 70e620ae85a44b9dd3b5ae43a76963b13f745701 [INFO] validating manifest of erikbrinkman/cdasim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of erikbrinkman/cdasim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing erikbrinkman/cdasim [INFO] finished frobbing erikbrinkman/cdasim [INFO] frobbed toml for erikbrinkman/cdasim written to work/ex/clippy-test-run/sources/stable/gh/erikbrinkman/cdasim/Cargo.toml [INFO] started frobbing erikbrinkman/cdasim [INFO] finished frobbing erikbrinkman/cdasim [INFO] frobbed toml for erikbrinkman/cdasim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erikbrinkman/cdasim/Cargo.toml [INFO] crate erikbrinkman/cdasim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting erikbrinkman/cdasim against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/erikbrinkman/cdasim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d9f62e7163d55e334d0fd3578d6a6ddbb2b6ea3c805b16fd1a7298fa860acc2 [INFO] running `"docker" "start" "-a" "1d9f62e7163d55e334d0fd3578d6a6ddbb2b6ea3c805b16fd1a7298fa860acc2"` [INFO] [stderr] Checking cdasim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/agent.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | buyer: buyer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `buyer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/agent.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | strat: strat, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `strat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/agent.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/agent.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | shading: shading, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `shading` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | features: features, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `features` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | surplus: surplus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surplus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | ce_surplus: ce_surplus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ce_surplus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | im_surplus: im_surplus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `im_surplus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | em_surplus: em_surplus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `em_surplus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | ce_price: ce_price, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ce_price` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/agent.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | buyer: buyer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `buyer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/agent.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | strat: strat, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `strat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/agent.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/agent.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | shading: shading, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `shading` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | features: features, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `features` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | surplus: surplus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surplus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | ce_surplus: ce_surplus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ce_surplus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | im_surplus: im_surplus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `im_surplus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | em_surplus: em_surplus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `em_surplus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | ce_price: ce_price, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ce_price` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/market.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 62 | | if buys.peek().map(|b| -agent.bid <= b.bid).unwrap_or(false) { [INFO] [stderr] 63 | | let mut buyer = buys.pop().unwrap(); [INFO] [stderr] 64 | | let price = buyer.bid; [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 61 | } else if buys.peek().map(|b| -agent.bid <= b.bid).unwrap_or(false) { [INFO] [stderr] 62 | let mut buyer = buys.pop().unwrap(); [INFO] [stderr] 63 | let price = buyer.bid; [INFO] [stderr] 64 | trans(buyer, agent, price); [INFO] [stderr] 65 | } else { [INFO] [stderr] 66 | sells.push(agent); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/market.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 62 | | if buys.peek().map(|b| -agent.bid <= b.bid).unwrap_or(false) { [INFO] [stderr] 63 | | let mut buyer = buys.pop().unwrap(); [INFO] [stderr] 64 | | let price = buyer.bid; [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 61 | } else if buys.peek().map(|b| -agent.bid <= b.bid).unwrap_or(false) { [INFO] [stderr] 62 | let mut buyer = buys.pop().unwrap(); [INFO] [stderr] 63 | let price = buyer.bid; [INFO] [stderr] 64 | trans(buyer, agent, price); [INFO] [stderr] 65 | } else { [INFO] [stderr] 66 | sells.push(agent); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/market.rs:49:48 [INFO] [stderr] | [INFO] [stderr] 49 | avg_price += (price - avg_price) / num_trans as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(num_trans)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | ohandle.write("\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cdasim`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/agent.rs:107:48 [INFO] [stderr] | [INFO] [stderr] 107 | for shading in (0..11).map(|s| s as f64 / 10.0) { [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/market.rs:49:48 [INFO] [stderr] | [INFO] [stderr] 49 | avg_price += (price - avg_price) / num_trans as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(num_trans)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | ohandle.write("\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cdasim`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1d9f62e7163d55e334d0fd3578d6a6ddbb2b6ea3c805b16fd1a7298fa860acc2"` [INFO] running `"docker" "rm" "-f" "1d9f62e7163d55e334d0fd3578d6a6ddbb2b6ea3c805b16fd1a7298fa860acc2"` [INFO] [stdout] 1d9f62e7163d55e334d0fd3578d6a6ddbb2b6ea3c805b16fd1a7298fa860acc2