[INFO] updating cached repository erictzeng/advent2016 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/erictzeng/advent2016 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/erictzeng/advent2016" "work/ex/clippy-test-run/sources/stable/gh/erictzeng/advent2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/erictzeng/advent2016'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/erictzeng/advent2016" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erictzeng/advent2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erictzeng/advent2016'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 519436fb7576d78bdc1389ecd3b78a0b00e6df74 [INFO] sha for GitHub repo erictzeng/advent2016: 519436fb7576d78bdc1389ecd3b78a0b00e6df74 [INFO] validating manifest of erictzeng/advent2016 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of erictzeng/advent2016 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing erictzeng/advent2016 [INFO] finished frobbing erictzeng/advent2016 [INFO] frobbed toml for erictzeng/advent2016 written to work/ex/clippy-test-run/sources/stable/gh/erictzeng/advent2016/Cargo.toml [INFO] started frobbing erictzeng/advent2016 [INFO] finished frobbing erictzeng/advent2016 [INFO] frobbed toml for erictzeng/advent2016 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erictzeng/advent2016/Cargo.toml [INFO] crate erictzeng/advent2016 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting erictzeng/advent2016 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/erictzeng/advent2016:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 767a5077ad4391a82cbd8aaaec9030fc12a8a357b408462584b66b8b5ccf72b8 [INFO] running `"docker" "start" "-a" "767a5077ad4391a82cbd8aaaec9030fc12a8a357b408462584b66b8b5ccf72b8"` [INFO] [stderr] Checking md5 v0.2.1 [INFO] [stderr] Checking num-complex v0.1.35 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking advent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day4.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | heap.push(Entry{char: char, count: count}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day4.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | heap.push(Entry{char: char, count: count}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day7.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/day3.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | if col_tris.len() == 0 || col_tris[col_tris.len() - 1].len() == 3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `col_tris.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/day8.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/day8.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day4.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return checksum == get_checksum(room) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `checksum == get_checksum(room)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/day4.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | let base = 'a' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/day1.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | visited.insert(pos.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/day1.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | let dir = dirs[dir_index].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dirs[dir_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/day1.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | visited.insert(pos.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/day8.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/day8.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day4.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | heap.push(Entry{char: char, count: count}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day4.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | heap.push(Entry{char: char, count: count}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/day2.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | / if next_pos.1 < keypad.len() { [INFO] [stderr] 31 | | if next_pos.0 < keypad[next_pos.1].len() { [INFO] [stderr] 32 | | if keypad[next_pos.1][next_pos.0] != " " { [INFO] [stderr] 33 | | positions[keypad_ind] = next_pos; [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | if next_pos.1 < keypad.len() && next_pos.0 < keypad[next_pos.1].len() { [INFO] [stderr] 31 | if keypad[next_pos.1][next_pos.0] != " " { [INFO] [stderr] 32 | positions[keypad_ind] = next_pos; [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/day2.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | / if next_pos.0 < keypad[next_pos.1].len() { [INFO] [stderr] 32 | | if keypad[next_pos.1][next_pos.0] != " " { [INFO] [stderr] 33 | | positions[keypad_ind] = next_pos; [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | if next_pos.0 < keypad[next_pos.1].len() && keypad[next_pos.1][next_pos.0] != " " { [INFO] [stderr] 32 | positions[keypad_ind] = next_pos; [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/day2.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | / if next_pos.1 < keypad.len() { [INFO] [stderr] 31 | | if next_pos.0 < keypad[next_pos.1].len() { [INFO] [stderr] 32 | | if keypad[next_pos.1][next_pos.0] != " " { [INFO] [stderr] 33 | | positions[keypad_ind] = next_pos; [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | if next_pos.1 < keypad.len() && next_pos.0 < keypad[next_pos.1].len() { [INFO] [stderr] 31 | if keypad[next_pos.1][next_pos.0] != " " { [INFO] [stderr] 32 | positions[keypad_ind] = next_pos; [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/day2.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | / if next_pos.0 < keypad[next_pos.1].len() { [INFO] [stderr] 32 | | if keypad[next_pos.1][next_pos.0] != " " { [INFO] [stderr] 33 | | positions[keypad_ind] = next_pos; [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | if next_pos.0 < keypad[next_pos.1].len() && keypad[next_pos.1][next_pos.0] != " " { [INFO] [stderr] 32 | positions[keypad_ind] = next_pos; [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/day2.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | let ref keypad = keypads[keypad_ind]; [INFO] [stderr] | ----^^^^^^^^^^----------------------- help: try: `let keypad = &keypads[keypad_ind];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/day2.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let ref keypad = keypads[keypad_ind]; [INFO] [stderr] | ----^^^^^^^^^^----------------------- help: try: `let keypad = &keypads[keypad_ind];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `keypad_ind` is used to index `codes` [INFO] [stderr] --> src/bin/day2.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | for keypad_ind in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for (keypad_ind, ) in codes.iter().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/day3.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | if col_tris.len() == 0 || col_tris[col_tris.len() - 1].len() == 3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `col_tris.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/day1.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | visited.insert(pos.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/day1.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | let dir = dirs[dir_index].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dirs[dir_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/day1.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | visited.insert(pos.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/day2.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | let ref keypad = keypads[keypad_ind]; [INFO] [stderr] | ----^^^^^^^^^^----------------------- help: try: `let keypad = &keypads[keypad_ind];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/day2.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let ref keypad = keypads[keypad_ind]; [INFO] [stderr] | ----^^^^^^^^^^----------------------- help: try: `let keypad = &keypads[keypad_ind];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `keypad_ind` is used to index `codes` [INFO] [stderr] --> src/bin/day2.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | for keypad_ind in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for (keypad_ind, ) in codes.iter().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day4.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return checksum == get_checksum(room) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `checksum == get_checksum(room)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/day4.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | let base = 'a' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day7.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `self.pixels[row][next]` and `prev` manually [INFO] [stderr] --> src/bin/day8.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / let tmp = self.pixels[row][next]; [INFO] [stderr] 34 | | self.pixels[row][next] = prev; [INFO] [stderr] 35 | | prev = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut self.pixels[row][next], &mut prev)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `self.pixels[next][col]` and `prev` manually [INFO] [stderr] --> src/bin/day8.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | / let tmp = self.pixels[next][col]; [INFO] [stderr] 53 | | self.pixels[next][col] = prev; [INFO] [stderr] 54 | | prev = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut self.pixels[next][col], &mut prev)` [INFO] [stderr] | [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `self.pixels[row][next]` and `prev` manually [INFO] [stderr] --> src/bin/day8.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / let tmp = self.pixels[row][next]; [INFO] [stderr] 34 | | self.pixels[row][next] = prev; [INFO] [stderr] 35 | | prev = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut self.pixels[row][next], &mut prev)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `self.pixels[next][col]` and `prev` manually [INFO] [stderr] --> src/bin/day8.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | / let tmp = self.pixels[next][col]; [INFO] [stderr] 53 | | self.pixels[next][col] = prev; [INFO] [stderr] 54 | | prev = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut self.pixels[next][col], &mut prev)` [INFO] [stderr] | [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.00s [INFO] running `"docker" "inspect" "767a5077ad4391a82cbd8aaaec9030fc12a8a357b408462584b66b8b5ccf72b8"` [INFO] running `"docker" "rm" "-f" "767a5077ad4391a82cbd8aaaec9030fc12a8a357b408462584b66b8b5ccf72b8"` [INFO] [stdout] 767a5077ad4391a82cbd8aaaec9030fc12a8a357b408462584b66b8b5ccf72b8