[INFO] updating cached repository erickosamudera/snek-renpy-preprocessor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/erickosamudera/snek-renpy-preprocessor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/erickosamudera/snek-renpy-preprocessor" "work/ex/clippy-test-run/sources/stable/gh/erickosamudera/snek-renpy-preprocessor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/erickosamudera/snek-renpy-preprocessor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/erickosamudera/snek-renpy-preprocessor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erickosamudera/snek-renpy-preprocessor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erickosamudera/snek-renpy-preprocessor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6bb8940f78921757113926ef66b1507ae36db6f1 [INFO] sha for GitHub repo erickosamudera/snek-renpy-preprocessor: 6bb8940f78921757113926ef66b1507ae36db6f1 [INFO] validating manifest of erickosamudera/snek-renpy-preprocessor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of erickosamudera/snek-renpy-preprocessor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing erickosamudera/snek-renpy-preprocessor [INFO] finished frobbing erickosamudera/snek-renpy-preprocessor [INFO] frobbed toml for erickosamudera/snek-renpy-preprocessor written to work/ex/clippy-test-run/sources/stable/gh/erickosamudera/snek-renpy-preprocessor/Cargo.toml [INFO] started frobbing erickosamudera/snek-renpy-preprocessor [INFO] finished frobbing erickosamudera/snek-renpy-preprocessor [INFO] frobbed toml for erickosamudera/snek-renpy-preprocessor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erickosamudera/snek-renpy-preprocessor/Cargo.toml [INFO] crate erickosamudera/snek-renpy-preprocessor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting erickosamudera/snek-renpy-preprocessor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/erickosamudera/snek-renpy-preprocessor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44dbca3e31737eb55d2eba907bf5c0ecfc7d37a0f54f4da45909b15882421f83 [INFO] running `"docker" "start" "-a" "44dbca3e31737eb55d2eba907bf5c0ecfc7d37a0f54f4da45909b15882421f83"` [INFO] [stderr] Checking snek-preprocessor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line_parser/command.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | arguments: arguments [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line_parser/command.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | arguments: arguments [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return env::args().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `env::args().collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return processed_files; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `processed_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/utility.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | return string.chars().skip(1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.chars().skip(1).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/utility.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return string.chars().take(length - 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.chars().take(length - 1).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/command.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return line; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/label.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return line; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/label.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return LineLabelType::GLOBAL; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LineLabelType::GLOBAL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/label.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return LineLabelType::LOCAL; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LineLabelType::LOCAL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/label.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / return match first_char_opt { [INFO] [stderr] 57 | | Some(first_char) => if first_char == '>' { return true } else { false }, [INFO] [stderr] 58 | | None => false [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | match first_char_opt { [INFO] [stderr] 57 | Some(first_char) => if first_char == '>' { return true } else { false }, [INFO] [stderr] 58 | None => false [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/label.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / return if last_char == ':' { [INFO] [stderr] 70 | | strip_last_char(label_id) [INFO] [stderr] 71 | | } else { [INFO] [stderr] 72 | | label_id.to_owned() [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 69 | if last_char == ':' { [INFO] [stderr] 70 | strip_last_char(label_id) [INFO] [stderr] 71 | } else { [INFO] [stderr] 72 | label_id.to_owned() [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/speech.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / return ParsedLine { [INFO] [stderr] 14 | | speech: Some(new_speech), [INFO] [stderr] 15 | | action: None, [INFO] [stderr] 16 | | label: None, [INFO] [stderr] 17 | | choice: None, [INFO] [stderr] 18 | | regular: None [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | ParsedLine { [INFO] [stderr] 14 | speech: Some(new_speech), [INFO] [stderr] 15 | action: None, [INFO] [stderr] 16 | label: None, [INFO] [stderr] 17 | choice: None, [INFO] [stderr] 18 | regular: None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/choice.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return line; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/regular.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / return ParsedLine { [INFO] [stderr] 12 | | speech: None, [INFO] [stderr] 13 | | action: None, [INFO] [stderr] 14 | | label: None, [INFO] [stderr] 15 | | choice: None, [INFO] [stderr] 16 | | regular: Some(regular_line) [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 11 | ParsedLine { [INFO] [stderr] 12 | speech: None, [INFO] [stderr] 13 | action: None, [INFO] [stderr] 14 | label: None, [INFO] [stderr] 15 | choice: None, [INFO] [stderr] 16 | regular: Some(regular_line) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return BufReader::new(bill_file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BufReader::new(bill_file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/mod.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | return processed_lines; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `processed_lines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/mod.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return Some(line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/action/direction.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/action/branching.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/action/fx.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/action/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return command_lines; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `command_lines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/punctuation.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return formatted; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `formatted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/punctuation.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return formatted.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `formatted.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/punctuation.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return formatted.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `formatted.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/style.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return bolded.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bolded.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/style.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return emphasized.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `emphasized.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/style.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return upsized.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `upsized.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/style.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return downsized.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `downsized.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/speed.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return accelerated.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `accelerated.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/speed.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return decelerated.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decelerated.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/language.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return accelerated.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `accelerated.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/language.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return accelerated.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `accelerated.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/mod.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return renpy_line; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `renpy_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/renpy/write/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/write/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return output_file; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/write/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return indentation; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `indentation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/renpy/write/mod.rs:62:23 [INFO] [stderr] | [INFO] [stderr] 62 | for _index in (0..20) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `entity::line::LineSpeech` [INFO] [stderr] --> src/renpy/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use entity::line::LineSpeech; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/mod.rs:37:2 [INFO] [stderr] | [INFO] [stderr] 37 | return flattened_vector; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `flattened_vector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/mod.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/mod.rs:102:2 [INFO] [stderr] | [INFO] [stderr] 102 | return processed_lines; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `processed_lines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return env::args().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `env::args().collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return processed_files; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `processed_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/utility.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | return string.chars().skip(1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.chars().skip(1).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/utility.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return string.chars().take(length - 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.chars().take(length - 1).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/command.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return line; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/label.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return line; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/label.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return LineLabelType::GLOBAL; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LineLabelType::GLOBAL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/label.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return LineLabelType::LOCAL; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LineLabelType::LOCAL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/label.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / return match first_char_opt { [INFO] [stderr] 57 | | Some(first_char) => if first_char == '>' { return true } else { false }, [INFO] [stderr] 58 | | None => false [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | match first_char_opt { [INFO] [stderr] 57 | Some(first_char) => if first_char == '>' { return true } else { false }, [INFO] [stderr] 58 | None => false [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/label.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / return if last_char == ':' { [INFO] [stderr] 70 | | strip_last_char(label_id) [INFO] [stderr] 71 | | } else { [INFO] [stderr] 72 | | label_id.to_owned() [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 69 | if last_char == ':' { [INFO] [stderr] 70 | strip_last_char(label_id) [INFO] [stderr] 71 | } else { [INFO] [stderr] 72 | label_id.to_owned() [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/speech.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / return ParsedLine { [INFO] [stderr] 14 | | speech: Some(new_speech), [INFO] [stderr] 15 | | action: None, [INFO] [stderr] 16 | | label: None, [INFO] [stderr] 17 | | choice: None, [INFO] [stderr] 18 | | regular: None [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | ParsedLine { [INFO] [stderr] 14 | speech: Some(new_speech), [INFO] [stderr] 15 | action: None, [INFO] [stderr] 16 | label: None, [INFO] [stderr] 17 | choice: None, [INFO] [stderr] 18 | regular: None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/choice.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return line; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/regular.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / return ParsedLine { [INFO] [stderr] 12 | | speech: None, [INFO] [stderr] 13 | | action: None, [INFO] [stderr] 14 | | label: None, [INFO] [stderr] 15 | | choice: None, [INFO] [stderr] 16 | | regular: Some(regular_line) [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 11 | ParsedLine { [INFO] [stderr] 12 | speech: None, [INFO] [stderr] 13 | action: None, [INFO] [stderr] 14 | label: None, [INFO] [stderr] 15 | choice: None, [INFO] [stderr] 16 | regular: Some(regular_line) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return BufReader::new(bill_file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BufReader::new(bill_file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/mod.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | return processed_lines; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `processed_lines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/line_parser/mod.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return Some(line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/action/direction.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/action/branching.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/action/fx.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/action/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return command_lines; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `command_lines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/punctuation.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return formatted; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `formatted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/punctuation.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return formatted.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `formatted.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/punctuation.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return formatted.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `formatted.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/style.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return bolded.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bolded.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/style.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return emphasized.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `emphasized.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/style.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return upsized.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `upsized.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/style.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return downsized.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `downsized.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/speed.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return accelerated.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `accelerated.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/speed.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return decelerated.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decelerated.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/language.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return accelerated.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `accelerated.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/language.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return accelerated.into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `accelerated.into_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/speech/mod.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return renpy_line; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `renpy_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/renpy/write/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/write/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return output_file; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/write/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return indentation; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `indentation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `entity::line::LineSpeech` [INFO] [stderr] --> src/renpy/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use entity::line::LineSpeech; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/mod.rs:37:2 [INFO] [stderr] | [INFO] [stderr] 37 | return flattened_vector; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `flattened_vector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/mod.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/renpy/mod.rs:102:2 [INFO] [stderr] | [INFO] [stderr] 102 | return processed_lines; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `processed_lines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `arguments` [INFO] [stderr] --> src/renpy/action/direction.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn process_exeunt_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_arguments` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `current_indentation` [INFO] [stderr] --> src/renpy/action/direction.rs:27:56 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn process_exeunt_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_current_indentation` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `arguments` [INFO] [stderr] --> src/renpy/action/fx.rs:3:29 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_play_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_arguments` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `current_indentation` [INFO] [stderr] --> src/renpy/action/fx.rs:3:54 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_play_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_current_indentation` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `renpy_lines` [INFO] [stderr] --> src/main.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | let renpy_lines = renpy::translate(bill_lines); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_renpy_lines` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/line_parser/choice.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let mut cleaned_first = strip_first_char(command_string); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_output_file` [INFO] [stderr] --> src/renpy/write/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn get_output_file(file_name: &str) -> File { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `translate_renpy_line_to_string` [INFO] [stderr] --> src/renpy/write/mod.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn translate_renpy_line_to_string(renpy_line: &RenpyLine) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `generate_indentation` [INFO] [stderr] --> src/renpy/write/mod.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | fn generate_indentation(n: u32) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_to_file` [INFO] [stderr] --> src/renpy/mod.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn write_to_file(file_name: &str, renpy_lines: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `arguments` [INFO] [stderr] --> src/renpy/action/direction.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn process_exeunt_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_arguments` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `current_indentation` [INFO] [stderr] --> src/renpy/action/direction.rs:27:56 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn process_exeunt_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_current_indentation` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `arguments` [INFO] [stderr] --> src/renpy/action/fx.rs:3:29 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_play_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_arguments` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `current_indentation` [INFO] [stderr] --> src/renpy/action/fx.rs:3:54 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_play_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_current_indentation` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `renpy_lines` [INFO] [stderr] --> src/main.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | let renpy_lines = renpy::translate(bill_lines); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_renpy_lines` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/line_parser/mod.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / match current_line_opt { [INFO] [stderr] 45 | | Some(current_line) => { [INFO] [stderr] 46 | | processed_lines.push(current_line); [INFO] [stderr] 47 | | }, [INFO] [stderr] 48 | | None => (), [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(current_line) = current_line_opt { [INFO] [stderr] 45 | processed_lines.push(current_line); [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/line_parser/mod.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | let second_char_result = line_string.chars().skip(1).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/renpy/label.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | let access_modifier = match access { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 11 | | &LineLabelType::LOCAL => ".", [INFO] [stderr] 12 | | _ => "" [INFO] [stderr] 13 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | let access_modifier = match *access { [INFO] [stderr] 11 | LineLabelType::LOCAL => ".", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/direction.rs:3:40 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_hide_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renpy/action/direction.rs:3:75 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_hide_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/direction.rs:15:40 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn process_show_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renpy/action/direction.rs:15:75 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn process_show_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/direction.rs:27:42 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn process_exeunt_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renpy/action/direction.rs:27:77 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn process_exeunt_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/branching.rs:21:38 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn process_if_command(arguments: &Vec, current_indentation: &mut u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/branching.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn process_else_command(arguments: &Vec, current_indentation: &mut u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/fx.rs:3:40 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_play_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renpy/action/fx.rs:3:75 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_play_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/renpy/utility.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | *current_indentation = *current_indentation - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*current_indentation -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/renpy/utility.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | *current_indentation = *current_indentation + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*current_indentation += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/line_parser/choice.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let mut cleaned_first = strip_first_char(command_string); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renpy/speech/mod.rs:27:85 [INFO] [stderr] | [INFO] [stderr] 27 | fn generate_speech_renpy_line(speaker: &str, input_line: &str, current_indentation: &u32) -> RenpyLine { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/mod.rs:41:52 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn write_to_file(file_name: &str, renpy_lines: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[RenpyLine]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_output_file` [INFO] [stderr] --> src/renpy/write/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn get_output_file(file_name: &str) -> File { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_to_file` [INFO] [stderr] --> src/renpy/mod.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn write_to_file(file_name: &str, renpy_lines: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/line_parser/mod.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / match current_line_opt { [INFO] [stderr] 45 | | Some(current_line) => { [INFO] [stderr] 46 | | processed_lines.push(current_line); [INFO] [stderr] 47 | | }, [INFO] [stderr] 48 | | None => (), [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(current_line) = current_line_opt { [INFO] [stderr] 45 | processed_lines.push(current_line); [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/line_parser/mod.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | let second_char_result = line_string.chars().skip(1).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/renpy/label.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | let access_modifier = match access { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 11 | | &LineLabelType::LOCAL => ".", [INFO] [stderr] 12 | | _ => "" [INFO] [stderr] 13 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | let access_modifier = match *access { [INFO] [stderr] 11 | LineLabelType::LOCAL => ".", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/direction.rs:3:40 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_hide_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renpy/action/direction.rs:3:75 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_hide_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/direction.rs:15:40 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn process_show_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renpy/action/direction.rs:15:75 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn process_show_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/direction.rs:27:42 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn process_exeunt_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renpy/action/direction.rs:27:77 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn process_exeunt_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/branching.rs:21:38 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn process_if_command(arguments: &Vec, current_indentation: &mut u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/branching.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn process_else_command(arguments: &Vec, current_indentation: &mut u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/action/fx.rs:3:40 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_play_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renpy/action/fx.rs:3:75 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn process_play_command(arguments: &Vec, current_indentation: &u32) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/renpy/utility.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | *current_indentation = *current_indentation - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*current_indentation -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/renpy/utility.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | *current_indentation = *current_indentation + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*current_indentation += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renpy/speech/mod.rs:27:85 [INFO] [stderr] | [INFO] [stderr] 27 | fn generate_speech_renpy_line(speaker: &str, input_line: &str, current_indentation: &u32) -> RenpyLine { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/renpy/mod.rs:41:52 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn write_to_file(file_name: &str, renpy_lines: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[RenpyLine]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.90s [INFO] running `"docker" "inspect" "44dbca3e31737eb55d2eba907bf5c0ecfc7d37a0f54f4da45909b15882421f83"` [INFO] running `"docker" "rm" "-f" "44dbca3e31737eb55d2eba907bf5c0ecfc7d37a0f54f4da45909b15882421f83"` [INFO] [stdout] 44dbca3e31737eb55d2eba907bf5c0ecfc7d37a0f54f4da45909b15882421f83