[INFO] updating cached repository ericdke/NatoPhone-Rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ericdke/NatoPhone-Rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ericdke/NatoPhone-Rust" "work/ex/clippy-test-run/sources/stable/gh/ericdke/NatoPhone-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ericdke/NatoPhone-Rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ericdke/NatoPhone-Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericdke/NatoPhone-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericdke/NatoPhone-Rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cf6b250b33905f02e600042c16ffaac1c12e011e [INFO] sha for GitHub repo ericdke/NatoPhone-Rust: cf6b250b33905f02e600042c16ffaac1c12e011e [INFO] validating manifest of ericdke/NatoPhone-Rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ericdke/NatoPhone-Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ericdke/NatoPhone-Rust [INFO] finished frobbing ericdke/NatoPhone-Rust [INFO] frobbed toml for ericdke/NatoPhone-Rust written to work/ex/clippy-test-run/sources/stable/gh/ericdke/NatoPhone-Rust/Cargo.toml [INFO] started frobbing ericdke/NatoPhone-Rust [INFO] finished frobbing ericdke/NatoPhone-Rust [INFO] frobbed toml for ericdke/NatoPhone-Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericdke/NatoPhone-Rust/Cargo.toml [INFO] crate ericdke/NatoPhone-Rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ericdke/NatoPhone-Rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ericdke/NatoPhone-Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6f82265cdb2c7f314c091749ea584fe25ac0655c168938995d4fa12f69c81cfb [INFO] running `"docker" "start" "-a" "6f82265cdb2c7f314c091749ea584fe25ac0655c168938995d4fa12f69c81cfb"` [INFO] [stderr] Checking docopt v0.6.86 [INFO] [stderr] Checking nato v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in words.enumerate()` or similar iterators [INFO] [stderr] --> src/encode.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | for word in words { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encode.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | let ref chs: Vec<&str> = low.split("").collect(); [INFO] [stderr] | ----^^^^^^^-------------------------------------- help: try: `let chs: &Vec<&str> = &low.split("").collect();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in words.enumerate()` or similar iterators [INFO] [stderr] --> src/encode.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | for word in words { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encode.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | let ref chs: Vec<&str> = low.split("").collect(); [INFO] [stderr] | ----^^^^^^^-------------------------------------- help: try: `let chs: &Vec<&str> = &low.split("").collect();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.14s [INFO] running `"docker" "inspect" "6f82265cdb2c7f314c091749ea584fe25ac0655c168938995d4fa12f69c81cfb"` [INFO] running `"docker" "rm" "-f" "6f82265cdb2c7f314c091749ea584fe25ac0655c168938995d4fa12f69c81cfb"` [INFO] [stdout] 6f82265cdb2c7f314c091749ea584fe25ac0655c168938995d4fa12f69c81cfb