[INFO] updating cached repository ericdaat/rust-iron-gcd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ericdaat/rust-iron-gcd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ericdaat/rust-iron-gcd" "work/ex/clippy-test-run/sources/stable/gh/ericdaat/rust-iron-gcd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ericdaat/rust-iron-gcd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ericdaat/rust-iron-gcd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericdaat/rust-iron-gcd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericdaat/rust-iron-gcd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 89e396535cf239e6eb46f826b81dc782de8770b8 [INFO] sha for GitHub repo ericdaat/rust-iron-gcd: 89e396535cf239e6eb46f826b81dc782de8770b8 [INFO] validating manifest of ericdaat/rust-iron-gcd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ericdaat/rust-iron-gcd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ericdaat/rust-iron-gcd [INFO] finished frobbing ericdaat/rust-iron-gcd [INFO] frobbed toml for ericdaat/rust-iron-gcd written to work/ex/clippy-test-run/sources/stable/gh/ericdaat/rust-iron-gcd/Cargo.toml [INFO] started frobbing ericdaat/rust-iron-gcd [INFO] finished frobbing ericdaat/rust-iron-gcd [INFO] frobbed toml for ericdaat/rust-iron-gcd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericdaat/rust-iron-gcd/Cargo.toml [INFO] crate ericdaat/rust-iron-gcd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ericdaat/rust-iron-gcd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ericdaat/rust-iron-gcd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35da26c5de4dd97c685dc9cdd0951a4392cf5ae9577b7a03e9c606219b8f554b [INFO] running `"docker" "start" "-a" "35da26c5de4dd97c685dc9cdd0951a4392cf5ae9577b7a03e9c606219b8f554b"` [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking persistent v0.3.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking bodyparser v0.5.0 [INFO] [stderr] Checking urlencoded v0.5.0 [INFO] [stderr] Checking iron-gcd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this looks like you are swapping `m` and `n` manually [INFO] [stderr] --> src/main.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / let t = m; [INFO] [stderr] 27 | | m = n; [INFO] [stderr] 28 | | n = t; [INFO] [stderr] | |_________________^ help: try: `std::mem::swap(&mut m, &mut n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | m = m % n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `m %= n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | response.set_mut(format!("form data has no 'n' parameter\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"form data has no 'n' parameter\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `m` and `n` manually [INFO] [stderr] --> src/main.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / let t = m; [INFO] [stderr] 27 | | m = n; [INFO] [stderr] 28 | | n = t; [INFO] [stderr] | |_________________^ help: try: `std::mem::swap(&mut m, &mut n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | m = m % n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `m %= n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | response.set_mut(format!("form data has no 'n' parameter\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"form data has no 'n' parameter\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.45s [INFO] running `"docker" "inspect" "35da26c5de4dd97c685dc9cdd0951a4392cf5ae9577b7a03e9c606219b8f554b"` [INFO] running `"docker" "rm" "-f" "35da26c5de4dd97c685dc9cdd0951a4392cf5ae9577b7a03e9c606219b8f554b"` [INFO] [stdout] 35da26c5de4dd97c685dc9cdd0951a4392cf5ae9577b7a03e9c606219b8f554b