[INFO] updating cached repository ericawright/the-queue [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ericawright/the-queue [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ericawright/the-queue" "work/ex/clippy-test-run/sources/stable/gh/ericawright/the-queue"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ericawright/the-queue'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ericawright/the-queue" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericawright/the-queue"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericawright/the-queue'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5cb1ae30a5ba91f9b6c89386b4073768362c1bbf [INFO] sha for GitHub repo ericawright/the-queue: 5cb1ae30a5ba91f9b6c89386b4073768362c1bbf [INFO] validating manifest of ericawright/the-queue on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ericawright/the-queue on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ericawright/the-queue [INFO] finished frobbing ericawright/the-queue [INFO] frobbed toml for ericawright/the-queue written to work/ex/clippy-test-run/sources/stable/gh/ericawright/the-queue/Cargo.toml [INFO] started frobbing ericawright/the-queue [INFO] finished frobbing ericawright/the-queue [INFO] frobbed toml for ericawright/the-queue written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericawright/the-queue/Cargo.toml [INFO] crate ericawright/the-queue has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ericawright/the-queue against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ericawright/the-queue:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 300f2413beda888d39a752b1f43433957bf44e112d5a2600b5cc72e300e9a2c3 [INFO] running `"docker" "start" "-a" "300f2413beda888d39a752b1f43433957bf44e112d5a2600b5cc72e300e9a2c3"` [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking buf_redux v0.6.3 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking serde_json v1.0.27 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Checking gzip-header v0.1.2 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking router v0.6.0 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking postgres-shared v0.4.2 [INFO] [stderr] Checking tiny_http v0.6.0 [INFO] [stderr] Checking diesel v1.3.3 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking rouille v2.2.0 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking the-queue v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | pub content: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models.rs:36:19 [INFO] [stderr] | [INFO] [stderr] 36 | pub position: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | pub name: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | pub assigned_to: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | pub date_finished: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:40:55 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn change_project_status(conn: &PgConnection, id: &i32, body: &EditProjectForm) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:44:10 [INFO] [stderr] | [INFO] [stderr] 44 | .expect(&format!("Unable to find project {}", id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to find project {}", id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | pub content: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models.rs:36:19 [INFO] [stderr] | [INFO] [stderr] 36 | pub position: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | pub name: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | pub assigned_to: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | pub date_finished: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:40:55 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn change_project_status(conn: &PgConnection, id: &i32, body: &EditProjectForm) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:44:10 [INFO] [stderr] | [INFO] [stderr] 44 | .expect(&format!("Unable to find project {}", id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to find project {}", id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 20s [INFO] running `"docker" "inspect" "300f2413beda888d39a752b1f43433957bf44e112d5a2600b5cc72e300e9a2c3"` [INFO] running `"docker" "rm" "-f" "300f2413beda888d39a752b1f43433957bf44e112d5a2600b5cc72e300e9a2c3"` [INFO] [stdout] 300f2413beda888d39a752b1f43433957bf44e112d5a2600b5cc72e300e9a2c3