[INFO] updating cached repository eric1221bday/minesweep-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/eric1221bday/minesweep-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/eric1221bday/minesweep-rs" "work/ex/clippy-test-run/sources/stable/gh/eric1221bday/minesweep-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eric1221bday/minesweep-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/eric1221bday/minesweep-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eric1221bday/minesweep-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eric1221bday/minesweep-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b09909099a5e201c2db6bd0fc4398e85844128ed
[INFO] sha for GitHub repo eric1221bday/minesweep-rs: b09909099a5e201c2db6bd0fc4398e85844128ed
[INFO] validating manifest of eric1221bday/minesweep-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of eric1221bday/minesweep-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing eric1221bday/minesweep-rs
[INFO] finished frobbing eric1221bday/minesweep-rs
[INFO] frobbed toml for eric1221bday/minesweep-rs written to work/ex/clippy-test-run/sources/stable/gh/eric1221bday/minesweep-rs/Cargo.toml
[INFO] started frobbing eric1221bday/minesweep-rs
[INFO] finished frobbing eric1221bday/minesweep-rs
[INFO] frobbed toml for eric1221bday/minesweep-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eric1221bday/minesweep-rs/Cargo.toml
[INFO] crate eric1221bday/minesweep-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting eric1221bday/minesweep-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eric1221bday/minesweep-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ec939a3928cf4339bc2994e5105144db38b327ccf2edb1b61f1ec9f34eae9ce0
[INFO] running `"docker" "start" "-a" "ec939a3928cf4339bc2994e5105144db38b327ccf2edb1b61f1ec9f34eae9ce0"`
[INFO] [stderr]     Checking crossbeam-epoch v0.3.1
[INFO] [stderr]    Compiling serde_derive v1.0.59
[INFO] [stderr]    Compiling num-derive v0.2.2
[INFO] [stderr]    Compiling glutin v0.14.0
[INFO] [stderr]     Checking winit v0.12.0
[INFO] [stderr]     Checking crossbeam-deque v0.2.0
[INFO] [stderr]     Checking rayon-core v1.4.0
[INFO] [stderr]     Checking rayon v1.0.1
[INFO] [stderr]     Checking jpeg-decoder v0.1.14
[INFO] [stderr]     Checking image v0.19.0
[INFO] [stderr]     Checking pistoncore-input v0.20.0
[INFO] [stderr]     Checking pistoncore-window v0.31.0
[INFO] [stderr]     Checking piston-gfx_texture v0.32.0
[INFO] [stderr]     Checking pistoncore-event_loop v0.36.0
[INFO] [stderr]     Checking pistoncore-glutin_window v0.46.0
[INFO] [stderr]     Checking piston v0.36.0
[INFO] [stderr]     Checking piston2d-gfx_graphics v0.51.0
[INFO] [stderr]     Checking piston_window v0.79.0
[INFO] [stderr]     Checking minesweep-rs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/frontend.rs:119:17
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 return self.handle_mouse_click_position(MouseButton::Middle, curr_pos),
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.handle_mouse_click_position(MouseButton::Middle, curr_pos)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/frontend.rs:121:17
[INFO] [stderr]     |
[INFO] [stderr] 121 |                 return self.handle_mouse_click_position(MouseButton::Middle, curr_pos),
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.handle_mouse_click_position(MouseButton::Middle, curr_pos)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/frontend.rs:119:17
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 return self.handle_mouse_click_position(MouseButton::Middle, curr_pos),
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.handle_mouse_click_position(MouseButton::Middle, curr_pos)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/frontend.rs:121:17
[INFO] [stderr]     |
[INFO] [stderr] 121 |                 return self.handle_mouse_click_position(MouseButton::Middle, curr_pos),
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.handle_mouse_click_position(MouseButton::Middle, curr_pos)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/frontend.rs:116:78
[INFO] [stderr]     |
[INFO] [stderr] 116 |     fn handle_mouse_click_position(&mut self, button: MouseButton, curr_pos: &Position) {
[INFO] [stderr]     |                                                                              ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/game/mod.rs:170:38
[INFO] [stderr]     |
[INFO] [stderr] 170 |     fn get_neighbor_coords(curr_pos: &Position, cols: u32, rows: u32) -> HashSet<Position> {
[INFO] [stderr]     |                                      ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/game/mod.rs:241:52
[INFO] [stderr]     |
[INFO] [stderr] 241 |     pub fn toggle_flag_square(&mut self, curr_pos: &Position) {
[INFO] [stderr]     |                                                    ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/game/mod.rs:258:38
[INFO] [stderr]     |
[INFO] [stderr] 258 |     fn find_reveals(&self, curr_pos: &Position) -> HashSet<Position> {
[INFO] [stderr]     |                                      ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/game/mod.rs:294:47
[INFO] [stderr]     |
[INFO] [stderr] 294 |     pub fn reveal_square(&mut self, curr_pos: &Position) {
[INFO] [stderr]     |                                               ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/game/mod.rs:320:53
[INFO] [stderr]     |
[INFO] [stderr] 320 |     pub fn try_reveal_adjacent(&mut self, curr_pos: &Position) {
[INFO] [stderr]     |                                                     ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/game/mod.rs:324:22
[INFO] [stderr]     |
[INFO] [stderr] 324 |         let square = self.map[curr_pos].clone();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.map[curr_pos]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/main.rs:116:16
[INFO] [stderr]     |
[INFO] [stderr] 116 |           if let Some(_) = e.render_args() {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 117 | |             front.draw(&mut window, &e, &mut glyphs, &icons);
[INFO] [stderr] 118 | |         }
[INFO] [stderr]     | |_________- help: try this: `if e.render_args().is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 | /             match button {
[INFO] [stderr] 134 | |                 Button::Mouse(m) => front.handle_mouse_click(m),
[INFO] [stderr] 135 | |                 _ => (),
[INFO] [stderr] 136 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Button::Mouse(m) = button { front.handle_mouse_click(m) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/frontend.rs:116:78
[INFO] [stderr]     |
[INFO] [stderr] 116 |     fn handle_mouse_click_position(&mut self, button: MouseButton, curr_pos: &Position) {
[INFO] [stderr]     |                                                                              ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/game/mod.rs:170:38
[INFO] [stderr]     |
[INFO] [stderr] 170 |     fn get_neighbor_coords(curr_pos: &Position, cols: u32, rows: u32) -> HashSet<Position> {
[INFO] [stderr]     |                                      ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/game/mod.rs:241:52
[INFO] [stderr]     |
[INFO] [stderr] 241 |     pub fn toggle_flag_square(&mut self, curr_pos: &Position) {
[INFO] [stderr]     |                                                    ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/game/mod.rs:258:38
[INFO] [stderr]     |
[INFO] [stderr] 258 |     fn find_reveals(&self, curr_pos: &Position) -> HashSet<Position> {
[INFO] [stderr]     |                                      ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/game/mod.rs:294:47
[INFO] [stderr]     |
[INFO] [stderr] 294 |     pub fn reveal_square(&mut self, curr_pos: &Position) {
[INFO] [stderr]     |                                               ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/game/mod.rs:320:53
[INFO] [stderr]     |
[INFO] [stderr] 320 |     pub fn try_reveal_adjacent(&mut self, curr_pos: &Position) {
[INFO] [stderr]     |                                                     ^^^^^^^^^ help: consider passing by value instead: `Position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/game/mod.rs:324:22
[INFO] [stderr]     |
[INFO] [stderr] 324 |         let square = self.map[curr_pos].clone();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.map[curr_pos]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/main.rs:116:16
[INFO] [stderr]     |
[INFO] [stderr] 116 |           if let Some(_) = e.render_args() {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 117 | |             front.draw(&mut window, &e, &mut glyphs, &icons);
[INFO] [stderr] 118 | |         }
[INFO] [stderr]     | |_________- help: try this: `if e.render_args().is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 | /             match button {
[INFO] [stderr] 134 | |                 Button::Mouse(m) => front.handle_mouse_click(m),
[INFO] [stderr] 135 | |                 _ => (),
[INFO] [stderr] 136 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Button::Mouse(m) = button { front.handle_mouse_click(m) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 53.26s
[INFO] running `"docker" "inspect" "ec939a3928cf4339bc2994e5105144db38b327ccf2edb1b61f1ec9f34eae9ce0"`
[INFO] running `"docker" "rm" "-f" "ec939a3928cf4339bc2994e5105144db38b327ccf2edb1b61f1ec9f34eae9ce0"`
[INFO] [stdout] ec939a3928cf4339bc2994e5105144db38b327ccf2edb1b61f1ec9f34eae9ce0