[INFO] updating cached repository erfanelahi/rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/erfanelahi/rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/erfanelahi/rust" "work/ex/clippy-test-run/sources/stable/gh/erfanelahi/rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/erfanelahi/rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/erfanelahi/rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erfanelahi/rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erfanelahi/rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3c6149f1705cdc05e246c66a65b70396cb5927aa [INFO] sha for GitHub repo erfanelahi/rust: 3c6149f1705cdc05e246c66a65b70396cb5927aa [INFO] validating manifest of erfanelahi/rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of erfanelahi/rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing erfanelahi/rust [INFO] finished frobbing erfanelahi/rust [INFO] frobbed toml for erfanelahi/rust written to work/ex/clippy-test-run/sources/stable/gh/erfanelahi/rust/Cargo.toml [INFO] started frobbing erfanelahi/rust [INFO] finished frobbing erfanelahi/rust [INFO] frobbed toml for erfanelahi/rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/erfanelahi/rust/Cargo.toml [INFO] crate erfanelahi/rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting erfanelahi/rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/erfanelahi/rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3d1d8c6268f965e3b9fdbcc63ef89198536b414e18efe16ff410d09d453d6f2c [INFO] running `"docker" "start" "-a" "3d1d8c6268f965e3b9fdbcc63ef89198536b414e18efe16ff410d09d453d6f2c"` [INFO] [stderr] Checking rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `f` [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let f = match f { [INFO] [stderr] | ^ help: consider using `_f` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / match g { [INFO] [stderr] 73 | | Some(v) => println!("{}", v), [INFO] [stderr] 74 | | None => (), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(v) = g { println!("{}", v) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:85:31 [INFO] [stderr] | [INFO] [stderr] 85 | fn borrowed_as_read_only(s3 : &String){ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/main.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | #[derive(Debug)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/main.rs:103:14 [INFO] [stderr] | [INFO] [stderr] 103 | for i in 0..a.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 103 | for in &a { [INFO] [stderr] | ^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f` [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let f = match f { [INFO] [stderr] | ^ help: consider using `_f` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / match g { [INFO] [stderr] 73 | | Some(v) => println!("{}", v), [INFO] [stderr] 74 | | None => (), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(v) = g { println!("{}", v) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:85:31 [INFO] [stderr] | [INFO] [stderr] 85 | fn borrowed_as_read_only(s3 : &String){ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/main.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | #[derive(Debug)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/main.rs:103:14 [INFO] [stderr] | [INFO] [stderr] 103 | for i in 0..a.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 103 | for in &a { [INFO] [stderr] | ^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.41s [INFO] running `"docker" "inspect" "3d1d8c6268f965e3b9fdbcc63ef89198536b414e18efe16ff410d09d453d6f2c"` [INFO] running `"docker" "rm" "-f" "3d1d8c6268f965e3b9fdbcc63ef89198536b414e18efe16ff410d09d453d6f2c"` [INFO] [stdout] 3d1d8c6268f965e3b9fdbcc63ef89198536b414e18efe16ff410d09d453d6f2c