[INFO] updating cached repository equalsraf/git-springclean [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/equalsraf/git-springclean [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/equalsraf/git-springclean" "work/ex/clippy-test-run/sources/stable/gh/equalsraf/git-springclean"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/equalsraf/git-springclean'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/equalsraf/git-springclean" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/equalsraf/git-springclean"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/equalsraf/git-springclean'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fcaed730df784ddf69d4260893abdcc6c3c51eb4 [INFO] sha for GitHub repo equalsraf/git-springclean: fcaed730df784ddf69d4260893abdcc6c3c51eb4 [INFO] validating manifest of equalsraf/git-springclean on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of equalsraf/git-springclean on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing equalsraf/git-springclean [INFO] finished frobbing equalsraf/git-springclean [INFO] frobbed toml for equalsraf/git-springclean written to work/ex/clippy-test-run/sources/stable/gh/equalsraf/git-springclean/Cargo.toml [INFO] started frobbing equalsraf/git-springclean [INFO] finished frobbing equalsraf/git-springclean [INFO] frobbed toml for equalsraf/git-springclean written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/equalsraf/git-springclean/Cargo.toml [INFO] crate equalsraf/git-springclean has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting equalsraf/git-springclean against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/equalsraf/git-springclean:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 41f60e511fbc1aa5e9be01cf7e82e08a9c6db318d9c51c2961d05d512a1572da [INFO] running `"docker" "start" "-a" "41f60e511fbc1aa5e9be01cf7e82e08a9c6db318d9c51c2961d05d512a1572da"` [INFO] [stderr] Checking git-springclean v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/checks.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | const GIT_TRIM: &'static [char] = &[' ','\r', '\t','*']; [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/checks.rs:124:24 [INFO] [stderr] | [INFO] [stderr] 124 | pub const ALL_CHECKS: &'static [&'static Fn(&Path, &Args) -> CheckResult] = &[ [INFO] [stderr] | -^^^^^^^------------------------------------------- help: consider removing `'static`: `&[&'static Fn(&Path, &Args) -> CheckResult]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/checks.rs:124:34 [INFO] [stderr] | [INFO] [stderr] 124 | pub const ALL_CHECKS: &'static [&'static Fn(&Path, &Args) -> CheckResult] = &[ [INFO] [stderr] | -^^^^^^^-------------------------------- help: consider removing `'static`: `&Fn(&Path, &Args) -> CheckResult` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/checks.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | const GIT_TRIM: &'static [char] = &[' ','\r', '\t','*']; [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/checks.rs:124:24 [INFO] [stderr] | [INFO] [stderr] 124 | pub const ALL_CHECKS: &'static [&'static Fn(&Path, &Args) -> CheckResult] = &[ [INFO] [stderr] | -^^^^^^^------------------------------------------- help: consider removing `'static`: `&[&'static Fn(&Path, &Args) -> CheckResult]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/checks.rs:124:34 [INFO] [stderr] | [INFO] [stderr] 124 | pub const ALL_CHECKS: &'static [&'static Fn(&Path, &Args) -> CheckResult] = &[ [INFO] [stderr] | -^^^^^^^-------------------------------- help: consider removing `'static`: `&Fn(&Path, &Args) -> CheckResult` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/checks.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn check_untracked_modified<'a>(p: &Path, args: &Args) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the variable `errn` is used as a loop counter. Consider using `for (errn, item) in errors.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:110:20 [INFO] [stderr] | [INFO] [stderr] 110 | for err in errors { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/checks.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn check_untracked_modified<'a>(p: &Path, args: &Args) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the variable `errn` is used as a loop counter. Consider using `for (errn, item) in errors.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:110:20 [INFO] [stderr] | [INFO] [stderr] 110 | for err in errors { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.77s [INFO] running `"docker" "inspect" "41f60e511fbc1aa5e9be01cf7e82e08a9c6db318d9c51c2961d05d512a1572da"` [INFO] running `"docker" "rm" "-f" "41f60e511fbc1aa5e9be01cf7e82e08a9c6db318d9c51c2961d05d512a1572da"` [INFO] [stdout] 41f60e511fbc1aa5e9be01cf7e82e08a9c6db318d9c51c2961d05d512a1572da