[INFO] updating cached repository epvpsyc/trafficsim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/epvpsyc/trafficsim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/epvpsyc/trafficsim" "work/ex/clippy-test-run/sources/stable/gh/epvpsyc/trafficsim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/epvpsyc/trafficsim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/epvpsyc/trafficsim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/epvpsyc/trafficsim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/epvpsyc/trafficsim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f55b526cf99ee497ec73709ab9994835b34fbbdc [INFO] sha for GitHub repo epvpsyc/trafficsim: f55b526cf99ee497ec73709ab9994835b34fbbdc [INFO] validating manifest of epvpsyc/trafficsim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of epvpsyc/trafficsim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing epvpsyc/trafficsim [INFO] finished frobbing epvpsyc/trafficsim [INFO] frobbed toml for epvpsyc/trafficsim written to work/ex/clippy-test-run/sources/stable/gh/epvpsyc/trafficsim/Cargo.toml [INFO] started frobbing epvpsyc/trafficsim [INFO] finished frobbing epvpsyc/trafficsim [INFO] frobbed toml for epvpsyc/trafficsim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/epvpsyc/trafficsim/Cargo.toml [INFO] crate epvpsyc/trafficsim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting epvpsyc/trafficsim against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/epvpsyc/trafficsim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d6a4a8120ce3fbf7b675d0207d6a9cf049845f38a1dfd3abd10f76e49ac98a53 [INFO] running `"docker" "start" "-a" "d6a4a8120ce3fbf7b675d0207d6a9cf049845f38a1dfd3abd10f76e49ac98a53"` [INFO] [stderr] Compiling wayland-scanner v0.21.7 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Checking wayland-sys v0.21.7 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking andrew v0.1.4 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Compiling wayland-client v0.21.7 [INFO] [stderr] Compiling wayland-protocols v0.21.7 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking wayland-commons v0.21.7 [INFO] [stderr] Checking piston2d-opengl_graphics v0.57.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.2 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking trafficsim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/app.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return cars; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `cars` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/app.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return cars; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `cars` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/app.rs:127:30 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/app.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | / let mut transform_car = c.transform.trans(x + 2.0, car.position_y); [INFO] [stderr] 116 | | [INFO] [stderr] 117 | | if car.direction == 0 { [INFO] [stderr] 118 | | transform_car = c.transform.trans(x - 22.0, car.position_y); [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let transform_car = if car.direction == 0 { c.transform.trans(x - 22.0, car.position_y) } else { c.transform.trans(x + 2.0, car.position_y) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:127:36 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/app.rs:127:30 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/app.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | / let mut transform_car = c.transform.trans(x + 2.0, car.position_y); [INFO] [stderr] 116 | | [INFO] [stderr] 117 | | if car.direction == 0 { [INFO] [stderr] 118 | | transform_car = c.transform.trans(x - 22.0, car.position_y); [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let transform_car = if car.direction == 0 { c.transform.trans(x - 22.0, car.position_y) } else { c.transform.trans(x + 2.0, car.position_y) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:127:36 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 48.61s [INFO] running `"docker" "inspect" "d6a4a8120ce3fbf7b675d0207d6a9cf049845f38a1dfd3abd10f76e49ac98a53"` [INFO] running `"docker" "rm" "-f" "d6a4a8120ce3fbf7b675d0207d6a9cf049845f38a1dfd3abd10f76e49ac98a53"` [INFO] [stdout] d6a4a8120ce3fbf7b675d0207d6a9cf049845f38a1dfd3abd10f76e49ac98a53