[INFO] updating cached repository eoinkelly/rgit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eoinkelly/rgit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eoinkelly/rgit" "work/ex/clippy-test-run/sources/stable/gh/eoinkelly/rgit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eoinkelly/rgit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eoinkelly/rgit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eoinkelly/rgit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eoinkelly/rgit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9d5c4aace5309d6e23e39be94f42a8e94cfb92e6 [INFO] sha for GitHub repo eoinkelly/rgit: 9d5c4aace5309d6e23e39be94f42a8e94cfb92e6 [INFO] validating manifest of eoinkelly/rgit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eoinkelly/rgit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eoinkelly/rgit [INFO] finished frobbing eoinkelly/rgit [INFO] frobbed toml for eoinkelly/rgit written to work/ex/clippy-test-run/sources/stable/gh/eoinkelly/rgit/Cargo.toml [INFO] started frobbing eoinkelly/rgit [INFO] finished frobbing eoinkelly/rgit [INFO] frobbed toml for eoinkelly/rgit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eoinkelly/rgit/Cargo.toml [INFO] crate eoinkelly/rgit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eoinkelly/rgit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eoinkelly/rgit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6f450c4efdbdeb809edae28193351c2fbf8999cc3cd1bd588a30900f17ec59ea [INFO] running `"docker" "start" "-a" "6f450c4efdbdeb809edae28193351c2fbf8999cc3cd1bd588a30900f17ec59ea"` [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking compress v0.1.2 [INFO] [stderr] Checking rgit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_sha.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | sha: sha, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sha` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_object_finder.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_object_finder.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_object_finder.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_sha.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | sha: sha, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sha` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_object_finder.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_object_finder.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_object_finder.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | const MISSING_SHA_ERROR: &'static str = "You must supply a SHA1 hash"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | const MISSING_SHA_ERROR: &'static str = "You must supply a SHA1 hash"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/git_object.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match self { [INFO] [stderr] 14 | | &GitObject::GitCommit { ref size, ref content } => { [INFO] [stderr] 15 | | output.push_str(&format!("\n Type: commit\n")); [INFO] [stderr] 16 | | output.push_str(&format!(" Size: {} bytes\n", size)); [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *self { [INFO] [stderr] 14 | GitObject::GitCommit { ref size, ref content } => { [INFO] [stderr] 15 | output.push_str(&format!("\n Type: commit\n")); [INFO] [stderr] 16 | output.push_str(&format!(" Size: {} bytes\n", size)); [INFO] [stderr] 17 | output.push_str(&format!(" Content:\n{}\n", present_content(&content))); [INFO] [stderr] 18 | write!(f, "{}", output) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/git_object.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | output.push_str(&format!("\n Type: commit\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\n Type: commit\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/git_object.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | output.push_str(&format!("\n Type: tree\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\n Type: tree\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/git_object.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | output.push_str(&format!("\n Type: blob\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\n Type: blob\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/git_object.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | fn present_content(content: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/git_object_finder.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | fn split_vec_on_byte(v: &Vec, byte: u8) -> (Vec, Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/git_object.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match self { [INFO] [stderr] 14 | | &GitObject::GitCommit { ref size, ref content } => { [INFO] [stderr] 15 | | output.push_str(&format!("\n Type: commit\n")); [INFO] [stderr] 16 | | output.push_str(&format!(" Size: {} bytes\n", size)); [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *self { [INFO] [stderr] 14 | GitObject::GitCommit { ref size, ref content } => { [INFO] [stderr] 15 | output.push_str(&format!("\n Type: commit\n")); [INFO] [stderr] 16 | output.push_str(&format!(" Size: {} bytes\n", size)); [INFO] [stderr] 17 | output.push_str(&format!(" Content:\n{}\n", present_content(&content))); [INFO] [stderr] 18 | write!(f, "{}", output) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/git_object.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | output.push_str(&format!("\n Type: commit\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\n Type: commit\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/git_object.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | output.push_str(&format!("\n Type: tree\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\n Type: tree\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/git_object.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | output.push_str(&format!("\n Type: blob\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\n Type: blob\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/git_object.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | fn present_content(content: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/git_object_finder.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | fn split_vec_on_byte(v: &Vec, byte: u8) -> (Vec, Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.67s [INFO] running `"docker" "inspect" "6f450c4efdbdeb809edae28193351c2fbf8999cc3cd1bd588a30900f17ec59ea"` [INFO] running `"docker" "rm" "-f" "6f450c4efdbdeb809edae28193351c2fbf8999cc3cd1bd588a30900f17ec59ea"` [INFO] [stdout] 6f450c4efdbdeb809edae28193351c2fbf8999cc3cd1bd588a30900f17ec59ea