[INFO] updating cached repository engineeringvirtue/bottled-discord [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/engineeringvirtue/bottled-discord [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/engineeringvirtue/bottled-discord" "work/ex/clippy-test-run/sources/stable/gh/engineeringvirtue/bottled-discord"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/engineeringvirtue/bottled-discord'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/engineeringvirtue/bottled-discord" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/engineeringvirtue/bottled-discord"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/engineeringvirtue/bottled-discord'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0d1cb0c7a1d83ab8e6c3e4220035a33602ab4699 [INFO] sha for GitHub repo engineeringvirtue/bottled-discord: 0d1cb0c7a1d83ab8e6c3e4220035a33602ab4699 [INFO] validating manifest of engineeringvirtue/bottled-discord on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of engineeringvirtue/bottled-discord on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing engineeringvirtue/bottled-discord [INFO] finished frobbing engineeringvirtue/bottled-discord [INFO] frobbed toml for engineeringvirtue/bottled-discord written to work/ex/clippy-test-run/sources/stable/gh/engineeringvirtue/bottled-discord/Cargo.toml [INFO] started frobbing engineeringvirtue/bottled-discord [INFO] finished frobbing engineeringvirtue/bottled-discord [INFO] frobbed toml for engineeringvirtue/bottled-discord written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/engineeringvirtue/bottled-discord/Cargo.toml [INFO] crate engineeringvirtue/bottled-discord has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting engineeringvirtue/bottled-discord against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/engineeringvirtue/bottled-discord:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91c51c9770fd8aafabf7b3657051c673d7285b8ece95b59fcd209c62d22150b9 [INFO] running `"docker" "start" "-a" "91c51c9770fd8aafabf7b3657051c673d7285b8ece95b59fcd209c62d22150b9"` [INFO] [stderr] Compiling openssl v0.10.14 [INFO] [stderr] Compiling antidote v1.0.0 [INFO] [stderr] Checking kankyo v0.2.0 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Compiling curl-sys v0.4.13 [INFO] [stderr] Checking base64 v0.8.0 [INFO] [stderr] Compiling log v0.4.6 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Compiling pq-sys v0.4.6 [INFO] [stderr] Checking r2d2 v0.8.2 [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Compiling scheduled-thread-pool v0.2.0 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling native-tls v0.2.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Compiling uuid v0.6.5 [INFO] [stderr] Checking envy v0.3.2 [INFO] [stderr] Compiling pest_derive v1.0.8 [INFO] [stderr] Checking simple-logging v2.0.1 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling syn v0.15.12 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking diesel v1.3.3 [INFO] [stderr] Checking handlebars v1.0.5 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking cookie v0.5.1 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking evzht9h3nznqzwl v0.0.3 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking mime_guess v1.8.6 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking iron v0.6.0 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking curl v0.4.18 [INFO] [stderr] Checking persistent v0.4.0 [INFO] [stderr] Checking mount v0.4.0 [INFO] [stderr] Checking handlebars-iron v0.27.0 [INFO] [stderr] Checking router v0.6.0 [INFO] [stderr] Checking iron-sessionstorage-0-6 v0.6.6 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking bodyparser v0.8.0 [INFO] [stderr] Checking staticfile v0.5.0 [INFO] [stderr] Checking oauth2 v1.3.0 [INFO] [stderr] Checking serenity v0.5.9 [INFO] [stderr] Checking urlencoded v0.6.0 [INFO] [stderr] Checking params v0.8.0 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking discord_bots v1.0.0 [INFO] [stderr] Checking migrations_internals v1.3.0 [INFO] [stderr] Compiling migrations_macros v1.3.0 [INFO] [stderr] Checking diesel_migrations v1.3.0 [INFO] [stderr] Checking bottle v1.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/web.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/web.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/web.rs:154:82 [INFO] [stderr] | [INFO] [stderr] 154 | GuildContribution {guild: get_guild_name(c.guild), gid: c.guild, xp: c.xp as i64} [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(c.xp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/web.rs:194:77 [INFO] [stderr] | [INFO] [stderr] 194 | UserContribution {user: get_user_name(c.user), uid: c.user, xp: c.xp as i64} [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(c.xp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/web.rs:354:98 [INFO] [stderr] | [INFO] [stderr] 354 | .into_iter().map(|x| UserContribution {uid: x.id, user: get_user_name(x.id), xp: x.xp as i64}).collect(), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(x.xp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/bottle.rs:110:53 [INFO] [stderr] | [INFO] [stderr] 110 | let unrepeated: Vec<&(usize, Bottle)> = bottles.into_iter().take_while(|(_, x)| Some(x.id) != last_bottle).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/bottle.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / if let Some(mut msg) = ChannelId(rb.channel as u64).message(MessageId(rb.message as u64)).ok() { [INFO] [stderr] 165 | | let _ = msg.edit(|x| x.embed(|x| x.title( [INFO] [stderr] 166 | | format!("BOTTLE FROM {} IS DELETED", get_user_name(b.user))).description("This bottle has been deleted."))); [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut msg)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/web.rs:154:82 [INFO] [stderr] | [INFO] [stderr] 154 | GuildContribution {guild: get_guild_name(c.guild), gid: c.guild, xp: c.xp as i64} [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(c.xp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/web.rs:194:77 [INFO] [stderr] | [INFO] [stderr] 194 | UserContribution {user: get_user_name(c.user), uid: c.user, xp: c.xp as i64} [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(c.xp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/bottle.rs:362:9 [INFO] [stderr] | [INFO] [stderr] 362 | / if let Some(mut msg) = ChannelId(rb.channel as u64).message(MessageId(rb.message as u64)).ok() { [INFO] [stderr] 363 | | render_bottle(&bottle, Some(msg.id), bottles.len() - 1, in_reply, ChannelId(rb.channel as u64), cfg)?; [INFO] [stderr] 364 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut msg)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | let user = cache.read().user.id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `cache.read().user.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:335:13 [INFO] [stderr] | [INFO] [stderr] 335 | / match err { [INFO] [stderr] 336 | | DispatchError::LackOfPermissions(_) => { [INFO] [stderr] 337 | | let _ = msg.reply("You lack permission to do this! Please make sure you are an administrator."); [INFO] [stderr] 338 | | }, [INFO] [stderr] 339 | | _ => () [INFO] [stderr] 340 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 335 | if let DispatchError::LackOfPermissions(_) = err { [INFO] [stderr] 336 | let _ = msg.reply("You lack permission to do this! Please make sure you are an administrator."); [INFO] [stderr] 337 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/web.rs:354:98 [INFO] [stderr] | [INFO] [stderr] 354 | .into_iter().map(|x| UserContribution {uid: x.id, user: get_user_name(x.id), xp: x.xp as i64}).collect(), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(x.xp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/bottle.rs:110:53 [INFO] [stderr] | [INFO] [stderr] 110 | let unrepeated: Vec<&(usize, Bottle)> = bottles.into_iter().take_while(|(_, x)| Some(x.id) != last_bottle).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/bottle.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / if let Some(mut msg) = ChannelId(rb.channel as u64).message(MessageId(rb.message as u64)).ok() { [INFO] [stderr] 165 | | let _ = msg.edit(|x| x.embed(|x| x.title( [INFO] [stderr] 166 | | format!("BOTTLE FROM {} IS DELETED", get_user_name(b.user))).description("This bottle has been deleted."))); [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut msg)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/bottle.rs:362:9 [INFO] [stderr] | [INFO] [stderr] 362 | / if let Some(mut msg) = ChannelId(rb.channel as u64).message(MessageId(rb.message as u64)).ok() { [INFO] [stderr] 363 | | render_bottle(&bottle, Some(msg.id), bottles.len() - 1, in_reply, ChannelId(rb.channel as u64), cfg)?; [INFO] [stderr] 364 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut msg)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | let user = cache.read().user.id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `cache.read().user.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:335:13 [INFO] [stderr] | [INFO] [stderr] 335 | / match err { [INFO] [stderr] 336 | | DispatchError::LackOfPermissions(_) => { [INFO] [stderr] 337 | | let _ = msg.reply("You lack permission to do this! Please make sure you are an administrator."); [INFO] [stderr] 338 | | }, [INFO] [stderr] 339 | | _ => () [INFO] [stderr] 340 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 335 | if let DispatchError::LackOfPermissions(_) = err { [INFO] [stderr] 336 | let _ = msg.reply("You lack permission to do this! Please make sure you are an administrator."); [INFO] [stderr] 337 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 05s [INFO] running `"docker" "inspect" "91c51c9770fd8aafabf7b3657051c673d7285b8ece95b59fcd209c62d22150b9"` [INFO] running `"docker" "rm" "-f" "91c51c9770fd8aafabf7b3657051c673d7285b8ece95b59fcd209c62d22150b9"` [INFO] [stdout] 91c51c9770fd8aafabf7b3657051c673d7285b8ece95b59fcd209c62d22150b9