[INFO] updating cached repository engineeringvirtue/Nicky [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/engineeringvirtue/Nicky [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/engineeringvirtue/Nicky" "work/ex/clippy-test-run/sources/stable/gh/engineeringvirtue/Nicky"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/engineeringvirtue/Nicky'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/engineeringvirtue/Nicky" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/engineeringvirtue/Nicky"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/engineeringvirtue/Nicky'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 02d1966444abd82bd3d09ba6e040208c96f7ff42 [INFO] sha for GitHub repo engineeringvirtue/Nicky: 02d1966444abd82bd3d09ba6e040208c96f7ff42 [INFO] validating manifest of engineeringvirtue/Nicky on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of engineeringvirtue/Nicky on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing engineeringvirtue/Nicky [INFO] finished frobbing engineeringvirtue/Nicky [INFO] frobbed toml for engineeringvirtue/Nicky written to work/ex/clippy-test-run/sources/stable/gh/engineeringvirtue/Nicky/Cargo.toml [INFO] started frobbing engineeringvirtue/Nicky [INFO] finished frobbing engineeringvirtue/Nicky [INFO] frobbed toml for engineeringvirtue/Nicky written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/engineeringvirtue/Nicky/Cargo.toml [INFO] crate engineeringvirtue/Nicky has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting engineeringvirtue/Nicky against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/engineeringvirtue/Nicky:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be7bda97eb30da3fab1e2f221712fa077e34d8a6c9563ecc5a4e21e21ca5a55d [INFO] running `"docker" "start" "-a" "be7bda97eb30da3fab1e2f221712fa077e34d8a6c9563ecc5a4e21e21ca5a55d"` [INFO] [stderr] Checking kankyo v0.2.0 [INFO] [stderr] Checking base64 v0.8.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Checking flate2 v1.0.5 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking evzht9h3nznqzwl v0.0.3 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking rustbreak v2.0.0-rc3 [INFO] [stderr] Checking serenity v0.5.11 [INFO] [stderr] Checking nicky v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'serenity::model::channel::Channel::send_message': Use the inner channel's method [INFO] [stderr] --> src/main.rs:170:29 [INFO] [stderr] | [INFO] [stderr] 170 | let reply = channel.send_message(|x| x.content("Loading..."))?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'serenity::model::channel::Channel::edit_message': Use the inner channel's method [INFO] [stderr] --> src/main.rs:173:21 [INFO] [stderr] | [INFO] [stderr] 173 | channel.edit_message(reply.id, |x| x.content(new_stat)).is_err() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:113:79 [INFO] [stderr] | [INFO] [stderr] 113 | None => guild.member(self.0).ok().map(|x| vec![x]).unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:207:24 [INFO] [stderr] | [INFO] [stderr] 207 | if let Err(_) = x.edit(|e| e.nickname(&new_nick)) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 208 | | update_progress(&format!("Perhaps I don't have permission to rename **{}**?", &name)) [INFO] [stderr] 209 | | } else { [INFO] [stderr] 210 | | update_progress(&name) [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________________- help: try this: `if x.edit(|e| e.nickname(&new_nick)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'serenity::model::channel::Channel::send_message': Use the inner channel's method [INFO] [stderr] --> src/main.rs:170:29 [INFO] [stderr] | [INFO] [stderr] 170 | let reply = channel.send_message(|x| x.content("Loading..."))?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'serenity::model::channel::Channel::edit_message': Use the inner channel's method [INFO] [stderr] --> src/main.rs:173:21 [INFO] [stderr] | [INFO] [stderr] 173 | channel.edit_message(reply.id, |x| x.content(new_stat)).is_err() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:113:79 [INFO] [stderr] | [INFO] [stderr] 113 | None => guild.member(self.0).ok().map(|x| vec![x]).unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:207:24 [INFO] [stderr] | [INFO] [stderr] 207 | if let Err(_) = x.edit(|e| e.nickname(&new_nick)) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 208 | | update_progress(&format!("Perhaps I don't have permission to rename **{}**?", &name)) [INFO] [stderr] 209 | | } else { [INFO] [stderr] 210 | | update_progress(&name) [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________________- help: try this: `if x.edit(|e| e.nickname(&new_nick)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 57.44s [INFO] running `"docker" "inspect" "be7bda97eb30da3fab1e2f221712fa077e34d8a6c9563ecc5a4e21e21ca5a55d"` [INFO] running `"docker" "rm" "-f" "be7bda97eb30da3fab1e2f221712fa077e34d8a6c9563ecc5a4e21e21ca5a55d"` [INFO] [stdout] be7bda97eb30da3fab1e2f221712fa077e34d8a6c9563ecc5a4e21e21ca5a55d