[INFO] updating cached repository encabulators/nats-types [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/encabulators/nats-types [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/encabulators/nats-types" "work/ex/clippy-test-run/sources/stable/gh/encabulators/nats-types"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/encabulators/nats-types'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/encabulators/nats-types" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/encabulators/nats-types"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/encabulators/nats-types'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d2e32658c600429c9c7f77d8cd3adf4cb787619b [INFO] sha for GitHub repo encabulators/nats-types: d2e32658c600429c9c7f77d8cd3adf4cb787619b [INFO] validating manifest of encabulators/nats-types on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of encabulators/nats-types on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing encabulators/nats-types [INFO] finished frobbing encabulators/nats-types [INFO] frobbed toml for encabulators/nats-types written to work/ex/clippy-test-run/sources/stable/gh/encabulators/nats-types/Cargo.toml [INFO] started frobbing encabulators/nats-types [INFO] finished frobbing encabulators/nats-types [INFO] frobbed toml for encabulators/nats-types written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/encabulators/nats-types/Cargo.toml [INFO] crate encabulators/nats-types has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting encabulators/nats-types against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/encabulators/nats-types:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 297b1a7c3c09689f8afd8ba5b06a15960b026be4d9c2bc403b7ffff14f830ee4 [INFO] running `"docker" "start" "-a" "297b1a7c3c09689f8afd8ba5b06a15960b026be4d9c2bc403b7ffff14f830ee4"` [INFO] [stderr] Checking memchr v2.1.1 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking nats-types v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:403:21 [INFO] [stderr] | [INFO] [stderr] 403 | None => write!(f, "SUB {} {}\r\n", self.subject, self.subscription_id), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:404:28 [INFO] [stderr] | [INFO] [stderr] 404 | Some(ref q) => write!(f, "SUB {} {} {}\r\n", self.subject, q, self.subscription_id), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:403:21 [INFO] [stderr] | [INFO] [stderr] 403 | None => write!(f, "SUB {} {}\r\n", self.subject, self.subscription_id), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:404:28 [INFO] [stderr] | [INFO] [stderr] 404 | Some(ref q) => write!(f, "SUB {} {} {}\r\n", self.subject, q, self.subscription_id), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:681:42 [INFO] [stderr] | [INFO] [stderr] 681 | assert_eq!(info.max_payload, 1048576); [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/lib.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | / pub fn new( [INFO] [stderr] 172 | | verbose: bool, [INFO] [stderr] 173 | | pedantic: bool, [INFO] [stderr] 174 | | tls_required: bool, [INFO] [stderr] ... | [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | / pub fn new( [INFO] [stderr] 244 | | server_id: String, [INFO] [stderr] 245 | | version: String, [INFO] [stderr] 246 | | go: String, [INFO] [stderr] ... | [INFO] [stderr] 262 | | } [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:548:22 [INFO] [stderr] | [INFO] [stderr] 548 | fn vec_to_str(bytes: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/lib.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | / pub fn new( [INFO] [stderr] 172 | | verbose: bool, [INFO] [stderr] 173 | | pedantic: bool, [INFO] [stderr] 174 | | tls_required: bool, [INFO] [stderr] ... | [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | / pub fn new( [INFO] [stderr] 244 | | server_id: String, [INFO] [stderr] 245 | | version: String, [INFO] [stderr] 246 | | go: String, [INFO] [stderr] ... | [INFO] [stderr] 262 | | } [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:548:22 [INFO] [stderr] | [INFO] [stderr] 548 | fn vec_to_str(bytes: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.18s [INFO] running `"docker" "inspect" "297b1a7c3c09689f8afd8ba5b06a15960b026be4d9c2bc403b7ffff14f830ee4"` [INFO] running `"docker" "rm" "-f" "297b1a7c3c09689f8afd8ba5b06a15960b026be4d9c2bc403b7ffff14f830ee4"` [INFO] [stdout] 297b1a7c3c09689f8afd8ba5b06a15960b026be4d9c2bc403b7ffff14f830ee4