[INFO] updating cached repository emulead/reflect-server
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/emulead/reflect-server
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/emulead/reflect-server" "work/ex/clippy-test-run/sources/stable/gh/emulead/reflect-server"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/emulead/reflect-server'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/emulead/reflect-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emulead/reflect-server"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emulead/reflect-server'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a4f6943c5d228027c9cd172efbb3cf2edcf13e8e
[INFO] sha for GitHub repo emulead/reflect-server: a4f6943c5d228027c9cd172efbb3cf2edcf13e8e
[INFO] validating manifest of emulead/reflect-server on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of emulead/reflect-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing emulead/reflect-server
[INFO] finished frobbing emulead/reflect-server
[INFO] frobbed toml for emulead/reflect-server written to work/ex/clippy-test-run/sources/stable/gh/emulead/reflect-server/Cargo.toml
[INFO] started frobbing emulead/reflect-server
[INFO] finished frobbing emulead/reflect-server
[INFO] frobbed toml for emulead/reflect-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emulead/reflect-server/Cargo.toml
[INFO] crate emulead/reflect-server has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting emulead/reflect-server against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/emulead/reflect-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c1b5b87e6b2682a81efddb3cfbe56495c34412780126f5bc29ec84125aee8d61
[INFO] running `"docker" "start" "-a" "c1b5b87e6b2682a81efddb3cfbe56495c34412780126f5bc29ec84125aee8d61"`
[INFO] [stderr]     Checking reflect-server v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 |         id: id,
[INFO] [stderr]     |         ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:142:9
[INFO] [stderr]     |
[INFO] [stderr] 142 |         body: body
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 |         id: id,
[INFO] [stderr]     |         ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:142:9
[INFO] [stderr]     |
[INFO] [stderr] 142 |         body: body
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `crypt_id as u8`
[INFO] [stderr]   --> src/main.rs:55:22
[INFO] [stderr]    |
[INFO] [stderr] 55 |     buffer.insert(0, crypt_id as u8 & 0xFF);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(crypt_id >> 8) as u8`
[INFO] [stderr]   --> src/main.rs:56:22
[INFO] [stderr]    |
[INFO] [stderr] 56 |     buffer.insert(1, (crypt_id >> 8) as u8 & 0xFF);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `length as u8`
[INFO] [stderr]    --> src/main.rs:110:9
[INFO] [stderr]     |
[INFO] [stderr] 110 |         length as u8 & 0xFF,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(length >> 8) as u8`
[INFO] [stderr]    --> src/main.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 |         (length >> 8) as u8 & 0xFF,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `packet.id as u8`
[INFO] [stderr]    --> src/main.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 |         packet.id as u8 & 0xFF,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(packet.id >> 8) as u8`
[INFO] [stderr]    --> src/main.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         (packet.id >> 8) as u8 & 0xFF
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:136:14
[INFO] [stderr]     |
[INFO] [stderr] 136 |     let id = body[0] as u16 | (body[1] as u16 & 0xFF) << 8;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^ help: try: `u16::from(body[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:136:32
[INFO] [stderr]     |
[INFO] [stderr] 136 |     let id = body[0] as u16 | (body[1] as u16 & 0xFF) << 8;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^ help: try: `u16::from(body[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:151:22
[INFO] [stderr]     |
[INFO] [stderr] 151 |     if shift == 0 || bytes.len() == 0 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `crypt_id as u8`
[INFO] [stderr]   --> src/main.rs:55:22
[INFO] [stderr]    |
[INFO] [stderr] 55 |     buffer.insert(0, crypt_id as u8 & 0xFF);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(crypt_id >> 8) as u8`
[INFO] [stderr]   --> src/main.rs:56:22
[INFO] [stderr]    |
[INFO] [stderr] 56 |     buffer.insert(1, (crypt_id >> 8) as u8 & 0xFF);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `length as u8`
[INFO] [stderr]    --> src/main.rs:110:9
[INFO] [stderr]     |
[INFO] [stderr] 110 |         length as u8 & 0xFF,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(length >> 8) as u8`
[INFO] [stderr]    --> src/main.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 |         (length >> 8) as u8 & 0xFF,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `packet.id as u8`
[INFO] [stderr]    --> src/main.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 |         packet.id as u8 & 0xFF,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(packet.id >> 8) as u8`
[INFO] [stderr]    --> src/main.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         (packet.id >> 8) as u8 & 0xFF
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:136:14
[INFO] [stderr]     |
[INFO] [stderr] 136 |     let id = body[0] as u16 | (body[1] as u16 & 0xFF) << 8;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^ help: try: `u16::from(body[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:136:32
[INFO] [stderr]     |
[INFO] [stderr] 136 |     let id = body[0] as u16 | (body[1] as u16 & 0xFF) << 8;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^ help: try: `u16::from(body[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:151:22
[INFO] [stderr]     |
[INFO] [stderr] 151 |     if shift == 0 || bytes.len() == 0 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.97s
[INFO] running `"docker" "inspect" "c1b5b87e6b2682a81efddb3cfbe56495c34412780126f5bc29ec84125aee8d61"`
[INFO] running `"docker" "rm" "-f" "c1b5b87e6b2682a81efddb3cfbe56495c34412780126f5bc29ec84125aee8d61"`
[INFO] [stdout] c1b5b87e6b2682a81efddb3cfbe56495c34412780126f5bc29ec84125aee8d61