[INFO] updating cached repository emk/wasm-bloat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/emk/wasm-bloat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/emk/wasm-bloat" "work/ex/clippy-test-run/sources/stable/gh/emk/wasm-bloat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/emk/wasm-bloat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/emk/wasm-bloat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emk/wasm-bloat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emk/wasm-bloat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9363605c112128d886c4c13032cead62d498c335 [INFO] sha for GitHub repo emk/wasm-bloat: 9363605c112128d886c4c13032cead62d498c335 [INFO] validating manifest of emk/wasm-bloat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of emk/wasm-bloat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing emk/wasm-bloat [INFO] finished frobbing emk/wasm-bloat [INFO] frobbed toml for emk/wasm-bloat written to work/ex/clippy-test-run/sources/stable/gh/emk/wasm-bloat/Cargo.toml [INFO] started frobbing emk/wasm-bloat [INFO] finished frobbing emk/wasm-bloat [INFO] frobbed toml for emk/wasm-bloat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emk/wasm-bloat/Cargo.toml [INFO] crate emk/wasm-bloat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting emk/wasm-bloat against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/emk/wasm-bloat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0277d23f1a641d03526cd1e04f1efa463881f5587db0c7a72040b78eea5d6b1 [INFO] running `"docker" "start" "-a" "f0277d23f1a641d03526cd1e04f1efa463881f5587db0c7a72040b78eea5d6b1"` [INFO] [stderr] Checking termcolor v0.3.3 [INFO] [stderr] Checking cli_test_dir v0.1.4 [INFO] [stderr] Checking parking_lot_core v0.2.8 [INFO] [stderr] Compiling structopt-derive v0.1.6 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking common_failures v0.1.0 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking parity-wasm v0.19.0 [INFO] [stderr] Checking env_logger v0.5.0-rc.1 [INFO] [stderr] Checking wasm-bloat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::iter` [INFO] [stderr] --> src/name_section.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::iter; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter` [INFO] [stderr] --> src/name_section.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::iter; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter` [INFO] [stderr] --> src/index_map.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | fn iter(&self) -> Iter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/name_section.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn new>(name: S) -> ModuleNameSection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `name` [INFO] [stderr] --> src/name_section.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn name(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `name_mut` [INFO] [stderr] --> src/name_section.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn name_mut(&mut self) -> &mut String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `names_mut` [INFO] [stderr] --> src/name_section.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn names_mut(&mut self) -> &mut NameMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `local_names` [INFO] [stderr] --> src/name_section.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | pub fn local_names(&self) -> &IndexMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `local_names_mut` [INFO] [stderr] --> src/name_section.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn local_names_mut(&mut self) -> &mut IndexMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/index_map.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | / if let &Some(ref value) = value_opt { [INFO] [stderr] 240 | | self.remaining_len -= 1; [INFO] [stderr] 241 | | return Some((idx, value)) [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 239 | if let Some(ref value) = *value_opt { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `name` [INFO] [stderr] --> src/name_section.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn name(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `name_mut` [INFO] [stderr] --> src/name_section.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn name_mut(&mut self) -> &mut String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `local_names` [INFO] [stderr] --> src/name_section.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | pub fn local_names(&self) -> &IndexMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/index_map.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | / if let &Some(ref value) = value_opt { [INFO] [stderr] 240 | | self.remaining_len -= 1; [INFO] [stderr] 241 | | return Some((idx, value)) [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 239 | if let Some(ref value) = *value_opt { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/index_map.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | assert_eq!(map.iter().collect::>().len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/index_map.rs:321:35 [INFO] [stderr] | [INFO] [stderr] 321 | assert_eq!(map.into_iter().collect::>().len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.21s [INFO] running `"docker" "inspect" "f0277d23f1a641d03526cd1e04f1efa463881f5587db0c7a72040b78eea5d6b1"` [INFO] running `"docker" "rm" "-f" "f0277d23f1a641d03526cd1e04f1efa463881f5587db0c7a72040b78eea5d6b1"` [INFO] [stdout] f0277d23f1a641d03526cd1e04f1efa463881f5587db0c7a72040b78eea5d6b1