[INFO] updating cached repository eminence/snapshot_trim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eminence/snapshot_trim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eminence/snapshot_trim" "work/ex/clippy-test-run/sources/stable/gh/eminence/snapshot_trim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eminence/snapshot_trim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eminence/snapshot_trim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eminence/snapshot_trim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eminence/snapshot_trim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b1bb505cdca364d322f9268fbc7a284734044a4b [INFO] sha for GitHub repo eminence/snapshot_trim: b1bb505cdca364d322f9268fbc7a284734044a4b [INFO] validating manifest of eminence/snapshot_trim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eminence/snapshot_trim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eminence/snapshot_trim [INFO] finished frobbing eminence/snapshot_trim [INFO] frobbed toml for eminence/snapshot_trim written to work/ex/clippy-test-run/sources/stable/gh/eminence/snapshot_trim/Cargo.toml [INFO] started frobbing eminence/snapshot_trim [INFO] finished frobbing eminence/snapshot_trim [INFO] frobbed toml for eminence/snapshot_trim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eminence/snapshot_trim/Cargo.toml [INFO] crate eminence/snapshot_trim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eminence/snapshot_trim against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eminence/snapshot_trim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 887b5e94368242d5c059e8a95c3b0dee45168be5225cb866769f4c7a9a82c2a6 [INFO] running `"docker" "start" "-a" "887b5e94368242d5c059e8a95c3b0dee45168be5225cb866769f4c7a9a82c2a6"` [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Compiling serde_derive_internals v0.18.0 [INFO] [stderr] Compiling serde_derive v1.0.24 [INFO] [stderr] Checking docopt v0.8.1 [INFO] [stderr] Checking snapshot_trim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | Snapshot{snap:snap, state:SnapState::EXISTS, time:t.to_timespec()} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `snap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | Snapshot{snap:snap, state:SnapState::EXISTS, time:t.to_timespec()} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `snap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | return snaps; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `snaps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | return snaps [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `snaps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | write!(fmt, "", self.snap, self.state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the variable `iidx` is used as a loop counter. Consider using `for (iidx, item) in snaps.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:171:25 [INFO] [stderr] | [INFO] [stderr] 171 | for mut snap in snaps { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/main.rs:200:16 [INFO] [stderr] | [INFO] [stderr] 200 | panic!("{} Error: ~/.snapshot.toml doesn't exist"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | return snaps; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `snaps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | return snaps [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `snaps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | write!(fmt, "", self.snap, self.state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the variable `iidx` is used as a loop counter. Consider using `for (iidx, item) in snaps.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:171:25 [INFO] [stderr] | [INFO] [stderr] 171 | for mut snap in snaps { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/main.rs:200:16 [INFO] [stderr] | [INFO] [stderr] 200 | panic!("{} Error: ~/.snapshot.toml doesn't exist"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.41s [INFO] running `"docker" "inspect" "887b5e94368242d5c059e8a95c3b0dee45168be5225cb866769f4c7a9a82c2a6"` [INFO] running `"docker" "rm" "-f" "887b5e94368242d5c059e8a95c3b0dee45168be5225cb866769f4c7a9a82c2a6"` [INFO] [stdout] 887b5e94368242d5c059e8a95c3b0dee45168be5225cb866769f4c7a9a82c2a6