[INFO] updating cached repository eminence/scrubber [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eminence/scrubber [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eminence/scrubber" "work/ex/clippy-test-run/sources/stable/gh/eminence/scrubber"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eminence/scrubber'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eminence/scrubber" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eminence/scrubber"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eminence/scrubber'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] efc9206531989ee77c9c915e7be8673db31e5c95 [INFO] sha for GitHub repo eminence/scrubber: efc9206531989ee77c9c915e7be8673db31e5c95 [INFO] validating manifest of eminence/scrubber on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eminence/scrubber on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eminence/scrubber [INFO] finished frobbing eminence/scrubber [INFO] frobbed toml for eminence/scrubber written to work/ex/clippy-test-run/sources/stable/gh/eminence/scrubber/Cargo.toml [INFO] started frobbing eminence/scrubber [INFO] finished frobbing eminence/scrubber [INFO] frobbed toml for eminence/scrubber written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eminence/scrubber/Cargo.toml [INFO] crate eminence/scrubber has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eminence/scrubber against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eminence/scrubber:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 20f4c8397568b67dd00394a3306a5427c0b0fddfd127d644c558130684e7e099 [INFO] running `"docker" "start" "-a" "20f4c8397568b67dd00394a3306a5427c0b0fddfd127d644c558130684e7e099"` [INFO] [stderr] Checking dirs v1.0.2 [INFO] [stderr] Checking scrubber v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:87:16 [INFO] [stderr] | [INFO] [stderr] 87 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 88 | | if !file_is_old(&entry) { [INFO] [stderr] 89 | | remove = Removable::False(entry.to_owned()); [INFO] [stderr] 90 | | // println!("{:?} has been modified recently", entry); [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 87 | } else if !file_is_old(&entry) { [INFO] [stderr] 88 | remove = Removable::False(entry.to_owned()); [INFO] [stderr] 89 | // println!("{:?} has been modified recently", entry); [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:87:16 [INFO] [stderr] | [INFO] [stderr] 87 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 88 | | if !file_is_old(&entry) { [INFO] [stderr] 89 | | remove = Removable::False(entry.to_owned()); [INFO] [stderr] 90 | | // println!("{:?} has been modified recently", entry); [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 87 | } else if !file_is_old(&entry) { [INFO] [stderr] 88 | remove = Removable::False(entry.to_owned()); [INFO] [stderr] 89 | // println!("{:?} has been modified recently", entry); [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / if keep_due_to_mtime || keep_due_to_atime { [INFO] [stderr] 37 | | false [INFO] [stderr] 38 | | } else { [INFO] [stderr] 39 | | //println!("{:?} is old", f); [INFO] [stderr] 40 | | true [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(keep_due_to_mtime || keep_due_to_atime)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | return match file_is_old(dir) { [INFO] [stderr] | ________________^ [INFO] [stderr] 77 | | true => Ok(Removable::True), [INFO] [stderr] 78 | | false => Ok(Removable::False(dir.to_owned())), [INFO] [stderr] 79 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if file_is_old(dir) { Ok(Removable::True) } else { Ok(Removable::False(dir.to_owned())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / if keep_due_to_mtime || keep_due_to_atime { [INFO] [stderr] 37 | | false [INFO] [stderr] 38 | | } else { [INFO] [stderr] 39 | | //println!("{:?} is old", f); [INFO] [stderr] 40 | | true [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(keep_due_to_mtime || keep_due_to_atime)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | return match file_is_old(dir) { [INFO] [stderr] | ________________^ [INFO] [stderr] 77 | | true => Ok(Removable::True), [INFO] [stderr] 78 | | false => Ok(Removable::False(dir.to_owned())), [INFO] [stderr] 79 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if file_is_old(dir) { Ok(Removable::True) } else { Ok(Removable::False(dir.to_owned())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.13s [INFO] running `"docker" "inspect" "20f4c8397568b67dd00394a3306a5427c0b0fddfd127d644c558130684e7e099"` [INFO] running `"docker" "rm" "-f" "20f4c8397568b67dd00394a3306a5427c0b0fddfd127d644c558130684e7e099"` [INFO] [stdout] 20f4c8397568b67dd00394a3306a5427c0b0fddfd127d644c558130684e7e099