[INFO] updating cached repository emilio/tic-tac-minimax [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/emilio/tic-tac-minimax [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/emilio/tic-tac-minimax" "work/ex/clippy-test-run/sources/stable/gh/emilio/tic-tac-minimax"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/emilio/tic-tac-minimax'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/emilio/tic-tac-minimax" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emilio/tic-tac-minimax"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emilio/tic-tac-minimax'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4b13e6171bb95538e09315f7050dc2ca99c28d5c [INFO] sha for GitHub repo emilio/tic-tac-minimax: 4b13e6171bb95538e09315f7050dc2ca99c28d5c [INFO] validating manifest of emilio/tic-tac-minimax on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of emilio/tic-tac-minimax on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing emilio/tic-tac-minimax [INFO] finished frobbing emilio/tic-tac-minimax [INFO] frobbed toml for emilio/tic-tac-minimax written to work/ex/clippy-test-run/sources/stable/gh/emilio/tic-tac-minimax/Cargo.toml [INFO] started frobbing emilio/tic-tac-minimax [INFO] finished frobbing emilio/tic-tac-minimax [INFO] frobbed toml for emilio/tic-tac-minimax written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emilio/tic-tac-minimax/Cargo.toml [INFO] crate emilio/tic-tac-minimax has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting emilio/tic-tac-minimax against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/emilio/tic-tac-minimax:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44cd1c18464e747efb642ae599708c74a74ba93fb36d517fdc60759998807fe0 [INFO] running `"docker" "start" "-a" "44cd1c18464e747efb642ae599708c74a74ba93fb36d517fdc60759998807fe0"` [INFO] [stderr] Compiling gio v0.5.0 [INFO] [stderr] Compiling cairo-rs v0.5.0 [INFO] [stderr] Compiling gdk-pixbuf v0.5.0 [INFO] [stderr] Compiling gdk v0.9.0 [INFO] [stderr] Compiling gtk v0.5.0 [INFO] [stderr] Compiling glib-sys v0.7.0 [INFO] [stderr] Compiling gobject-sys v0.7.0 [INFO] [stderr] Compiling gio-sys v0.7.0 [INFO] [stderr] Compiling cairo-sys-rs v0.7.0 [INFO] [stderr] Compiling pango-sys v0.7.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.7.0 [INFO] [stderr] Compiling gdk-sys v0.7.0 [INFO] [stderr] Compiling atk-sys v0.7.0 [INFO] [stderr] Compiling gtk-sys v0.7.0 [INFO] [stderr] Checking glib v0.6.0 [INFO] [stderr] Checking pango v0.5.0 [INFO] [stderr] Checking tic-tac-minimax v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/minimax.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/minimax.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/minimax.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/minimax.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/minimax.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/minimax.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return first as i8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `first as i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | return center as i8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `center as i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return center as i8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `center as i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return first as i8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `first as i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | return center as i8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `center as i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return center as i8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `center as i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn next_player(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | fn dump_char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/state.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn subsequent_states<'a>( [INFO] [stderr] 95 | | &'a self, [INFO] [stderr] 96 | | player: CheckBox [INFO] [stderr] 97 | | ) -> SubsequentStatesIterator<'a> { [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn next_player(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | fn dump_char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/state.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn subsequent_states<'a>( [INFO] [stderr] 95 | | &'a self, [INFO] [stderr] 96 | | player: CheckBox [INFO] [stderr] 97 | | ) -> SubsequentStatesIterator<'a> { [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 35s [INFO] running `"docker" "inspect" "44cd1c18464e747efb642ae599708c74a74ba93fb36d517fdc60759998807fe0"` [INFO] running `"docker" "rm" "-f" "44cd1c18464e747efb642ae599708c74a74ba93fb36d517fdc60759998807fe0"` [INFO] [stdout] 44cd1c18464e747efb642ae599708c74a74ba93fb36d517fdc60759998807fe0