[INFO] updating cached repository embik/nightshift
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/embik/nightshift
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/embik/nightshift" "work/ex/clippy-test-run/sources/stable/gh/embik/nightshift"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/embik/nightshift'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/embik/nightshift" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/embik/nightshift"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/embik/nightshift'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6d803dce5043faa410c1b73e1a5b3455965fe89b
[INFO] sha for GitHub repo embik/nightshift: 6d803dce5043faa410c1b73e1a5b3455965fe89b
[INFO] validating manifest of embik/nightshift on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of embik/nightshift on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing embik/nightshift
[INFO] finished frobbing embik/nightshift
[INFO] frobbed toml for embik/nightshift written to work/ex/clippy-test-run/sources/stable/gh/embik/nightshift/Cargo.toml
[INFO] started frobbing embik/nightshift
[INFO] finished frobbing embik/nightshift
[INFO] frobbed toml for embik/nightshift written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/embik/nightshift/Cargo.toml
[INFO] crate embik/nightshift has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting embik/nightshift against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/embik/nightshift:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e86935b07da27fa7e214fcaa1ce348743c9c93146dca48928c77137def3d2a00
[INFO] running `"docker" "start" "-a" "e86935b07da27fa7e214fcaa1ce348743c9c93146dca48928c77137def3d2a00"`
[INFO] [stderr]     Checking libloading v0.4.3
[INFO] [stderr]    Compiling wayland-scanner v0.12.4
[INFO] [stderr]     Checking dlib v0.4.0
[INFO] [stderr]     Checking wayland-sys v0.12.4
[INFO] [stderr]    Compiling wayland-client v0.12.4
[INFO] [stderr]    Compiling nightshift v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]   --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:65:56
[INFO] [stderr]    |
[INFO] [stderr] 65 |             GammaControlManager { ptr: ptr, data: Some((&*data).2.clone()) }
[INFO] [stderr]    |                                                        ^^^^^^^^ help: try this: `*data.2`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ref_in_deref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]   --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:74:60
[INFO] [stderr]    |
[INFO] [stderr] 74 |                 GammaControlManager { ptr: ptr, data: Some((&*data).2.clone()) }
[INFO] [stderr]    |                                                            ^^^^^^^^ help: try this: `*data.2`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]    --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:182:49
[INFO] [stderr]     |
[INFO] [stderr] 182 |             GammaControl { ptr: ptr, data: Some((&*data).2.clone()) }
[INFO] [stderr]     |                                                 ^^^^^^^^ help: try this: `*data.2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]    --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:191:53
[INFO] [stderr]     |
[INFO] [stderr] 191 |                 GammaControl { ptr: ptr, data: Some((&*data).2.clone()) }
[INFO] [stderr]     |                                                     ^^^^^^^^ help: try this: `*data.2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:276:23
[INFO] [stderr]     |
[INFO] [stderr] 276 |         pub fn to_raw(&self) -> u32 {
[INFO] [stderr]     |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:295:13
[INFO] [stderr]     |
[INFO] [stderr] 295 | /             true
[INFO] [stderr] 296 | |             && (self.gamma_size as usize == other.gamma_size as usize)
[INFO] [stderr]     | |______________________________________________________________________^ help: try: `(self.gamma_size as usize == other.gamma_size as usize)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]   --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:65:56
[INFO] [stderr]    |
[INFO] [stderr] 65 |             GammaControlManager { ptr: ptr, data: Some((&*data).2.clone()) }
[INFO] [stderr]    |                                                        ^^^^^^^^ help: try this: `*data.2`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ref_in_deref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]   --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:74:60
[INFO] [stderr]    |
[INFO] [stderr] 74 |                 GammaControlManager { ptr: ptr, data: Some((&*data).2.clone()) }
[INFO] [stderr]    |                                                            ^^^^^^^^ help: try this: `*data.2`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]    --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:182:49
[INFO] [stderr]     |
[INFO] [stderr] 182 |             GammaControl { ptr: ptr, data: Some((&*data).2.clone()) }
[INFO] [stderr]     |                                                 ^^^^^^^^ help: try this: `*data.2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]    --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:191:53
[INFO] [stderr]     |
[INFO] [stderr] 191 |                 GammaControl { ptr: ptr, data: Some((&*data).2.clone()) }
[INFO] [stderr]     |                                                     ^^^^^^^^ help: try this: `*data.2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:276:23
[INFO] [stderr]     |
[INFO] [stderr] 276 |         pub fn to_raw(&self) -> u32 {
[INFO] [stderr]     |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> /opt/crater/target/debug/build/nightshift-0816d7d80b22bf02/out/gamma_control_api.rs:295:13
[INFO] [stderr]     |
[INFO] [stderr] 295 | /             true
[INFO] [stderr] 296 | |             && (self.gamma_size as usize == other.gamma_size as usize)
[INFO] [stderr]     | |______________________________________________________________________^ help: try: `(self.gamma_size as usize == other.gamma_size as usize)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.40s
[INFO] running `"docker" "inspect" "e86935b07da27fa7e214fcaa1ce348743c9c93146dca48928c77137def3d2a00"`
[INFO] running `"docker" "rm" "-f" "e86935b07da27fa7e214fcaa1ce348743c9c93146dca48928c77137def3d2a00"`
[INFO] [stdout] e86935b07da27fa7e214fcaa1ce348743c9c93146dca48928c77137def3d2a00