[INFO] updating cached repository elmadev/rec2mov [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/elmadev/rec2mov [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/elmadev/rec2mov" "work/ex/clippy-test-run/sources/stable/gh/elmadev/rec2mov"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/elmadev/rec2mov'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/elmadev/rec2mov" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elmadev/rec2mov"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elmadev/rec2mov'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b79af231076b01b2b34577c4711f9b386020923c [INFO] sha for GitHub repo elmadev/rec2mov: b79af231076b01b2b34577c4711f9b386020923c [INFO] validating manifest of elmadev/rec2mov on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of elmadev/rec2mov on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing elmadev/rec2mov [INFO] finished frobbing elmadev/rec2mov [INFO] frobbed toml for elmadev/rec2mov written to work/ex/clippy-test-run/sources/stable/gh/elmadev/rec2mov/Cargo.toml [INFO] started frobbing elmadev/rec2mov [INFO] finished frobbing elmadev/rec2mov [INFO] frobbed toml for elmadev/rec2mov written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elmadev/rec2mov/Cargo.toml [INFO] crate elmadev/rec2mov has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting elmadev/rec2mov against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/elmadev/rec2mov:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 709b83f7c2ce5b5184d9d9486e7b3405f6006554a253478ecb6e864330a3669a [INFO] running `"docker" "start" "-a" "709b83f7c2ce5b5184d9d9486e7b3405f6006554a253478ecb6e864330a3669a"` [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking pcx v0.2.0 [INFO] [stderr] Checking elma v0.1.9 [INFO] [stderr] Compiling syn v0.13.9 [INFO] [stderr] Compiling glium v0.21.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Compiling num-derive v0.2.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking rec2mov v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/png.rs:74:94 [INFO] [stderr] | [INFO] [stderr] 74 | } else if transparency != Transparency::Solid && *b == transparent_index { [INFO] [stderr] | ______________________________________________________________________________________________^ [INFO] [stderr] 75 | | rgba.push(0); [INFO] [stderr] 76 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/png.rs:72:89 [INFO] [stderr] | [INFO] [stderr] 72 | } else if transparency == Transparency::Palette && *b == palette[0] { [INFO] [stderr] | _________________________________________________________________________________________^ [INFO] [stderr] 73 | | rgba.push(0); [INFO] [stderr] 74 | | } else if transparency != Transparency::Solid && *b == transparent_index { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: unused label `'main` [INFO] [stderr] --> src/main.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / 'main: loop { [INFO] [stderr] 93 | | // building the uniforms [INFO] [stderr] 94 | | let uniforms = uniform! { [INFO] [stderr] 95 | | matrix: [ [INFO] [stderr] ... | [INFO] [stderr] 116 | | target.finish().unwrap(); [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | let (rgba, width, height) = pic_data.get("ground.pcx").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&pic_data["ground.pcx"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | let program = program!(&display, [INFO] [stderr] | ___________________^ [INFO] [stderr] 66 | | 140 => { [INFO] [stderr] 67 | | vertex: " [INFO] [stderr] 68 | | #version 140 [INFO] [stderr] ... | [INFO] [stderr] 88 | | }, [INFO] [stderr] 89 | | ).unwrap(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rec2mov`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/png.rs:74:94 [INFO] [stderr] | [INFO] [stderr] 74 | } else if transparency != Transparency::Solid && *b == transparent_index { [INFO] [stderr] | ______________________________________________________________________________________________^ [INFO] [stderr] 75 | | rgba.push(0); [INFO] [stderr] 76 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/png.rs:72:89 [INFO] [stderr] | [INFO] [stderr] 72 | } else if transparency == Transparency::Palette && *b == palette[0] { [INFO] [stderr] | _________________________________________________________________________________________^ [INFO] [stderr] 73 | | rgba.push(0); [INFO] [stderr] 74 | | } else if transparency != Transparency::Solid && *b == transparent_index { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: unused label `'main` [INFO] [stderr] --> src/main.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / 'main: loop { [INFO] [stderr] 93 | | // building the uniforms [INFO] [stderr] 94 | | let uniforms = uniform! { [INFO] [stderr] 95 | | matrix: [ [INFO] [stderr] ... | [INFO] [stderr] 116 | | target.finish().unwrap(); [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | let (rgba, width, height) = pic_data.get("ground.pcx").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&pic_data["ground.pcx"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | let program = program!(&display, [INFO] [stderr] | ___________________^ [INFO] [stderr] 66 | | 140 => { [INFO] [stderr] 67 | | vertex: " [INFO] [stderr] 68 | | #version 140 [INFO] [stderr] ... | [INFO] [stderr] 88 | | }, [INFO] [stderr] 89 | | ).unwrap(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rec2mov`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "709b83f7c2ce5b5184d9d9486e7b3405f6006554a253478ecb6e864330a3669a"` [INFO] running `"docker" "rm" "-f" "709b83f7c2ce5b5184d9d9486e7b3405f6006554a253478ecb6e864330a3669a"` [INFO] [stdout] 709b83f7c2ce5b5184d9d9486e7b3405f6006554a253478ecb6e864330a3669a