[INFO] updating cached repository eliheuer/gif-generator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eliheuer/gif-generator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eliheuer/gif-generator" "work/ex/clippy-test-run/sources/stable/gh/eliheuer/gif-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eliheuer/gif-generator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eliheuer/gif-generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eliheuer/gif-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eliheuer/gif-generator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c8eb0239893a0242d403cbb4d61e5373d70ec5dc [INFO] sha for GitHub repo eliheuer/gif-generator: c8eb0239893a0242d403cbb4d61e5373d70ec5dc [INFO] validating manifest of eliheuer/gif-generator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eliheuer/gif-generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eliheuer/gif-generator [INFO] finished frobbing eliheuer/gif-generator [INFO] frobbed toml for eliheuer/gif-generator written to work/ex/clippy-test-run/sources/stable/gh/eliheuer/gif-generator/Cargo.toml [INFO] started frobbing eliheuer/gif-generator [INFO] finished frobbing eliheuer/gif-generator [INFO] frobbed toml for eliheuer/gif-generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eliheuer/gif-generator/Cargo.toml [INFO] crate eliheuer/gif-generator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eliheuer/gif-generator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eliheuer/gif-generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f053ed27ed7fbfc08f8f3757bf233201fbaff794c69009dd3b5ae18472c0ab2 [INFO] running `"docker" "start" "-a" "7f053ed27ed7fbfc08f8f3757bf233201fbaff794c69009dd3b5ae18472c0ab2"` [INFO] [stderr] Checking gif-generator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rand_col` [INFO] [stderr] --> src/main.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let mut rand_col: [u8; 256]; [INFO] [stderr] | ^^^^^^^^ help: consider using `_rand_col` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ary_a` [INFO] [stderr] --> src/main.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | let mut ary_a: [u8; 256]; [INFO] [stderr] | ^^^^^ help: consider using `_ary_a` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ary_b` [INFO] [stderr] --> src/main.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | let mut ary_b: [u8; 256]; [INFO] [stderr] | ^^^^^ help: consider using `_ary_b` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | let mut rand_col: [u8; 256]; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | let mut ary_a: [u8; 256]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let mut ary_b: [u8; 256]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / loop { [INFO] [stderr] 20 | | println!("Please input an image size:"); [INFO] [stderr] 21 | | // let mut img_size_test = String::new(); [INFO] [stderr] 22 | | // io::stdin().read_line(&mut img_size_test) [INFO] [stderr] ... | [INFO] [stderr] 26 | | break; [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rand_col`. [INFO] [stderr] --> src/main.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for in &mut rand_col { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ary_a` [INFO] [stderr] --> src/main.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 87 | for (i, ) in ary_a.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ary_b` [INFO] [stderr] --> src/main.rs:104:14 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for (i, ) in ary_b.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:109:30 [INFO] [stderr] | [INFO] [stderr] 109 | } else if i % 3 == 0 { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 110 | | ary_b[i] = count as u8; [INFO] [stderr] 111 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:107:19 [INFO] [stderr] | [INFO] [stderr] 107 | if i == 0 { [INFO] [stderr] | ___________________^ [INFO] [stderr] 108 | | ary_b[i] = count as u8; [INFO] [stderr] 109 | | } else if i % 3 == 0 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gif-generator`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rand_col` [INFO] [stderr] --> src/main.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let mut rand_col: [u8; 256]; [INFO] [stderr] | ^^^^^^^^ help: consider using `_rand_col` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ary_a` [INFO] [stderr] --> src/main.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | let mut ary_a: [u8; 256]; [INFO] [stderr] | ^^^^^ help: consider using `_ary_a` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ary_b` [INFO] [stderr] --> src/main.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | let mut ary_b: [u8; 256]; [INFO] [stderr] | ^^^^^ help: consider using `_ary_b` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | let mut rand_col: [u8; 256]; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | let mut ary_a: [u8; 256]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let mut ary_b: [u8; 256]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / loop { [INFO] [stderr] 20 | | println!("Please input an image size:"); [INFO] [stderr] 21 | | // let mut img_size_test = String::new(); [INFO] [stderr] 22 | | // io::stdin().read_line(&mut img_size_test) [INFO] [stderr] ... | [INFO] [stderr] 26 | | break; [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rand_col`. [INFO] [stderr] --> src/main.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for in &mut rand_col { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ary_a` [INFO] [stderr] --> src/main.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 87 | for (i, ) in ary_a.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ary_b` [INFO] [stderr] --> src/main.rs:104:14 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for (i, ) in ary_b.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:109:30 [INFO] [stderr] | [INFO] [stderr] 109 | } else if i % 3 == 0 { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 110 | | ary_b[i] = count as u8; [INFO] [stderr] 111 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:107:19 [INFO] [stderr] | [INFO] [stderr] 107 | if i == 0 { [INFO] [stderr] | ___________________^ [INFO] [stderr] 108 | | ary_b[i] = count as u8; [INFO] [stderr] 109 | | } else if i % 3 == 0 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gif-generator`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7f053ed27ed7fbfc08f8f3757bf233201fbaff794c69009dd3b5ae18472c0ab2"` [INFO] running `"docker" "rm" "-f" "7f053ed27ed7fbfc08f8f3757bf233201fbaff794c69009dd3b5ae18472c0ab2"` [INFO] [stdout] 7f053ed27ed7fbfc08f8f3757bf233201fbaff794c69009dd3b5ae18472c0ab2