[INFO] updating cached repository eliascodes/minigrep
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/eliascodes/minigrep
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/eliascodes/minigrep" "work/ex/clippy-test-run/sources/stable/gh/eliascodes/minigrep"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eliascodes/minigrep'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/eliascodes/minigrep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eliascodes/minigrep"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eliascodes/minigrep'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 65bd94176ac7f5e1d41a343c4666e9a09aed47b1
[INFO] sha for GitHub repo eliascodes/minigrep: 65bd94176ac7f5e1d41a343c4666e9a09aed47b1
[INFO] validating manifest of eliascodes/minigrep on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of eliascodes/minigrep on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing eliascodes/minigrep
[INFO] finished frobbing eliascodes/minigrep
[INFO] frobbed toml for eliascodes/minigrep written to work/ex/clippy-test-run/sources/stable/gh/eliascodes/minigrep/Cargo.toml
[INFO] started frobbing eliascodes/minigrep
[INFO] finished frobbing eliascodes/minigrep
[INFO] frobbed toml for eliascodes/minigrep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eliascodes/minigrep/Cargo.toml
[INFO] crate eliascodes/minigrep has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting eliascodes/minigrep against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eliascodes/minigrep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1784734f9ea7ddd8e96d6addb7a6dd0586122cdab8f98136661d3c27052e038a
[INFO] running `"docker" "start" "-a" "1784734f9ea7ddd8e96d6addb7a6dd0586122cdab8f98136661d3c27052e038a"`
[INFO] [stderr]     Checking minigrep v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 | /         return if args.len() < 2 {
[INFO] [stderr] 12 | |             Err("Not enough arguments supplied!")
[INFO] [stderr] 13 | |         } else {
[INFO] [stderr] 14 | |             Ok(Config {
[INFO] [stderr] ...  |
[INFO] [stderr] 17 | |             })
[INFO] [stderr] 18 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 11 |         if args.len() < 2 {
[INFO] [stderr] 12 |             Err("Not enough arguments supplied!")
[INFO] [stderr] 13 |         } else {
[INFO] [stderr] 14 |             Ok(Config {
[INFO] [stderr] 15 |                 query: args[0].clone(),
[INFO] [stderr] 16 |                 filename: args[1].clone(),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 | /         return if args.len() < 2 {
[INFO] [stderr] 12 | |             Err("Not enough arguments supplied!")
[INFO] [stderr] 13 | |         } else {
[INFO] [stderr] 14 | |             Ok(Config {
[INFO] [stderr] ...  |
[INFO] [stderr] 17 | |             })
[INFO] [stderr] 18 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 11 |         if args.len() < 2 {
[INFO] [stderr] 12 |             Err("Not enough arguments supplied!")
[INFO] [stderr] 13 |         } else {
[INFO] [stderr] 14 |             Ok(Config {
[INFO] [stderr] 15 |                 query: args[0].clone(),
[INFO] [stderr] 16 |                 filename: args[1].clone(),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]   --> src/tests/mod.rs:1:1
[INFO] [stderr]    |
[INFO] [stderr] 1  | / mod tests {
[INFO] [stderr] 2  | |     use main;
[INFO] [stderr] 3  | |
[INFO] [stderr] 4  | |     #[test]
[INFO] [stderr] ...  |
[INFO] [stderr] 31 | |     }
[INFO] [stderr] 32 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/lib.rs:51:17
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 format!("{}", outer.replace(&inner, &format!("{}", &inner.red())))
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `outer.replace(&inner, &format!("{}", &inner.red())).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/lib.rs:51:17
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 format!("{}", outer.replace(&inner, &format!("{}", &inner.red())))
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `outer.replace(&inner, &format!("{}", &inner.red())).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.87s
[INFO] running `"docker" "inspect" "1784734f9ea7ddd8e96d6addb7a6dd0586122cdab8f98136661d3c27052e038a"`
[INFO] running `"docker" "rm" "-f" "1784734f9ea7ddd8e96d6addb7a6dd0586122cdab8f98136661d3c27052e038a"`
[INFO] [stdout] 1784734f9ea7ddd8e96d6addb7a6dd0586122cdab8f98136661d3c27052e038a