[INFO] updating cached repository elerch/cli-model-parser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/elerch/cli-model-parser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/elerch/cli-model-parser" "work/ex/clippy-test-run/sources/stable/gh/elerch/cli-model-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/elerch/cli-model-parser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/elerch/cli-model-parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elerch/cli-model-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elerch/cli-model-parser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 225feab3f530349d5d0a832bdd1812b98c43c0f5 [INFO] sha for GitHub repo elerch/cli-model-parser: 225feab3f530349d5d0a832bdd1812b98c43c0f5 [INFO] validating manifest of elerch/cli-model-parser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of elerch/cli-model-parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing elerch/cli-model-parser [INFO] finished frobbing elerch/cli-model-parser [INFO] frobbed toml for elerch/cli-model-parser written to work/ex/clippy-test-run/sources/stable/gh/elerch/cli-model-parser/Cargo.toml [INFO] started frobbing elerch/cli-model-parser [INFO] finished frobbing elerch/cli-model-parser [INFO] frobbed toml for elerch/cli-model-parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elerch/cli-model-parser/Cargo.toml [INFO] crate elerch/cli-model-parser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting elerch/cli-model-parser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/elerch/cli-model-parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 956c6e11489d55d775c592a8fa7bfd5bf123a06d561b1efc4de55e5ab038b9f7 [INFO] running `"docker" "start" "-a" "956c6e11489d55d775c592a8fa7bfd5bf123a06d561b1efc4de55e5ab038b9f7"` [INFO] [stderr] Checking modelparser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:30:45 [INFO] [stderr] | [INFO] [stderr] 30 | fn parameters(service: &Value, servicename: &String, operationname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:30:69 [INFO] [stderr] | [INFO] [stderr] 30 | fn parameters(service: &Value, servicename: &String, operationname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let ref shapes = service["shapes"]; [INFO] [stderr] | ----^^^^^^^^^^--------------------- help: try: `let shapes = &service["shapes"];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:45:61 [INFO] [stderr] | [INFO] [stderr] 45 | fn print_parameters(ptype: ParameterType, _: &str, service: &String, operation: &String, parameters: &Value) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:45:81 [INFO] [stderr] | [INFO] [stderr] 45 | fn print_parameters(ptype: ParameterType, _: &str, service: &String, operation: &String, parameters: &Value) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:30:45 [INFO] [stderr] | [INFO] [stderr] 30 | fn parameters(service: &Value, servicename: &String, operationname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:30:69 [INFO] [stderr] | [INFO] [stderr] 30 | fn parameters(service: &Value, servicename: &String, operationname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let ref shapes = service["shapes"]; [INFO] [stderr] | ----^^^^^^^^^^--------------------- help: try: `let shapes = &service["shapes"];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:45:61 [INFO] [stderr] | [INFO] [stderr] 45 | fn print_parameters(ptype: ParameterType, _: &str, service: &String, operation: &String, parameters: &Value) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:45:81 [INFO] [stderr] | [INFO] [stderr] 45 | fn print_parameters(ptype: ParameterType, _: &str, service: &String, operation: &String, parameters: &Value) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.43s [INFO] running `"docker" "inspect" "956c6e11489d55d775c592a8fa7bfd5bf123a06d561b1efc4de55e5ab038b9f7"` [INFO] running `"docker" "rm" "-f" "956c6e11489d55d775c592a8fa7bfd5bf123a06d561b1efc4de55e5ab038b9f7"` [INFO] [stdout] 956c6e11489d55d775c592a8fa7bfd5bf123a06d561b1efc4de55e5ab038b9f7