[INFO] updating cached repository elbart/yake [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/elbart/yake [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/elbart/yake" "work/ex/clippy-test-run/sources/stable/gh/elbart/yake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/elbart/yake'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/elbart/yake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elbart/yake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elbart/yake'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3fd4d5409e59c892c7d4339b0fde8c777718e63a [INFO] sha for GitHub repo elbart/yake: 3fd4d5409e59c892c7d4339b0fde8c777718e63a [INFO] validating manifest of elbart/yake on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of elbart/yake on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing elbart/yake [INFO] finished frobbing elbart/yake [INFO] frobbed toml for elbart/yake written to work/ex/clippy-test-run/sources/stable/gh/elbart/yake/Cargo.toml [INFO] started frobbing elbart/yake [INFO] finished frobbing elbart/yake [INFO] frobbed toml for elbart/yake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elbart/yake/Cargo.toml [INFO] crate elbart/yake has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting elbart/yake against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/elbart/yake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 331a7ed0c9221d83acfb20f82a95486b35bbe56265c979dd3338e6cf3d40ff11 [INFO] running `"docker" "start" "-a" "331a7ed0c9221d83acfb20f82a95486b35bbe56265c979dd3338e6cf3d40ff11"` [INFO] [stderr] Checking serde v1.0.54 [INFO] [stderr] Compiling syn v0.13.9 [INFO] [stderr] Compiling serde_derive v1.0.54 [INFO] [stderr] Checking serde_yaml v0.7.4 [INFO] [stderr] Checking yake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/yake.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | return y; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/yake.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | return y; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/yake.rs:154:56 [INFO] [stderr] | [INFO] [stderr] 154 | for dependency_name in target.meta.depends.unwrap_or(vec![]).iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/yake.rs:156:38 [INFO] [stderr] | [INFO] [stderr] 156 | let dep_target = dep.expect( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 157 | | format!("Warning: Unknown dependency: {} in target: {}.", [INFO] [stderr] 158 | | dependency_name, [INFO] [stderr] 159 | | target_name).as_str() [INFO] [stderr] 160 | | ); [INFO] [stderr] | |_________________^ help: try this: `unwrap_or_else(|| panic!("Warning: Unknown dependency: {} in target: {}.", dependency_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/yake.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | self.dependencies.get(target_name).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.dependencies[target_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/yake.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | / match target.exec { [INFO] [stderr] 202 | | Some(ref commands) => { [INFO] [stderr] 203 | | for command in commands { [INFO] [stderr] 204 | | println!("-- {}", command); [INFO] [stderr] ... | [INFO] [stderr] 214 | | _ => () [INFO] [stderr] 215 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 201 | if let Some(ref commands) = target.exec { [INFO] [stderr] 202 | for command in commands { [INFO] [stderr] 203 | println!("-- {}", command); [INFO] [stderr] 204 | Command::new("bash") [INFO] [stderr] 205 | .arg("-c") [INFO] [stderr] 206 | .arg(command.clone()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/yake.rs:211:30 [INFO] [stderr] | [INFO] [stderr] 211 | .expect(&format!("failed to execute command \"{}\"", command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to execute command \"{}\"", command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/yake.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | / match self.targets { [INFO] [stderr] 237 | | Some(ref x) => for (target_name, target) in x { [INFO] [stderr] 238 | | if target.meta.target_type == YakeTargetType::Cmd { [INFO] [stderr] 239 | | let name = match prefix { [INFO] [stderr] ... | [INFO] [stderr] 252 | | None => () [INFO] [stderr] 253 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 236 | if let Some(ref x) = self.targets for (target_name, target) in x { [INFO] [stderr] 237 | if target.meta.target_type == YakeTargetType::Cmd { [INFO] [stderr] 238 | let name = match prefix { [INFO] [stderr] 239 | Some(ref x) => format!("{}.{}", x, target_name), [INFO] [stderr] 240 | None => target_name.to_string(), [INFO] [stderr] 241 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/yake.rs:262:14 [INFO] [stderr] | [INFO] [stderr] 262 | ret.push(yake.targets.get("test").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&yake.targets["test"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/yake.rs:298:54 [INFO] [stderr] | [INFO] [stderr] 298 | dependencies.insert("test".to_string(), vec![targets.get(&"base".to_string()).unwrap().clone()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&targets[&"base".to_string()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/args.rs:35:38 [INFO] [stderr] | [INFO] [stderr] 35 | match param.trim().split("=").collect::>().as_slice() { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match yake.has_target_name(&yake_args.target) { [INFO] [stderr] 24 | | Err(x) => { [INFO] [stderr] 25 | | eprintln!("Unknown target: '{}' Available targets are: {:?}", [INFO] [stderr] 26 | | yake_args.target, x); [INFO] [stderr] ... | [INFO] [stderr] 29 | | _ => (), [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | if let Err(x) = yake.has_target_name(&yake_args.target) { [INFO] [stderr] 24 | eprintln!("Unknown target: '{}' Available targets are: {:?}", [INFO] [stderr] 25 | yake_args.target, x); [INFO] [stderr] 26 | exit(1); [INFO] [stderr] 27 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:33:10 [INFO] [stderr] | [INFO] [stderr] 33 | .expect(format!("Execution of target: {} failed.", &yake_args.target).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Execution of target: {} failed.", &yake_args.target))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/yake.rs:154:56 [INFO] [stderr] | [INFO] [stderr] 154 | for dependency_name in target.meta.depends.unwrap_or(vec![]).iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/yake.rs:156:38 [INFO] [stderr] | [INFO] [stderr] 156 | let dep_target = dep.expect( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 157 | | format!("Warning: Unknown dependency: {} in target: {}.", [INFO] [stderr] 158 | | dependency_name, [INFO] [stderr] 159 | | target_name).as_str() [INFO] [stderr] 160 | | ); [INFO] [stderr] | |_________________^ help: try this: `unwrap_or_else(|| panic!("Warning: Unknown dependency: {} in target: {}.", dependency_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/yake.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | self.dependencies.get(target_name).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.dependencies[target_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/yake.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | / match target.exec { [INFO] [stderr] 202 | | Some(ref commands) => { [INFO] [stderr] 203 | | for command in commands { [INFO] [stderr] 204 | | println!("-- {}", command); [INFO] [stderr] ... | [INFO] [stderr] 214 | | _ => () [INFO] [stderr] 215 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 201 | if let Some(ref commands) = target.exec { [INFO] [stderr] 202 | for command in commands { [INFO] [stderr] 203 | println!("-- {}", command); [INFO] [stderr] 204 | Command::new("bash") [INFO] [stderr] 205 | .arg("-c") [INFO] [stderr] 206 | .arg(command.clone()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/yake.rs:211:30 [INFO] [stderr] | [INFO] [stderr] 211 | .expect(&format!("failed to execute command \"{}\"", command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to execute command \"{}\"", command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/yake.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | / match self.targets { [INFO] [stderr] 237 | | Some(ref x) => for (target_name, target) in x { [INFO] [stderr] 238 | | if target.meta.target_type == YakeTargetType::Cmd { [INFO] [stderr] 239 | | let name = match prefix { [INFO] [stderr] ... | [INFO] [stderr] 252 | | None => () [INFO] [stderr] 253 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 236 | if let Some(ref x) = self.targets for (target_name, target) in x { [INFO] [stderr] 237 | if target.meta.target_type == YakeTargetType::Cmd { [INFO] [stderr] 238 | let name = match prefix { [INFO] [stderr] 239 | Some(ref x) => format!("{}.{}", x, target_name), [INFO] [stderr] 240 | None => target_name.to_string(), [INFO] [stderr] 241 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/yake.rs:262:14 [INFO] [stderr] | [INFO] [stderr] 262 | ret.push(yake.targets.get("test").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&yake.targets["test"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/args.rs:35:38 [INFO] [stderr] | [INFO] [stderr] 35 | match param.trim().split("=").collect::>().as_slice() { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match yake.has_target_name(&yake_args.target) { [INFO] [stderr] 24 | | Err(x) => { [INFO] [stderr] 25 | | eprintln!("Unknown target: '{}' Available targets are: {:?}", [INFO] [stderr] 26 | | yake_args.target, x); [INFO] [stderr] ... | [INFO] [stderr] 29 | | _ => (), [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | if let Err(x) = yake.has_target_name(&yake_args.target) { [INFO] [stderr] 24 | eprintln!("Unknown target: '{}' Available targets are: {:?}", [INFO] [stderr] 25 | yake_args.target, x); [INFO] [stderr] 26 | exit(1); [INFO] [stderr] 27 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:33:10 [INFO] [stderr] | [INFO] [stderr] 33 | .expect(format!("Execution of target: {} failed.", &yake_args.target).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Execution of target: {} failed.", &yake_args.target))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.71s [INFO] running `"docker" "inspect" "331a7ed0c9221d83acfb20f82a95486b35bbe56265c979dd3338e6cf3d40ff11"` [INFO] running `"docker" "rm" "-f" "331a7ed0c9221d83acfb20f82a95486b35bbe56265c979dd3338e6cf3d40ff11"` [INFO] [stdout] 331a7ed0c9221d83acfb20f82a95486b35bbe56265c979dd3338e6cf3d40ff11