[INFO] updating cached repository elbart/rust-http-signatures [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/elbart/rust-http-signatures [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/elbart/rust-http-signatures" "work/ex/clippy-test-run/sources/stable/gh/elbart/rust-http-signatures"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/elbart/rust-http-signatures'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/elbart/rust-http-signatures" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elbart/rust-http-signatures"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elbart/rust-http-signatures'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 96b05d067cb63ecc5ebe67d878c123f8cff32ac1 [INFO] sha for GitHub repo elbart/rust-http-signatures: 96b05d067cb63ecc5ebe67d878c123f8cff32ac1 [INFO] validating manifest of elbart/rust-http-signatures on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of elbart/rust-http-signatures on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing elbart/rust-http-signatures [INFO] finished frobbing elbart/rust-http-signatures [INFO] frobbed toml for elbart/rust-http-signatures written to work/ex/clippy-test-run/sources/stable/gh/elbart/rust-http-signatures/Cargo.toml [INFO] started frobbing elbart/rust-http-signatures [INFO] finished frobbing elbart/rust-http-signatures [INFO] frobbed toml for elbart/rust-http-signatures written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elbart/rust-http-signatures/Cargo.toml [INFO] crate elbart/rust-http-signatures has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting elbart/rust-http-signatures against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/elbart/rust-http-signatures:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 190dcf85f17d980055acf6a7248506675f318ea6ec84b798ce91cdac774a1371 [INFO] running `"docker" "start" "-a" "190dcf85f17d980055acf6a7248506675f318ea6ec84b798ce91cdac774a1371"` [INFO] [stderr] Checking http-signatures v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `regex::Regex` [INFO] [stderr] --> src/lib.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use regex::Regex; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `crypto::digest::Digest` [INFO] [stderr] --> src/lib.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use crypto::digest::Digest; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `alg` [INFO] [stderr] --> src/lib.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | alg: SignatureAlgorithm, [INFO] [stderr] | ^^^ help: consider using `_alg` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `algorithm` [INFO] [stderr] --> src/lib.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | algorithm: SignatureAlgorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `RSA_SHA256` should have a camel case name such as `RsaSha256` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | RSA_SHA256, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `HMAC_SHA256` should have a camel case name such as `HmacSha256` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | HMAC_SHA256, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | let repr = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 51 | | &HTTPMethod::HEAD => "HEAD", [INFO] [stderr] 52 | | &HTTPMethod::GET => "GET", [INFO] [stderr] 53 | | &HTTPMethod::POST => "POST", [INFO] [stderr] ... | [INFO] [stderr] 60 | | &HTTPMethod::TRACE => "TRACE", [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | let repr = match *self { [INFO] [stderr] 51 | HTTPMethod::HEAD => "HEAD", [INFO] [stderr] 52 | HTTPMethod::GET => "GET", [INFO] [stderr] 53 | HTTPMethod::POST => "POST", [INFO] [stderr] 54 | HTTPMethod::PUT => "PUT", [INFO] [stderr] 55 | HTTPMethod::DELETE => "DELETE", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:114:38 [INFO] [stderr] | [INFO] [stderr] 114 | "content-md5" => match req.body { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 115 | | Some(ref body) => if body.len() > 0 { [INFO] [stderr] 116 | | result.push(HTTPHeader(h.clone(), b64_encode(body))) [INFO] [stderr] 117 | | }, [INFO] [stderr] 118 | | None => (), [INFO] [stderr] 119 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | "content-md5" => if let Some(ref body) = req.body { if body.len() > 0 { [INFO] [stderr] 115 | result.push(HTTPHeader(h.clone(), b64_encode(body))) [INFO] [stderr] 116 | } }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:115:46 [INFO] [stderr] | [INFO] [stderr] 115 | Some(ref body) => if body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:133:18 [INFO] [stderr] | [INFO] [stderr] 133 | headers: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[HTTPHeader]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:145:18 [INFO] [stderr] | [INFO] [stderr] 145 | headers: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[HTTPHeader]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused import: `crypto::digest::Digest` [INFO] [stderr] --> src/lib.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use crypto::digest::Digest; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `method` [INFO] [stderr] --> src/lib.rs:209:20 [INFO] [stderr] | [INFO] [stderr] 209 | fn new_request(method: HTTPMethod) -> HTTPRequest { [INFO] [stderr] | ^^^^^^ help: consider using `_method` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `alg` [INFO] [stderr] --> src/lib.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | alg: SignatureAlgorithm, [INFO] [stderr] | ^^^ help: consider using `_alg` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `algorithm` [INFO] [stderr] --> src/lib.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | algorithm: SignatureAlgorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `RSA_SHA256` should have a camel case name such as `RsaSha256` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | RSA_SHA256, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `HMAC_SHA256` should have a camel case name such as `HmacSha256` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | HMAC_SHA256, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | let repr = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 51 | | &HTTPMethod::HEAD => "HEAD", [INFO] [stderr] 52 | | &HTTPMethod::GET => "GET", [INFO] [stderr] 53 | | &HTTPMethod::POST => "POST", [INFO] [stderr] ... | [INFO] [stderr] 60 | | &HTTPMethod::TRACE => "TRACE", [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | let repr = match *self { [INFO] [stderr] 51 | HTTPMethod::HEAD => "HEAD", [INFO] [stderr] 52 | HTTPMethod::GET => "GET", [INFO] [stderr] 53 | HTTPMethod::POST => "POST", [INFO] [stderr] 54 | HTTPMethod::PUT => "PUT", [INFO] [stderr] 55 | HTTPMethod::DELETE => "DELETE", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:114:38 [INFO] [stderr] | [INFO] [stderr] 114 | "content-md5" => match req.body { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 115 | | Some(ref body) => if body.len() > 0 { [INFO] [stderr] 116 | | result.push(HTTPHeader(h.clone(), b64_encode(body))) [INFO] [stderr] 117 | | }, [INFO] [stderr] 118 | | None => (), [INFO] [stderr] 119 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | "content-md5" => if let Some(ref body) = req.body { if body.len() > 0 { [INFO] [stderr] 115 | result.push(HTTPHeader(h.clone(), b64_encode(body))) [INFO] [stderr] 116 | } }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:115:46 [INFO] [stderr] | [INFO] [stderr] 115 | Some(ref body) => if body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:133:18 [INFO] [stderr] | [INFO] [stderr] 133 | headers: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[HTTPHeader]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:145:18 [INFO] [stderr] | [INFO] [stderr] 145 | headers: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[HTTPHeader]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.23s [INFO] running `"docker" "inspect" "190dcf85f17d980055acf6a7248506675f318ea6ec84b798ce91cdac774a1371"` [INFO] running `"docker" "rm" "-f" "190dcf85f17d980055acf6a7248506675f318ea6ec84b798ce91cdac774a1371"` [INFO] [stdout] 190dcf85f17d980055acf6a7248506675f318ea6ec84b798ce91cdac774a1371