[INFO] updating cached repository elbart/jf
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/elbart/jf
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/elbart/jf" "work/ex/clippy-test-run/sources/stable/gh/elbart/jf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/elbart/jf'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/elbart/jf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elbart/jf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elbart/jf'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8847d70527843afd5cdc96b56203c97736d9a0c2
[INFO] sha for GitHub repo elbart/jf: 8847d70527843afd5cdc96b56203c97736d9a0c2
[INFO] validating manifest of elbart/jf on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of elbart/jf on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing elbart/jf
[INFO] finished frobbing elbart/jf
[INFO] frobbed toml for elbart/jf written to work/ex/clippy-test-run/sources/stable/gh/elbart/jf/Cargo.toml
[INFO] started frobbing elbart/jf
[INFO] finished frobbing elbart/jf
[INFO] frobbed toml for elbart/jf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elbart/jf/Cargo.toml
[INFO] crate elbart/jf has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting elbart/jf against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/elbart/jf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9b529ee1db6a0a552899c55d643fd29015c251d8bc12e416613b6e981efa6fa3
[INFO] running `"docker" "start" "-a" "9b529ee1db6a0a552899c55d643fd29015c251d8bc12e416613b6e981efa6fa3"`
[INFO] [stderr]     Checking jf v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return s;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return s;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/main.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 | /     if value.is_boolean() || value.is_null() || value.is_number() || value.is_string() {
[INFO] [stderr] 35 | |         true
[INFO] [stderr] 36 | |     } else {
[INFO] [stderr] 37 | |         false
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^ help: you can reduce it to: `value.is_boolean() || value.is_null() || value.is_number() || value.is_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:56:23
[INFO] [stderr]    |
[INFO] [stderr] 56 | fn flatten_array(arr: &Vec<Value>, path: &str) -> String {
[INFO] [stderr]    |                       ^^^^^^^^^^^ help: change this to: `&[Value]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return s;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return s;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/main.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 | /     if value.is_boolean() || value.is_null() || value.is_number() || value.is_string() {
[INFO] [stderr] 35 | |         true
[INFO] [stderr] 36 | |     } else {
[INFO] [stderr] 37 | |         false
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^ help: you can reduce it to: `value.is_boolean() || value.is_null() || value.is_number() || value.is_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:56:23
[INFO] [stderr]    |
[INFO] [stderr] 56 | fn flatten_array(arr: &Vec<Value>, path: &str) -> String {
[INFO] [stderr]    |                       ^^^^^^^^^^^ help: change this to: `&[Value]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.03s
[INFO] running `"docker" "inspect" "9b529ee1db6a0a552899c55d643fd29015c251d8bc12e416613b6e981efa6fa3"`
[INFO] running `"docker" "rm" "-f" "9b529ee1db6a0a552899c55d643fd29015c251d8bc12e416613b6e981efa6fa3"`
[INFO] [stdout] 9b529ee1db6a0a552899c55d643fd29015c251d8bc12e416613b6e981efa6fa3