[INFO] updating cached repository elUrso/bench [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/elUrso/bench [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/elUrso/bench" "work/ex/clippy-test-run/sources/stable/gh/elUrso/bench"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/elUrso/bench'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/elUrso/bench" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elUrso/bench"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elUrso/bench'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ab1e698cc69062b28d7a149e53d56077192b67e2 [INFO] sha for GitHub repo elUrso/bench: ab1e698cc69062b28d7a149e53d56077192b67e2 [INFO] validating manifest of elUrso/bench on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of elUrso/bench on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing elUrso/bench [INFO] finished frobbing elUrso/bench [INFO] frobbed toml for elUrso/bench written to work/ex/clippy-test-run/sources/stable/gh/elUrso/bench/Cargo.toml [INFO] started frobbing elUrso/bench [INFO] finished frobbing elUrso/bench [INFO] frobbed toml for elUrso/bench written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elUrso/bench/Cargo.toml [INFO] crate elUrso/bench has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting elUrso/bench against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/elUrso/bench:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b820a88c3dfa619a98d5db090f1339999ebcc117ce1e06d37d158735d0ead61b [INFO] running `"docker" "start" "-a" "b820a88c3dfa619a98d5db090f1339999ebcc117ce1e06d37d158735d0ead61b"` [INFO] [stderr] Checking bench v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:153:79 [INFO] [stderr] | [INFO] [stderr] 153 | serde_json::Value::Object(ref mut s) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:193:75 [INFO] [stderr] | [INFO] [stderr] 193 | serde_json::Value::Number(n) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:195:62 [INFO] [stderr] | [INFO] [stderr] 195 | Some(q) => { q } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:153:79 [INFO] [stderr] | [INFO] [stderr] 153 | serde_json::Value::Object(ref mut s) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:193:75 [INFO] [stderr] | [INFO] [stderr] 193 | serde_json::Value::Number(n) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:195:62 [INFO] [stderr] | [INFO] [stderr] 195 | Some(q) => { q } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / fn main() { [INFO] [stderr] 15 | | let file_key = "BENCH_STDFILE"; [INFO] [stderr] 16 | | let path_key = "BENCH_STDPATH"; [INFO] [stderr] 17 | | let id_key = "BENCH_STDID"; [INFO] [stderr] ... | [INFO] [stderr] 231 | | std::fs::write(seek, raw_text).expect("Err: could not write to bench file"); [INFO] [stderr] 232 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the variable `mark` is used as a loop counter. Consider using `for (mark, item) in std::env::args().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | for argument in std::env::args() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | if command == String::from("") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | if v["build"] == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `v["build"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | / match out { [INFO] [stderr] 177 | | Ok(s) => {hardware = String::from(std::str::from_utf8(&s.stdout).expect("Err: could not get neofetch out")).replace("\n", " ").replace("\"","\"\"").replace(",", ";")} [INFO] [stderr] 178 | | Err(_) => {} [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(s) = out {hardware = String::from(std::str::from_utf8(&s.stdout).expect("Err: could not get neofetch out")).replace("\n", " ").replace("\"","\"\"").replace(",", ";")}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:192:45 [INFO] [stderr] | [INFO] [stderr] 192 | / match num { [INFO] [stderr] 193 | | serde_json::Value::Number(n) => { [INFO] [stderr] 194 | | let n = match n.as_f64() { [INFO] [stderr] 195 | | Some(q) => { q } [INFO] [stderr] ... | [INFO] [stderr] 202 | | _ => { } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 192 | if let serde_json::Value::Number(n) = num { [INFO] [stderr] 193 | let n = match n.as_f64() { [INFO] [stderr] 194 | Some(q) => { q } [INFO] [stderr] 195 | None => {0.0} [INFO] [stderr] 196 | }; [INFO] [stderr] 197 | if n != 0.0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:206:44 [INFO] [stderr] | [INFO] [stderr] 206 | if values.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:234:26 [INFO] [stderr] | [INFO] [stderr] 234 | fn check_folders(offset: &String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 234 | fn check_folders(offset: &str) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 235 | check_folder(String::from(offset) + "bin"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 236 | check_folder(String::from(offset) + "src"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 237 | check_folder(String::from(offset) + "log"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 238 | check_folder(String::from(offset) + "input"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 239 | check_folder(String::from(offset) + "output"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / fn main() { [INFO] [stderr] 15 | | let file_key = "BENCH_STDFILE"; [INFO] [stderr] 16 | | let path_key = "BENCH_STDPATH"; [INFO] [stderr] 17 | | let id_key = "BENCH_STDID"; [INFO] [stderr] ... | [INFO] [stderr] 231 | | std::fs::write(seek, raw_text).expect("Err: could not write to bench file"); [INFO] [stderr] 232 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:249:24 [INFO] [stderr] | [INFO] [stderr] 249 | fn clear_build(offset: &String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 249 | fn clear_build(offset: &str) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 251 | check_folder(String::from(offset) + "bin"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `mark` is used as a loop counter. Consider using `for (mark, item) in std::env::args().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | for argument in std::env::args() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | if command == String::from("") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | if v["build"] == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `v["build"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | / match out { [INFO] [stderr] 177 | | Ok(s) => {hardware = String::from(std::str::from_utf8(&s.stdout).expect("Err: could not get neofetch out")).replace("\n", " ").replace("\"","\"\"").replace(",", ";")} [INFO] [stderr] 178 | | Err(_) => {} [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(s) = out {hardware = String::from(std::str::from_utf8(&s.stdout).expect("Err: could not get neofetch out")).replace("\n", " ").replace("\"","\"\"").replace(",", ";")}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:192:45 [INFO] [stderr] | [INFO] [stderr] 192 | / match num { [INFO] [stderr] 193 | | serde_json::Value::Number(n) => { [INFO] [stderr] 194 | | let n = match n.as_f64() { [INFO] [stderr] 195 | | Some(q) => { q } [INFO] [stderr] ... | [INFO] [stderr] 202 | | _ => { } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 192 | if let serde_json::Value::Number(n) = num { [INFO] [stderr] 193 | let n = match n.as_f64() { [INFO] [stderr] 194 | Some(q) => { q } [INFO] [stderr] 195 | None => {0.0} [INFO] [stderr] 196 | }; [INFO] [stderr] 197 | if n != 0.0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:206:44 [INFO] [stderr] | [INFO] [stderr] 206 | if values.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:234:26 [INFO] [stderr] | [INFO] [stderr] 234 | fn check_folders(offset: &String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 234 | fn check_folders(offset: &str) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 235 | check_folder(String::from(offset) + "bin"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 236 | check_folder(String::from(offset) + "src"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 237 | check_folder(String::from(offset) + "log"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 238 | check_folder(String::from(offset) + "input"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 239 | check_folder(String::from(offset) + "output"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:249:24 [INFO] [stderr] | [INFO] [stderr] 249 | fn clear_build(offset: &String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 249 | fn clear_build(offset: &str) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `offset.as_str()` to [INFO] [stderr] | [INFO] [stderr] 251 | check_folder(String::from(offset) + "bin"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.83s [INFO] running `"docker" "inspect" "b820a88c3dfa619a98d5db090f1339999ebcc117ce1e06d37d158735d0ead61b"` [INFO] running `"docker" "rm" "-f" "b820a88c3dfa619a98d5db090f1339999ebcc117ce1e06d37d158735d0ead61b"` [INFO] [stdout] b820a88c3dfa619a98d5db090f1339999ebcc117ce1e06d37d158735d0ead61b