[INFO] updating cached repository ejpcmac/diceware [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ejpcmac/diceware [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ejpcmac/diceware" "work/ex/clippy-test-run/sources/stable/gh/ejpcmac/diceware"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ejpcmac/diceware'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ejpcmac/diceware" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ejpcmac/diceware"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ejpcmac/diceware'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 129400b0296f898b6c837e493d7752acc237b247 [INFO] sha for GitHub repo ejpcmac/diceware: 129400b0296f898b6c837e493d7752acc237b247 [INFO] validating manifest of ejpcmac/diceware on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ejpcmac/diceware on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ejpcmac/diceware [INFO] finished frobbing ejpcmac/diceware [INFO] frobbed toml for ejpcmac/diceware written to work/ex/clippy-test-run/sources/stable/gh/ejpcmac/diceware/Cargo.toml [INFO] started frobbing ejpcmac/diceware [INFO] finished frobbing ejpcmac/diceware [INFO] frobbed toml for ejpcmac/diceware written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ejpcmac/diceware/Cargo.toml [INFO] crate ejpcmac/diceware has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ejpcmac/diceware against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ejpcmac/diceware:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 725a7c4d40df2a01db873673012990d716ce2b2d26d4f40b6793f23d490dc5a2 [INFO] running `"docker" "start" "-a" "725a7c4d40df2a01db873673012990d716ce2b2d26d4f40b6793f23d490dc5a2"` [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking bit-set v0.5.0 [INFO] [stderr] Checking diceware v1.0.1 (/opt/crater/workdir) [INFO] [stderr] Checking proptest v0.7.0 [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:444:64 [INFO] [stderr] | [INFO] [stderr] 444 | assert!(word_with_char.char_indices().any(|(i, c)| { [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 445 | | if chars.contains(&c) { [INFO] [stderr] 446 | | let mut word = word_with_char.to_owned(); [INFO] [stderr] 447 | | word.remove(i); [INFO] [stderr] ... | [INFO] [stderr] 452 | | } [INFO] [stderr] 453 | | })); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.31s [INFO] running `"docker" "inspect" "725a7c4d40df2a01db873673012990d716ce2b2d26d4f40b6793f23d490dc5a2"` [INFO] running `"docker" "rm" "-f" "725a7c4d40df2a01db873673012990d716ce2b2d26d4f40b6793f23d490dc5a2"` [INFO] [stdout] 725a7c4d40df2a01db873673012990d716ce2b2d26d4f40b6793f23d490dc5a2