[INFO] updating cached repository eiko/turtle_shell [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eiko/turtle_shell [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eiko/turtle_shell" "work/ex/clippy-test-run/sources/stable/gh/eiko/turtle_shell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eiko/turtle_shell'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eiko/turtle_shell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eiko/turtle_shell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eiko/turtle_shell'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d69436563f9828dbb5d95779c799a91894bfb0f3 [INFO] sha for GitHub repo eiko/turtle_shell: d69436563f9828dbb5d95779c799a91894bfb0f3 [INFO] validating manifest of eiko/turtle_shell on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eiko/turtle_shell on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eiko/turtle_shell [INFO] finished frobbing eiko/turtle_shell [INFO] frobbed toml for eiko/turtle_shell written to work/ex/clippy-test-run/sources/stable/gh/eiko/turtle_shell/Cargo.toml [INFO] started frobbing eiko/turtle_shell [INFO] finished frobbing eiko/turtle_shell [INFO] frobbed toml for eiko/turtle_shell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eiko/turtle_shell/Cargo.toml [INFO] crate eiko/turtle_shell has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eiko/turtle_shell against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eiko/turtle_shell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3485906a4849af9c3b7ef3d4d05635bd5db9f1bf1ebb80f55b913b6b56b85578 [INFO] running `"docker" "start" "-a" "3485906a4849af9c3b7ef3d4d05635bd5db9f1bf1ebb80f55b913b6b56b85578"` [INFO] [stderr] Checking glib-sys v0.3.3 [INFO] [stderr] Checking cairo-sys-rs v0.3.3 [INFO] [stderr] Checking gobject-sys v0.3.3 [INFO] [stderr] Checking gio-sys v0.3.3 [INFO] [stderr] Checking glib v0.1.2 [INFO] [stderr] Checking pango-sys v0.3.3 [INFO] [stderr] Checking atk-sys v0.3.3 [INFO] [stderr] Checking pango v0.1.2 [INFO] [stderr] Checking cairo-rs v0.1.2 [INFO] [stderr] Checking gdk-pixbuf-sys v0.3.3 [INFO] [stderr] Checking gio v0.1.2 [INFO] [stderr] Checking gdk-sys v0.3.3 [INFO] [stderr] Checking gdk-pixbuf v0.1.2 [INFO] [stderr] Checking gtk-sys v0.3.3 [INFO] [stderr] Checking gdk v0.5.2 [INFO] [stderr] Checking gtk v0.1.2 [INFO] [stderr] Checking turtle_shell v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/core.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/core.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turbin.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return String::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::new()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/core.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / return Err(format!("the value \"{}\" is invalid and cannot be subtracted", [INFO] [stderr] 127 | | params[0])); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 126 | Err(format!("the value \"{}\" is invalid and cannot be subtracted", [INFO] [stderr] 127 | params[0])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | / return Err(format!("the value \"{}\" is invalid and cannot be divided", [INFO] [stderr] 156 | | params[0])); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 155 | Err(format!("the value \"{}\" is invalid and cannot be divided", [INFO] [stderr] 156 | params[0])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | return Err(format!("the value \"{}\" is an invalid number", params[0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("the value \"{}\" is an invalid number", params[0]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return Ok(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | return Ok(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return "message not found D:".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"message not found D:".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turbin.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return String::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::new()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/core.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / return Err(format!("the value \"{}\" is invalid and cannot be subtracted", [INFO] [stderr] 127 | | params[0])); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 126 | Err(format!("the value \"{}\" is invalid and cannot be subtracted", [INFO] [stderr] 127 | params[0])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | / return Err(format!("the value \"{}\" is invalid and cannot be divided", [INFO] [stderr] 156 | | params[0])); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 155 | Err(format!("the value \"{}\" is invalid and cannot be divided", [INFO] [stderr] 156 | params[0])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | return Err(format!("the value \"{}\" is an invalid number", params[0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("the value \"{}\" is an invalid number", params[0]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return Ok(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | return Ok(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return "message not found D:".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"message not found D:".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `params` [INFO] [stderr] --> src/core.rs:173:19 [INFO] [stderr] | [INFO] [stderr] 173 | fn ask(&self, params: Vec) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_params` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/turbin.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | fn receive(&self, message: &str, mut params: Vec) -> String { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `name` [INFO] [stderr] --> src/core.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn name(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load` [INFO] [stderr] --> src/core.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn load(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load_plugin` [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | fn load_plugin(&mut self, plugin: &'a Plugin) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/turbin.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/turbin.rs:43:35 [INFO] [stderr] | [INFO] [stderr] 43 | let output = com.output().expect(&format!("failed to execute turbin: {}", self.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to execute turbin: {}", self.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match command { [INFO] [stderr] 84 | | &parser::Command::Literal(ref s) => s.to_string(), [INFO] [stderr] 85 | | &parser::Command::Expression { ref terms } => { [INFO] [stderr] 86 | | let message = self.execute(&terms[0]); [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 83 | match *command { [INFO] [stderr] 84 | parser::Command::Literal(ref s) => s.to_string(), [INFO] [stderr] 85 | parser::Command::Expression { ref terms } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `params` [INFO] [stderr] --> src/core.rs:173:19 [INFO] [stderr] | [INFO] [stderr] 173 | fn ask(&self, params: Vec) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_params` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/turbin.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | fn receive(&self, message: &str, mut params: Vec) -> String { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `name` [INFO] [stderr] --> src/core.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn name(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load` [INFO] [stderr] --> src/core.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn load(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load_plugin` [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | fn load_plugin(&mut self, plugin: &'a Plugin) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/turbin.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/turbin.rs:43:35 [INFO] [stderr] | [INFO] [stderr] 43 | let output = com.output().expect(&format!("failed to execute turbin: {}", self.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to execute turbin: {}", self.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match command { [INFO] [stderr] 84 | | &parser::Command::Literal(ref s) => s.to_string(), [INFO] [stderr] 85 | | &parser::Command::Expression { ref terms } => { [INFO] [stderr] 86 | | let message = self.execute(&terms[0]); [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 83 | match *command { [INFO] [stderr] 84 | parser::Command::Literal(ref s) => s.to_string(), [INFO] [stderr] 85 | parser::Command::Expression { ref terms } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.12s [INFO] running `"docker" "inspect" "3485906a4849af9c3b7ef3d4d05635bd5db9f1bf1ebb80f55b913b6b56b85578"` [INFO] running `"docker" "rm" "-f" "3485906a4849af9c3b7ef3d4d05635bd5db9f1bf1ebb80f55b913b6b56b85578"` [INFO] [stdout] 3485906a4849af9c3b7ef3d4d05635bd5db9f1bf1ebb80f55b913b6b56b85578