[INFO] updating cached repository ehuss/raytracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ehuss/raytracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ehuss/raytracer" "work/ex/clippy-test-run/sources/stable/gh/ehuss/raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ehuss/raytracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ehuss/raytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ehuss/raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ehuss/raytracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9a88a081dab342da88ba7829283f2a28e14c6274 [INFO] sha for GitHub repo ehuss/raytracer: 9a88a081dab342da88ba7829283f2a28e14c6274 [INFO] validating manifest of ehuss/raytracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ehuss/raytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ehuss/raytracer [INFO] finished frobbing ehuss/raytracer [INFO] frobbed toml for ehuss/raytracer written to work/ex/clippy-test-run/sources/stable/gh/ehuss/raytracer/Cargo.toml [INFO] started frobbing ehuss/raytracer [INFO] finished frobbing ehuss/raytracer [INFO] frobbed toml for ehuss/raytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ehuss/raytracer/Cargo.toml [INFO] crate ehuss/raytracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ehuss/raytracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ehuss/raytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2589c6f31b472e2c725b68f9fc82e580494f8bd53e67e0858cc3b85f09c8186f [INFO] running `"docker" "start" "-a" "2589c6f31b472e2c725b68f9fc82e580494f8bd53e67e0858cc3b85f09c8186f"` [INFO] [stderr] Compiling quote v0.2.3 [INFO] [stderr] Checking dylib v0.0.1 [INFO] [stderr] Compiling minifb v0.9.0 [INFO] [stderr] Checking clap v2.20.5 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking x11-dl v2.2.1 [INFO] [stderr] Compiling syn v0.8.7 [INFO] [stderr] Checking image v0.12.3 [INFO] [stderr] Compiling derive-new v0.4.0 [INFO] [stderr] Checking raytracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec3.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec3.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec3.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec3.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec3.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec3.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | hitable: hitable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `hitable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | sin_theta: sin_theta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sin_theta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | cos_theta: cos_theta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cos_theta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | bbox: bbox [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | material: material, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | let (u, v) = get_sphere_uv(&((p-self.center)/self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | let (u, v) = get_sphere_uv(&((p-self.center)/self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | let h = HitRecord::new(temp, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | let (u, v) = get_sphere_uv(&((p-self.center)/self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | let (u, v) = get_sphere_uv(&((p-self.center)/self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | let h = HitRecord::new(temp, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/moving_sphere.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | material: material, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/moving_sphere.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/moving_sphere.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | let h = HitRecord::new(temp, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/moving_sphere.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/moving_sphere.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | let h = HitRecord::new(temp, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:131:13 [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | lower_left_corner: lower_left_corner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_left_corner` [INFO] [stderr] 131 | hitable: hitable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `hitable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | horizontal: horizontal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | vertical: vertical, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | u: u, [INFO] [stderr] | ^^^^ help: replace it with: `u` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | v: v, [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] --> src/hitable.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | sin_theta: sin_theta, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | Dielectric { ref_idx: ref_idx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ref_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sin_theta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | cos_theta: cos_theta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cos_theta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | bbox: bbox [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bvh.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bvh.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | NoiseTexture{scale: scale} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] --> src/sphere.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | material: material, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:88:22 [INFO] [stderr] | [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] 88 | ImageTexture{img: img, nx: x, ny: y} [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] | ^^^^^^^^ help: replace it with: `img` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/texture.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | let mut j = ((1.-v)*self.ny as f64-0.001) as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | let (u, v) = get_sphere_uv(&((p-self.center)/self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | let (u, v) = get_sphere_uv(&((p-self.center)/self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:103:9 [INFO] [stderr] | [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | let h = HitRecord::new(temp, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] 103 | let i = p.x.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let j = p.y.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | let k = p.z.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut c = [0.; 8]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | let i = p.x.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | let j = p.y.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | let k = p.z.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:149:13 [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] 149 | let mut c = [0.; 8]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | let i = p.x.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | let j = p.y.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | let k = p.z.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:189:13 [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] | [INFO] [stderr] 189 | let mut c = [Vec3::zero(); 8]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] --> src/sphere.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | let (u, v) = get_sphere_uv(&((p-self.center)/self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/aarect.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | let u = (x-self.x0)/(self.x1-self.x0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] --> src/aarect.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let v = (y-self.y0)/(self.y1-self.y0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | let (u, v) = get_sphere_uv(&((p-self.center)/self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] --> src/aarect.rs:65:13 [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 65 | let u = (x-self.x0)/(self.x1-self.x0); [INFO] [stderr] | ^ [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] | [INFO] [stderr] --> src/sphere.rs:50:21 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 50 | let h = HitRecord::new(temp, [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/aarect.rs:66:13 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] 66 | let v = (z-self.z0)/(self.z1-self.z0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/aarect.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | let u = (y-self.y0)/(self.y1-self.y0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] [INFO] [stderr] --> src/aarect.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | let v = (z-self.z0)/(self.z1-self.z0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hbox.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | hlist: hlist [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hlist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/onb.rs:23:13 [INFO] [stderr] | [INFO] [stderr] --> src/moving_sphere.rs:36:13 [INFO] [stderr] 23 | let u = cross(&w, &v); [INFO] [stderr] | [INFO] [stderr] | ^ [INFO] [stderr] 36 | material: material, [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/moving_sphere.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/moving_sphere.rs:58:21 [INFO] [stderr] | [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] 58 | let h = HitRecord::new(temp, [INFO] [stderr] --> src/core.rs:92:21 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] 92 | let r = scene.camera.get_ray(rng, u, v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/moving_sphere.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/moving_sphere.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | let h = HitRecord::new(temp, [INFO] [stderr] | ^ [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output/gui.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] | [INFO] [stderr] --> src/output/gui.rs:26:13 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 26 | let g = (color[1] * 255.99) as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/output/gui.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let b = (color[2] * 255.99) as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | lower_left_corner: lower_left_corner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_left_corner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | horizontal: horizontal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | vertical: vertical, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | u: u, [INFO] [stderr] | ^^^^ help: replace it with: `u` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | v: v, [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | Dielectric { ref_idx: ref_idx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ref_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bvh.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bvh.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | NoiseTexture{scale: scale} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:88:22 [INFO] [stderr] | [INFO] [stderr] 88 | ImageTexture{img: img, nx: x, ny: y} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `img` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/texture.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | let mut j = ((1.-v)*self.ny as f64-0.001) as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | let i = p.x.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let j = p.y.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | let k = p.z.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut c = [0.; 8]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | let i = p.x.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | let j = p.y.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | let k = p.z.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | let mut c = [0.; 8]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | let i = p.x.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | let j = p.y.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | let k = p.z.floor() as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | let mut c = [Vec3::zero(); 8]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/aarect.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | let u = (x-self.x0)/(self.x1-self.x0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/aarect.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let v = (y-self.y0)/(self.y1-self.y0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/aarect.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | let u = (x-self.x0)/(self.x1-self.x0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/aarect.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let v = (z-self.z0)/(self.z1-self.z0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/aarect.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | let u = (y-self.y0)/(self.y1-self.y0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/aarect.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | let v = (z-self.z0)/(self.z1-self.z0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hbox.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | hlist: hlist [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hlist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/onb.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let u = cross(&w, &v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/core.rs:92:21 [INFO] [stderr] | [INFO] [stderr] 92 | let r = scene.camera.get_ray(rng, u, v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output/gui.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/output/gui.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | let g = (color[1] * 255.99) as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/output/gui.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let b = (color[2] * 255.99) as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/vec3.rs:260:15 [INFO] [stderr] | [INFO] [stderr] 260 | Vec3::new((v1.y * v2.z - v1.z * v2.y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/vec3.rs:261:15 [INFO] [stderr] | [INFO] [stderr] 261 | (-(v1.x * v2.z - v1.z * v2.x)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/vec3.rs:262:15 [INFO] [stderr] | [INFO] [stderr] 262 | (v1.x * v2.y - v1.y * v2.x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / return self.hitable.hit(rng, &rotated_r, t_min, t_max).map(|mut rec| { [INFO] [stderr] 149 | | let mut p = rec.p.clone(); [INFO] [stderr] 150 | | let mut normal = rec.normal.clone(); [INFO] [stderr] 151 | | p[0] = self.cos_theta*rec.p[0] + self.sin_theta*rec.p[2]; [INFO] [stderr] ... | [INFO] [stderr] 157 | | rec [INFO] [stderr] 158 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 148 | self.hitable.hit(rng, &rotated_r, t_min, t_max).map(|mut rec| { [INFO] [stderr] 149 | let mut p = rec.p.clone(); [INFO] [stderr] 150 | let mut normal = rec.normal.clone(); [INFO] [stderr] 151 | p[0] = self.cos_theta*rec.p[0] + self.sin_theta*rec.p[2]; [INFO] [stderr] 152 | p[2] = -self.sin_theta*rec.p[0] + self.cos_theta*rec.p[2]; [INFO] [stderr] 153 | normal[0] = self.cos_theta*rec.normal[0] + self.sin_theta*rec.normal[2]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable_list.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable_list.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable_list.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return self.list[index].random(rng, o); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.list[index].random(rng, o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return uvw.local_vec(&random_to_sphere(rng, self.radius, distance_squared)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `uvw.local_vec(&random_to_sphere(rng, self.radius, distance_squared))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return (u,v); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `(u,v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/moving_sphere.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/moving_sphere.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return Some(surrounding_box(&box0, &box1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(surrounding_box(&box0, &box1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return Some(ni_over_nt * (uv - n * dt) - n * discriminant.sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ni_over_nt * (uv - n * dt) - n * discriminant.sqrt())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return r0 + (1.0 - r0) * (1.0 - cosine).powi(5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r0 + (1.0 - r0) * (1.0 - cosine).powi(5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return cosine / PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cosine / PI` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | / return Some(ScatterRecord{ [INFO] [stderr] 200 | | specular_ray: Some(specular_ray), [INFO] [stderr] 201 | | attenuation: Vec3::new(1., 1., 1.), [INFO] [stderr] 202 | | pdf: None [INFO] [stderr] 203 | | [INFO] [stderr] 204 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 199 | Some(ScatterRecord{ [INFO] [stderr] 200 | specular_ray: Some(specular_ray), [INFO] [stderr] 201 | attenuation: Vec3::new(1., 1., 1.), [INFO] [stderr] 202 | pdf: None [INFO] [stderr] 203 | [INFO] [stderr] 204 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | return self.emit.value(u, v, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.emit.value(u, v, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | return Vec3::zero(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return Axis::X; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Axis::X` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return Axis::Y; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Axis::Y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return Axis::Z; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Axis::Z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return 2.0 * (a*b + b*c + c*a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `2.0 * (a*b + b*c + c*a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | return AABB::new(small, big); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `AABB::new(small, big)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bvh.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/texture.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | return self.odd.value(u, v, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.odd.value(u, v, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/texture.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | return self.even.value(u, v, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.even.value(u, v, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/texture.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return Vec3::new(p[0] as f64/255., p[1] as f64/255., p[2] as f64/255.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(p[0] as f64/255., p[1] as f64/255., p[2] as f64/255.)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return RF[(PX[i] ^ PY[j] ^ PZ[k]) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RF[(PX[i] ^ PY[j] ^ PZ[k]) as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | return accum; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | return accum; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | return accum; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | return accum.abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `accum.abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aarect.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aarect.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aarect.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return random_point - *o; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `random_point - *o` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aarect.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/onb.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return Onb {axis: [u, v, w]}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Onb {axis: [u, v, w]}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return Vec3::new(x,y,z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(x,y,z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return Vec3::new(x, y, z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(x, y, z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return cosine/PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cosine/PI` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | return 0. [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return self.uvw.local_vec(&random_cosine_direction(rng)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.uvw.local_vec(&random_cosine_direction(rng))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return self.hitable.pdf_value(rng, &self.o, direction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.hitable.pdf_value(rng, &self.o, direction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return self.hitable.random(rng, &self.o); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.hitable.random(rng, &self.o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return 0.5 * self.pdf0.value(rng, direction) + 0.5 * self.pdf1.value(rng, direction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `0.5 * self.pdf0.value(rng, direction) + 0.5 * self.pdf1.value(rng, direction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | return self.pdf0.generate(rng); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pdf0.generate(rng)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | return self.pdf1.generate(rng); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pdf1.generate(rng)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Vec3::new(x, y, z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(x, y, z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/output/buckets.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | return buckets; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/output/buckets.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | return buckets; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / macro_rules! perrln { [INFO] [stderr] 57 | | ($($arg:tt)*) => ({ [INFO] [stderr] 58 | | use std::io::{Write, stderr}; [INFO] [stderr] 59 | | writeln!(&mut stderr(), $($arg)*).ok(); [INFO] [stderr] 60 | | }) [INFO] [stderr] 61 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/vec3.rs:260:15 [INFO] [stderr] | [INFO] [stderr] 260 | Vec3::new((v1.y * v2.z - v1.z * v2.y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/vec3.rs:261:15 [INFO] [stderr] | [INFO] [stderr] 261 | (-(v1.x * v2.z - v1.z * v2.x)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/vec3.rs:262:15 [INFO] [stderr] | [INFO] [stderr] 262 | (v1.x * v2.y - v1.y * v2.x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / return self.hitable.hit(rng, &rotated_r, t_min, t_max).map(|mut rec| { [INFO] [stderr] 149 | | let mut p = rec.p.clone(); [INFO] [stderr] 150 | | let mut normal = rec.normal.clone(); [INFO] [stderr] 151 | | p[0] = self.cos_theta*rec.p[0] + self.sin_theta*rec.p[2]; [INFO] [stderr] ... | [INFO] [stderr] 157 | | rec [INFO] [stderr] 158 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 148 | self.hitable.hit(rng, &rotated_r, t_min, t_max).map(|mut rec| { [INFO] [stderr] 149 | let mut p = rec.p.clone(); [INFO] [stderr] 150 | let mut normal = rec.normal.clone(); [INFO] [stderr] 151 | p[0] = self.cos_theta*rec.p[0] + self.sin_theta*rec.p[2]; [INFO] [stderr] 152 | p[2] = -self.sin_theta*rec.p[0] + self.cos_theta*rec.p[2]; [INFO] [stderr] 153 | normal[0] = self.cos_theta*rec.normal[0] + self.sin_theta*rec.normal[2]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable_list.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable_list.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable_list.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return self.list[index].random(rng, o); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.list[index].random(rng, o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return uvw.local_vec(&random_to_sphere(rng, self.radius, distance_squared)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `uvw.local_vec(&random_to_sphere(rng, self.radius, distance_squared))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return (u,v); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `(u,v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/moving_sphere.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/moving_sphere.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return Some(surrounding_box(&box0, &box1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(surrounding_box(&box0, &box1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return Some(ni_over_nt * (uv - n * dt) - n * discriminant.sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ni_over_nt * (uv - n * dt) - n * discriminant.sqrt())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return r0 + (1.0 - r0) * (1.0 - cosine).powi(5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r0 + (1.0 - r0) * (1.0 - cosine).powi(5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return cosine / PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cosine / PI` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | / return Some(ScatterRecord{ [INFO] [stderr] 200 | | specular_ray: Some(specular_ray), [INFO] [stderr] 201 | | attenuation: Vec3::new(1., 1., 1.), [INFO] [stderr] 202 | | pdf: None [INFO] [stderr] 203 | | [INFO] [stderr] 204 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 199 | Some(ScatterRecord{ [INFO] [stderr] 200 | specular_ray: Some(specular_ray), [INFO] [stderr] 201 | attenuation: Vec3::new(1., 1., 1.), [INFO] [stderr] 202 | pdf: None [INFO] [stderr] 203 | [INFO] [stderr] 204 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | return self.emit.value(u, v, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.emit.value(u, v, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | return Vec3::zero(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return Axis::X; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Axis::X` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return Axis::Y; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Axis::Y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return Axis::Z; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Axis::Z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return 2.0 * (a*b + b*c + c*a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `2.0 * (a*b + b*c + c*a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aabb.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | return AABB::new(small, big); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `AABB::new(small, big)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bvh.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/texture.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | return self.odd.value(u, v, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.odd.value(u, v, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/texture.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | return self.even.value(u, v, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.even.value(u, v, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/texture.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return Vec3::new(p[0] as f64/255., p[1] as f64/255., p[2] as f64/255.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(p[0] as f64/255., p[1] as f64/255., p[2] as f64/255.)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return RF[(PX[i] ^ PY[j] ^ PZ[k]) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RF[(PX[i] ^ PY[j] ^ PZ[k]) as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | return accum; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | return accum; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | return accum; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | return accum.abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `accum.abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aarect.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aarect.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aarect.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return random_point - *o; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `random_point - *o` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aarect.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(HitRecord::new(t, u, v, r.point_at_parameter(t), normal, self.material.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/onb.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return Onb {axis: [u, v, w]}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Onb {axis: [u, v, w]}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return Vec3::new(x,y,z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(x,y,z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return Vec3::new(x, y, z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(x, y, z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return cosine/PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cosine/PI` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | return 0. [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return self.uvw.local_vec(&random_cosine_direction(rng)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.uvw.local_vec(&random_cosine_direction(rng))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return self.hitable.pdf_value(rng, &self.o, direction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.hitable.pdf_value(rng, &self.o, direction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return self.hitable.random(rng, &self.o); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.hitable.random(rng, &self.o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return 0.5 * self.pdf0.value(rng, direction) + 0.5 * self.pdf1.value(rng, direction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `0.5 * self.pdf0.value(rng, direction) + 0.5 * self.pdf1.value(rng, direction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | return self.pdf0.generate(rng); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pdf0.generate(rng)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdf.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | return self.pdf1.generate(rng); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pdf1.generate(rng)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Vec3::new(x, y, z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(x, y, z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/output/buckets.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | return buckets; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/output/buckets.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | return buckets; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / macro_rules! perrln { [INFO] [stderr] 57 | | ($($arg:tt)*) => ({ [INFO] [stderr] 58 | | use std::io::{Write, stderr}; [INFO] [stderr] 59 | | writeln!(&mut stderr(), $($arg)*).ok(); [INFO] [stderr] 60 | | }) [INFO] [stderr] 61 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DummyNode` [INFO] [stderr] --> src/bvh.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | struct DummyNode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/vec3.rs:236:44 [INFO] [stderr] | [INFO] [stderr] 236 | fn as_ref(&self) -> &[T; 3] { unsafe { mem::transmute(self) } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const vec3::Vec3 as *const [T; 3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/vec3.rs:242:18 [INFO] [stderr] | [INFO] [stderr] 242 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut vec3::Vec3 as *mut [T; 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hitable.rs:106:26 [INFO] [stderr] | [INFO] [stderr] 106 | let fi = i as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hitable.rs:108:30 [INFO] [stderr] | [INFO] [stderr] 108 | let fj = j as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hitable.rs:110:34 [INFO] [stderr] | [INFO] [stderr] 110 | let fk = k as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hitable.rs:141:26 [INFO] [stderr] | [INFO] [stderr] 141 | let mut origin = r.origin().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `r.origin()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hitable.rs:142:29 [INFO] [stderr] | [INFO] [stderr] 142 | let mut direction = r.direction().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `r.direction()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hitable.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | let mut p = rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hitable.rs:150:30 [INFO] [stderr] | [INFO] [stderr] 150 | let mut normal = rec.normal.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hitable_list::HitableList<'a>` [INFO] [stderr] --> src/hitable_list.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> HitableList<'a> { [INFO] [stderr] 15 | | HitableList { list: Vec::new() } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/hitable_list.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | if self.list.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sphere.rs:67:53 [INFO] [stderr] | [INFO] [stderr] 67 | if let Some(hrec) = self.hit(rng, &Ray::new(o.clone(), v.clone()), 0.001, f64::MAX) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*o` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sphere.rs:67:64 [INFO] [stderr] | [INFO] [stderr] 67 | if let Some(hrec) = self.hit(rng, &Ray::new(o.clone(), v.clone()), 0.001, f64::MAX) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/camera.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new(lookfrom: Vec3, [INFO] [stderr] 37 | | lookat: Vec3, [INFO] [stderr] 38 | | vup: Vec3, [INFO] [stderr] 39 | | vfov: f64, [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `util::Rng` [INFO] [stderr] --> src/util.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Rng { [INFO] [stderr] 15 | | Rng { rng: rand::weak_rng() } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for util::Rng { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bvh.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / let left; [INFO] [stderr] 136 | | if min_sah_idx == 0 { [INFO] [stderr] 137 | | left = l.remove(0); [INFO] [stderr] 138 | | } else { [INFO] [stderr] 139 | | left = Box::new(BVHNode::new(rng, l, time0, time1)); [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let left = if min_sah_idx == 0 { l.remove(0) } else { Box::new(BVHNode::new(rng, l, time0, time1)) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bvh.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / let right; [INFO] [stderr] 143 | | if rest.len() == 1 { [INFO] [stderr] 144 | | right = rest.remove(0); [INFO] [stderr] 145 | | } else { [INFO] [stderr] 146 | | right = Box::new(BVHNode::new(rng, rest, time0, time1)); [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let right = if rest.len() == 1 { rest.remove(0) } else { Box::new(BVHNode::new(rng, rest, time0, time1)) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `boxes`. [INFO] [stderr] --> src/bvh.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 1..n-1 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for in boxes.iter().take(n-1).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | let mut i = (u*self.nx as f64) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(self.nx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | let mut j = ((1.-v)*self.ny as f64-0.001) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(self.ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:110:26 [INFO] [stderr] | [INFO] [stderr] 110 | return Vec3::new(p[0] as f64/255., p[1] as f64/255., p[2] as f64/255.); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(p[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:110:44 [INFO] [stderr] | [INFO] [stderr] 110 | return Vec3::new(p[0] as f64/255., p[1] as f64/255., p[2] as f64/255.); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(p[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:110:62 [INFO] [stderr] | [INFO] [stderr] 110 | return Vec3::new(p[0] as f64/255., p[1] as f64/255., p[2] as f64/255.); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(p[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `result` [INFO] [stderr] --> src/perlin.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 43 | for (i, ) in result.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `p` manually [INFO] [stderr] --> src/perlin.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / let tmp = p[i]; [INFO] [stderr] 56 | | p[i] = p[target]; [INFO] [stderr] 57 | | p[target] = tmp; [INFO] [stderr] | |_______________________^ help: try: `p.swap(i, target)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `result`. [INFO] [stderr] --> src/perlin.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 64 | for in &mut result { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `result`. [INFO] [stderr] --> src/perlin.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for in &mut result { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/perlin.rs:225:22 [INFO] [stderr] | [INFO] [stderr] 225 | let mut temp_p = p.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aarect.rs:77:52 [INFO] [stderr] | [INFO] [stderr] 77 | if let Some(rec) = self.hit(rng, &Ray::new(o.clone(), v.clone()), 0.001, f64::MAX) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*o` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aarect.rs:77:63 [INFO] [stderr] | [INFO] [stderr] 77 | if let Some(rec) = self.hit(rng, &Ray::new(o.clone(), v.clone()), 0.001, f64::MAX) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `onb::Onb` [INFO] [stderr] --> src/onb.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Onb { [INFO] [stderr] 10 | | Onb { [INFO] [stderr] 11 | | axis: [Vec3::zero(), Vec3::zero(), Vec3::zero()] [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/onb.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / let a; [INFO] [stderr] 17 | | if w.x.abs() > 0.9 { [INFO] [stderr] 18 | | a = Vec3::new(0., 1., 0.); [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | a = Vec3::new(1., 0., 0.); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let a = if w.x.abs() > 0.9 { Vec3::new(0., 1., 0.) } else { Vec3::new(1., 0., 0.) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/core.rs:54:72 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn render(scene: &Scene, output_settings: &OutputSettings, output: &mut Box) -> output::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&mut Output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/core.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | output: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&mut Output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:90:26 [INFO] [stderr] | [INFO] [stderr] 90 | let u = (i as f64 + rng.rand64()) / width as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:90:53 [INFO] [stderr] | [INFO] [stderr] 90 | let u = (i as f64 + rng.rand64()) / width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:91:26 [INFO] [stderr] | [INFO] [stderr] 91 | let v = (j as f64 + rng.rand64()) / height as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:91:53 [INFO] [stderr] | [INFO] [stderr] 91 | let v = (j as f64 + rng.rand64()) / height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | col /= ns as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ns)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/output/image.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new(settings: &OutputSettings, scene: &Scene) -> Result { [INFO] [stderr] 18 | | Ok(ImageOutput{ [INFO] [stderr] 19 | | buf: image::ImageBuffer::new(settings.width, settings.height), [INFO] [stderr] 20 | | path: path_from_template(&settings.filename_template, scene), [INFO] [stderr] 21 | | }) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/output/mod.rs:19:55 [INFO] [stderr] | [INFO] [stderr] 19 | fn put_bucket(&mut self, bucket: &Bucket, pixels: &Vec>>) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | camera: camera, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DummyNode` [INFO] [stderr] --> src/bvh.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | struct DummyNode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | camera: camera, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/vec3.rs:236:44 [INFO] [stderr] | [INFO] [stderr] 236 | fn as_ref(&self) -> &[T; 3] { unsafe { mem::transmute(self) } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const vec3::Vec3 as *const [T; 3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/vec3.rs:242:18 [INFO] [stderr] | [INFO] [stderr] 242 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut vec3::Vec3 as *mut [T; 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/vec3.rs:288:20 [INFO] [stderr] | [INFO] [stderr] 288 | assert_eq!(&a + &b, Vec3::new(1.0, 2.0, 3.0)); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 288 | assert_eq!(a + b, Vec3::new(1.0, 2.0, 3.0)); [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/vec3.rs:289:20 [INFO] [stderr] | [INFO] [stderr] 289 | assert_eq!(&b + &b, Vec3::new(2.0, 4.0, 6.0)); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 289 | assert_eq!(b + b, Vec3::new(2.0, 4.0, 6.0)); [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/vec3.rs:305:20 [INFO] [stderr] | [INFO] [stderr] 305 | assert_eq!(&b - &a, Vec3::new(0.0, 1.0, 2.0)); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 305 | assert_eq!(b - a, Vec3::new(0.0, 1.0, 2.0)); [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/vec3.rs:306:20 [INFO] [stderr] | [INFO] [stderr] 306 | assert_eq!(&b - &b, Vec3::new(0.0, 0.0, 0.0)); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vec3.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | assert_eq!(dot(&a, &b), 32.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vec3.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | assert_eq!(dot(&a, &b), 32.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hitable.rs:106:26 [INFO] [stderr] | [INFO] [stderr] 106 | let fi = i as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hitable.rs:108:30 [INFO] [stderr] | [INFO] [stderr] 108 | let fj = j as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hitable.rs:110:34 [INFO] [stderr] | [INFO] [stderr] 110 | let fk = k as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hitable.rs:141:26 [INFO] [stderr] | [INFO] [stderr] 141 | let mut origin = r.origin().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `r.origin()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hitable.rs:142:29 [INFO] [stderr] | [INFO] [stderr] 142 | let mut direction = r.direction().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `r.direction()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hitable.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | let mut p = rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hitable.rs:150:30 [INFO] [stderr] | [INFO] [stderr] 150 | let mut normal = rec.normal.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hitable_list::HitableList<'a>` [INFO] [stderr] --> src/hitable_list.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> HitableList<'a> { [INFO] [stderr] 15 | | HitableList { list: Vec::new() } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/hitable_list.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | if self.list.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sphere.rs:67:53 [INFO] [stderr] | [INFO] [stderr] 67 | if let Some(hrec) = self.hit(rng, &Ray::new(o.clone(), v.clone()), 0.001, f64::MAX) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*o` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sphere.rs:67:64 [INFO] [stderr] | [INFO] [stderr] 67 | if let Some(hrec) = self.hit(rng, &Ray::new(o.clone(), v.clone()), 0.001, f64::MAX) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/camera.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new(lookfrom: Vec3, [INFO] [stderr] 37 | | lookat: Vec3, [INFO] [stderr] 38 | | vup: Vec3, [INFO] [stderr] 39 | | vfov: f64, [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `util::Rng` [INFO] [stderr] --> src/util.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Rng { [INFO] [stderr] 15 | | Rng { rng: rand::weak_rng() } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for util::Rng { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bvh.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / let left; [INFO] [stderr] 136 | | if min_sah_idx == 0 { [INFO] [stderr] 137 | | left = l.remove(0); [INFO] [stderr] 138 | | } else { [INFO] [stderr] 139 | | left = Box::new(BVHNode::new(rng, l, time0, time1)); [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let left = if min_sah_idx == 0 { l.remove(0) } else { Box::new(BVHNode::new(rng, l, time0, time1)) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bvh.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / let right; [INFO] [stderr] 143 | | if rest.len() == 1 { [INFO] [stderr] 144 | | right = rest.remove(0); [INFO] [stderr] 145 | | } else { [INFO] [stderr] 146 | | right = Box::new(BVHNode::new(rng, rest, time0, time1)); [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let right = if rest.len() == 1 { rest.remove(0) } else { Box::new(BVHNode::new(rng, rest, time0, time1)) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `boxes`. [INFO] [stderr] --> src/bvh.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 1..n-1 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for in boxes.iter().take(n-1).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | let mut i = (u*self.nx as f64) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(self.nx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | let mut j = ((1.-v)*self.ny as f64-0.001) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(self.ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:110:26 [INFO] [stderr] | [INFO] [stderr] 110 | return Vec3::new(p[0] as f64/255., p[1] as f64/255., p[2] as f64/255.); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(p[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:110:44 [INFO] [stderr] | [INFO] [stderr] 110 | return Vec3::new(p[0] as f64/255., p[1] as f64/255., p[2] as f64/255.); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(p[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:110:62 [INFO] [stderr] | [INFO] [stderr] 110 | return Vec3::new(p[0] as f64/255., p[1] as f64/255., p[2] as f64/255.); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(p[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `result` [INFO] [stderr] --> src/perlin.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 43 | for (i, ) in result.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `p` manually [INFO] [stderr] --> src/perlin.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / let tmp = p[i]; [INFO] [stderr] 56 | | p[i] = p[target]; [INFO] [stderr] 57 | | p[target] = tmp; [INFO] [stderr] | |_______________________^ help: try: `p.swap(i, target)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `result`. [INFO] [stderr] --> src/perlin.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 64 | for in &mut result { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `result`. [INFO] [stderr] --> src/perlin.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for in &mut result { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/perlin.rs:225:22 [INFO] [stderr] | [INFO] [stderr] 225 | let mut temp_p = p.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aarect.rs:77:52 [INFO] [stderr] | [INFO] [stderr] 77 | if let Some(rec) = self.hit(rng, &Ray::new(o.clone(), v.clone()), 0.001, f64::MAX) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*o` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aarect.rs:77:63 [INFO] [stderr] | [INFO] [stderr] 77 | if let Some(rec) = self.hit(rng, &Ray::new(o.clone(), v.clone()), 0.001, f64::MAX) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `onb::Onb` [INFO] [stderr] --> src/onb.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Onb { [INFO] [stderr] 10 | | Onb { [INFO] [stderr] 11 | | axis: [Vec3::zero(), Vec3::zero(), Vec3::zero()] [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/onb.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / let a; [INFO] [stderr] 17 | | if w.x.abs() > 0.9 { [INFO] [stderr] 18 | | a = Vec3::new(0., 1., 0.); [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | a = Vec3::new(1., 0., 0.); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let a = if w.x.abs() > 0.9 { Vec3::new(0., 1., 0.) } else { Vec3::new(1., 0., 0.) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/core.rs:54:72 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn render(scene: &Scene, output_settings: &OutputSettings, output: &mut Box) -> output::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&mut Output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/core.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | output: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&mut Output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:90:26 [INFO] [stderr] | [INFO] [stderr] 90 | let u = (i as f64 + rng.rand64()) / width as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:90:53 [INFO] [stderr] | [INFO] [stderr] 90 | let u = (i as f64 + rng.rand64()) / width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:91:26 [INFO] [stderr] | [INFO] [stderr] 91 | let v = (j as f64 + rng.rand64()) / height as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:91:53 [INFO] [stderr] | [INFO] [stderr] 91 | let v = (j as f64 + rng.rand64()) / height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | col /= ns as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ns)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/output/image.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new(settings: &OutputSettings, scene: &Scene) -> Result { [INFO] [stderr] 18 | | Ok(ImageOutput{ [INFO] [stderr] 19 | | buf: image::ImageBuffer::new(settings.width, settings.height), [INFO] [stderr] 20 | | path: path_from_template(&settings.filename_template, scene), [INFO] [stderr] 21 | | }) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/output/mod.rs:19:55 [INFO] [stderr] | [INFO] [stderr] 19 | fn put_bucket(&mut self, bucket: &Bucket, pixels: &Vec>>) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `raytracer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench_perlin.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `raytracer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench_hit.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `raytracer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / return Scene { [INFO] [stderr] 113 | | world: Box::new(list), [INFO] [stderr] 114 | | light_shapes: Box::new(light_shapes), [INFO] [stderr] 115 | | camera: camera, [INFO] [stderr] 116 | | output_settings: output, [INFO] [stderr] 117 | | num_samples: 100, [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | Scene { [INFO] [stderr] 113 | world: Box::new(list), [INFO] [stderr] 114 | light_shapes: Box::new(light_shapes), [INFO] [stderr] 115 | camera: camera, [INFO] [stderr] 116 | output_settings: output, [INFO] [stderr] 117 | num_samples: 100, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:98:30 [INFO] [stderr] | [INFO] [stderr] 98 | nx as f64 / ny as f64, // aspect [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:98:42 [INFO] [stderr] | [INFO] [stderr] 98 | nx as f64 / ny as f64, // aspect [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / return Scene { [INFO] [stderr] 113 | | world: Box::new(list), [INFO] [stderr] 114 | | light_shapes: Box::new(light_shapes), [INFO] [stderr] 115 | | camera: camera, [INFO] [stderr] 116 | | output_settings: output, [INFO] [stderr] 117 | | num_samples: 100, [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | Scene { [INFO] [stderr] 113 | world: Box::new(list), [INFO] [stderr] 114 | light_shapes: Box::new(light_shapes), [INFO] [stderr] 115 | camera: camera, [INFO] [stderr] 116 | output_settings: output, [INFO] [stderr] 117 | num_samples: 100, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:98:30 [INFO] [stderr] | [INFO] [stderr] 98 | nx as f64 / ny as f64, // aspect [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:98:42 [INFO] [stderr] | [INFO] [stderr] 98 | nx as f64 / ny as f64, // aspect [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2589c6f31b472e2c725b68f9fc82e580494f8bd53e67e0858cc3b85f09c8186f"` [INFO] running `"docker" "rm" "-f" "2589c6f31b472e2c725b68f9fc82e580494f8bd53e67e0858cc3b85f09c8186f"` [INFO] [stdout] 2589c6f31b472e2c725b68f9fc82e580494f8bd53e67e0858cc3b85f09c8186f