[INFO] updating cached repository eeeeeta/f24-telemetry-agent [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eeeeeta/f24-telemetry-agent [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eeeeeta/f24-telemetry-agent" "work/ex/clippy-test-run/sources/stable/gh/eeeeeta/f24-telemetry-agent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eeeeeta/f24-telemetry-agent'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eeeeeta/f24-telemetry-agent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eeeeeta/f24-telemetry-agent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eeeeeta/f24-telemetry-agent'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cb0a4704a38e69ba9776b3d42e7d04f676595a82 [INFO] sha for GitHub repo eeeeeta/f24-telemetry-agent: cb0a4704a38e69ba9776b3d42e7d04f676595a82 [INFO] validating manifest of eeeeeta/f24-telemetry-agent on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eeeeeta/f24-telemetry-agent on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eeeeeta/f24-telemetry-agent [INFO] finished frobbing eeeeeta/f24-telemetry-agent [INFO] frobbed toml for eeeeeta/f24-telemetry-agent written to work/ex/clippy-test-run/sources/stable/gh/eeeeeta/f24-telemetry-agent/Cargo.toml [INFO] started frobbing eeeeeta/f24-telemetry-agent [INFO] finished frobbing eeeeeta/f24-telemetry-agent [INFO] frobbed toml for eeeeeta/f24-telemetry-agent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eeeeeta/f24-telemetry-agent/Cargo.toml [INFO] crate eeeeeta/f24-telemetry-agent has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eeeeeta/f24-telemetry-agent against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eeeeeta/f24-telemetry-agent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3fec6150582f234e9dc4b0865ecdabf36391103f69f9e86ed247466913e06d2 [INFO] running `"docker" "start" "-a" "c3fec6150582f234e9dc4b0865ecdabf36391103f69f9e86ed247466913e06d2"` [INFO] [stderr] Checking tokio-current-thread v0.1.2 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking unbounded-gpsd v0.4.3 [INFO] [stderr] Checking tokio v0.1.9 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking hyper v0.12.10 [INFO] [stderr] Checking hyper-tls v0.3.0 [INFO] [stderr] Checking f24-telemetry-agent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gpsd.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / match resp { [INFO] [stderr] 26 | | Response::Tpv(tpv) => { [INFO] [stderr] 27 | | match tpv { [INFO] [stderr] 28 | | TpvResponse::Fix3D { time, lat, lon, speed, track, .. } | [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => {} [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | if let Response::Tpv(tpv) = resp { [INFO] [stderr] 26 | match tpv { [INFO] [stderr] 27 | TpvResponse::Fix3D { time, lat, lon, speed, track, .. } | [INFO] [stderr] 28 | TpvResponse::Fix2D { time, lat, lon, speed, track, .. } => { [INFO] [stderr] 29 | let ts = time.timestamp() as u64; [INFO] [stderr] 30 | info!("[G] Got new GPS TPV response, ts: {}", ts); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/arduino.rs:32:44 [INFO] [stderr] | [INFO] [stderr] 32 | let mut fragments = line.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gpsd.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / match resp { [INFO] [stderr] 26 | | Response::Tpv(tpv) => { [INFO] [stderr] 27 | | match tpv { [INFO] [stderr] 28 | | TpvResponse::Fix3D { time, lat, lon, speed, track, .. } | [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => {} [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | if let Response::Tpv(tpv) = resp { [INFO] [stderr] 26 | match tpv { [INFO] [stderr] 27 | TpvResponse::Fix3D { time, lat, lon, speed, track, .. } | [INFO] [stderr] 28 | TpvResponse::Fix2D { time, lat, lon, speed, track, .. } => { [INFO] [stderr] 29 | let ts = time.timestamp() as u64; [INFO] [stderr] 30 | info!("[G] Got new GPS TPV response, ts: {}", ts); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/arduino.rs:32:44 [INFO] [stderr] | [INFO] [stderr] 32 | let mut fragments = line.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.85s [INFO] running `"docker" "inspect" "c3fec6150582f234e9dc4b0865ecdabf36391103f69f9e86ed247466913e06d2"` [INFO] running `"docker" "rm" "-f" "c3fec6150582f234e9dc4b0865ecdabf36391103f69f9e86ed247466913e06d2"` [INFO] [stdout] c3fec6150582f234e9dc4b0865ecdabf36391103f69f9e86ed247466913e06d2