[INFO] updating cached repository eeeeeta/dnd-irc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eeeeeta/dnd-irc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eeeeeta/dnd-irc" "work/ex/clippy-test-run/sources/stable/gh/eeeeeta/dnd-irc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eeeeeta/dnd-irc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eeeeeta/dnd-irc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eeeeeta/dnd-irc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eeeeeta/dnd-irc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 18911c336b50f66ca61dbb9060f105944513ce4d [INFO] sha for GitHub repo eeeeeta/dnd-irc: 18911c336b50f66ca61dbb9060f105944513ce4d [INFO] validating manifest of eeeeeta/dnd-irc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eeeeeta/dnd-irc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eeeeeta/dnd-irc [INFO] finished frobbing eeeeeta/dnd-irc [INFO] frobbed toml for eeeeeta/dnd-irc written to work/ex/clippy-test-run/sources/stable/gh/eeeeeta/dnd-irc/Cargo.toml [INFO] started frobbing eeeeeta/dnd-irc [INFO] finished frobbing eeeeeta/dnd-irc [INFO] frobbed toml for eeeeeta/dnd-irc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eeeeeta/dnd-irc/Cargo.toml [INFO] crate eeeeeta/dnd-irc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eeeeeta/dnd-irc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eeeeeta/dnd-irc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 471f28f449175692bbe5facc2eb3b3c8dbf43d87821eb86d9f52c9e368f05cff [INFO] running `"docker" "start" "-a" "471f28f449175692bbe5facc2eb3b3c8dbf43d87821eb86d9f52c9e368f05cff"` [INFO] [stderr] Checking inotify-sys v0.1.2 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Checking inotify v0.5.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking irc v0.13.5 [INFO] [stderr] Checking dnd-irc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | chan: chan [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `chan` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | chan: chan [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `chan` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | / if c.turn != new.turn { [INFO] [stderr] 183 | | if new.turn { [INFO] [stderr] 184 | | self.irc.0.send_privmsg(&self.chan, &format!("It's now \x02{}\x0F's turn.", name))?; [INFO] [stderr] 185 | | self.print_combatant(&name, new.clone())?; [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | if c.turn != new.turn && new.turn { [INFO] [stderr] 183 | self.irc.0.send_privmsg(&self.chan, &format!("It's now \x02{}\x0F's turn.", name))?; [INFO] [stderr] 184 | self.print_combatant(&name, new.clone())?; [INFO] [stderr] 185 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | / if c.turn != new.turn { [INFO] [stderr] 183 | | if new.turn { [INFO] [stderr] 184 | | self.irc.0.send_privmsg(&self.chan, &format!("It's now \x02{}\x0F's turn.", name))?; [INFO] [stderr] 185 | | self.print_combatant(&name, new.clone())?; [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | if c.turn != new.turn && new.turn { [INFO] [stderr] 183 | self.irc.0.send_privmsg(&self.chan, &format!("It's now \x02{}\x0F's turn.", name))?; [INFO] [stderr] 184 | self.print_combatant(&name, new.clone())?; [INFO] [stderr] 185 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | 1...25 => ("\x0305", "Mutilated"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/main.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | 25...51 => ("\x0307", "Bloodied"), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | let msg = res.ok_or(format_err!("irc_stream stopped"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("irc_stream stopped"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:104:27 [INFO] [stderr] | [INFO] [stderr] 104 | let ine = ine.ok_or(format_err!("inotify stopped"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("inotify stopped"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:131:46 [INFO] [stderr] | [INFO] [stderr] 131 | self.irc.0.send_privmsg(&self.chan, &format!("\x02\x0304Initiative table:"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\x02\x0304Initiative table:".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | self.combatants.get(&name).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.combatants[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:234:43 [INFO] [stderr] | [INFO] [stderr] 234 | let from = from.split("!").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:235:24 [INFO] [stderr] | [INFO] [stderr] 235 | if from.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `from.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | 1...25 => ("\x0305", "Mutilated"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/main.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | 25...51 => ("\x0307", "Bloodied"), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | let msg = res.ok_or(format_err!("irc_stream stopped"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("irc_stream stopped"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:104:27 [INFO] [stderr] | [INFO] [stderr] 104 | let ine = ine.ok_or(format_err!("inotify stopped"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("inotify stopped"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:131:46 [INFO] [stderr] | [INFO] [stderr] 131 | self.irc.0.send_privmsg(&self.chan, &format!("\x02\x0304Initiative table:"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\x02\x0304Initiative table:".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | self.combatants.get(&name).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.combatants[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:234:43 [INFO] [stderr] | [INFO] [stderr] 234 | let from = from.split("!").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:235:24 [INFO] [stderr] | [INFO] [stderr] 235 | if from.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `from.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.12s [INFO] running `"docker" "inspect" "471f28f449175692bbe5facc2eb3b3c8dbf43d87821eb86d9f52c9e368f05cff"` [INFO] running `"docker" "rm" "-f" "471f28f449175692bbe5facc2eb3b3c8dbf43d87821eb86d9f52c9e368f05cff"` [INFO] [stdout] 471f28f449175692bbe5facc2eb3b3c8dbf43d87821eb86d9f52c9e368f05cff